Linux kernel stable tree (mirror) https://git.radix-linux.su/kernel/linux.git/atom?h=v6.12.80 2024-04-26T21:22:43+00:00 2024-04-26T21:22:43+00:00 Bob Zhou bob.zhou@amd.com 2024-04-24T07:24:05+00:00 urn:sha1:cd48b97ce7787cf271f56ed4ea2037e1680cb29a After amdgpu_i2c_get_byte fail, amdgpu_i2c_put_byte shouldn't be conducted to put wrong value. So return and check the i2c transfer result. Signed-off-by: Bob Zhou <bob.zhou@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2024-01-18T20:10:41+00:00 Heiner Kallweit hkallweit1@gmail.com 2023-11-23T09:40:21+00:00 urn:sha1:e965a707276760cc010eb77fba64b08ee9e8781f After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Acked-by: Alex Deucher <alexander.deucher@amd.com> Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Acked-by: Harry Wentland <harry.wentland@amd.com> Acked-by: Heiko Stuebner <heiko@sntech.de> Acked-by: Jani Nikula <jani.nikula@intel.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: Wolfram Sang <wsa@kernel.org> 2021-08-11T21:19:54+00:00 Tuo Li islituo@gmail.com 2021-08-11T11:34:58+00:00 urn:sha1:a211260c34cfadc6068fece8c9e99e0fe1e2a2b6 The variable val is declared without initialization, and its address is passed to amdgpu_i2c_get_byte(). In this function, the value of val is accessed in: DRM_DEBUG("i2c 0x%02x 0x%02x read failed\n", addr, *val); Also, when amdgpu_i2c_get_byte() returns, val may remain uninitialized, but it is accessed in: val &= ~amdgpu_connector->router.ddc_mux_control_pin; To fix this possible uninitialized-variable access, initialize val to 0 in amdgpu_i2c_router_select_ddc_port(). Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Signed-off-by: Tuo Li <islituo@gmail.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2021-01-13T08:02:58+00:00 Thomas Zimmermann tzimmermann@suse.de 2021-01-07T08:07:42+00:00 urn:sha1:8f66090b7bb7f2a2183f46e72e367922d836e0dd Using struct drm_device.pdev is deprecated. Convert amdgpu to struct drm_device.dev. No functional changes. v3: * rebased Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Christian König <christian.koenig@amd.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Christian König <christian.koenig@amd.com> Link: https://patchwork.freedesktop.org/patch/msgid/20210107080748.4768-3-tzimmermann@suse.de 2020-08-24T17:06:06+00:00 Luben Tuikov luben.tuikov@amd.com 2020-08-24T16:29:45+00:00 urn:sha1:4a580877bdcb837e7a3754ae20798dcfccb44e80 Add a static inline adev_to_drm() to obtain the DRM device pointer from an amdgpu_device pointer. Signed-off-by: Luben Tuikov <luben.tuikov@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2020-08-24T17:06:06+00:00 Luben Tuikov luben.tuikov@amd.com 2020-08-24T16:27:47+00:00 urn:sha1:1348969ab68cb864034ec4fe48a86c157cc4e10d Get the amdgpu_device from the DRM device by use of an inline function, drm_to_adev(). The inline function resolves a pointer to struct drm_device to a pointer to struct amdgpu_device. v2: Use a typed visible static inline function instead of an invisible macro. Signed-off-by: Luben Tuikov <luben.tuikov@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2019-06-10T21:02:48+00:00 Sam Ravnborg sam@ravnborg.org 2019-06-09T22:07:56+00:00 urn:sha1:fdf2f6c56e5e289c7d7e726b676aba25643b39a0 Drop use of drmP.h in all files named amdgpu* in drm/amd/amdgpu/ Fix fallout. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Cc: "Christian König" <christian.koenig@amd.com> Cc: "David (ChunMing) Zhou" <David1.Zhou@amd.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20190609220757.10862-10-sam@ravnborg.org 2017-01-27T16:12:39+00:00 Nils Wallménius nils.wallmenius@gmail.com 2016-12-14T20:52:45+00:00 urn:sha1:f7e9e9feb09f833d03f5fc3f378083b4664bd374 This is a left over from radeon, amdgpu doesn't support any non-atombios parts and amdgpu_device_init would bail if the check for atombios failed anyway. Reviewed-by: Edward O'Callaghan <funfunctor@folklore1984.net> Signed-off-by: Nils Wallménius <nils.wallmenius@gmail.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2016-10-06T16:39:03+00:00 Grazvydas Ignotas notasas@gmail.com 2016-10-02T21:06:46+00:00 urn:sha1:2f9ba199daf32dded4ef0237cd12efac451ebf47 If this happens (and it recently did), we free a structure while part of it is still in use, which results in non-obvious crashes. The way it's detached is not trivial (DRM core has to call the connector .destroy callback and things must be torn down in the right order), so better detect it and warn early. Signed-off-by: Grazvydas Ignotas <notasas@gmail.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 2016-09-27T17:00:52+00:00 Grazvydas Ignotas notasas@gmail.com 2016-09-25T20:34:50+00:00 urn:sha1:44f9d7b3f1096ec5c90b2396f600f385f4bf4a00 Signed-off-by: Grazvydas Ignotas <notasas@gmail.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>