kernel/linux.git/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c, branch v6.19.11Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.19.112026-03-04T12:19:57+00:00drm/amdgpu: add support for HDP IP version 6.1.12026-03-04T12:19:57+00:00Tim Huangtim.huang@amd.com2024-12-12T02:46:47+00:00urn:sha1:0226b7aec71c500a345d7b69c6e4591fe10bffca
[ Upstream commit e2fd14f579b841f54a9b7162fef15234d8c0627a ]
This initializes HDP IP version 6.1.1.
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Tim Huang <tim.huang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drm/amdgpu: Fix pointer casts when reading dynamic region sizes2025-10-28T13:55:16+00:00Srinivasan Shanmugamsrinivasan.shanmugam@amd.com2025-10-23T05:22:21+00:00urn:sha1:90ef1dcb1d2bb84ad998e845e26a2a297a7ddfd6
The function amdgpu_virt_get_dynamic_data_info() writes a 64-bit size
value. In two places (amdgpu_bios.c and amdgpu_discovery.c), the code
passed the address of a smaller variable by casting it to u64 *, which
is unsafe.
This could make the function write more bytes than the smaller variable
can hold, possibly overwriting nearby memory. Reported by static
analysis tools.
v2: Dynamic region size comes from the host (SR-IOV setup) and is always
fixed to 5 MB. (Lijo/Ellen)
5 MB easily fits inside a 32-bit value, so using a 64-bit type is not
needed. It also avoids extra type casts
Fixes: b4a8fcc7826a ("drm/amdgpu: Add logic for VF ipd and VF bios to init from dynamic crit_region offsets")
Reported by: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Ellen Pan <yunru.pan@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Add logic for VF ipd and VF bios to init from dynamic crit_region offsets2025-10-20T22:28:11+00:00Ellen Panyunru.pan@amd.com2025-10-07T16:12:39+00:00urn:sha1:b4a8fcc7826ad2bc95f05c8481d122ba23535a65
1. Added VF logic in amdgpu_virt to init IP discovery using the offsets from dynamic(v2) critical regions;
2. Added VF logic in amdgpu_virt to init bios image using the offsets from dynamic(v2) critical regions;
Signed-off-by: Ellen Pan <yunru.pan@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Add ras module ip block to amdgpu discovery2025-10-20T22:25:54+00:00YiPeng ChaiYiPeng.Chai@amd.com2025-03-31T03:12:58+00:00urn:sha1:7169e706c82d7bcb3ba4c8943faa32e26daf3523
Add ras module ip block to amdgpu discovery.
Signed-off-by: YiPeng Chai <YiPeng.Chai@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Reserve discovery TMR only if needed2025-10-13T18:14:36+00:00Lijo Lazarlijo.lazar@amd.com2025-10-10T11:53:33+00:00urn:sha1:071bba962456a46b261fcefe26bd533cbc059ea2
For legacy SOCs, discovery binary is sideloaded. Instead of checking for
binary blob, use a flag to determine if discovery region needs to be
reserved.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Add amdgpu_discovery_info2025-10-13T18:14:35+00:00Lijo Lazarlijo.lazar@amd.com2025-10-10T11:42:52+00:00urn:sha1:9e2096baab9addedde324f406d3ec9166e70d15b
Add amdgpu_discovery_info structure to keep all discovery related
information.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: fix handling of harvesting for ip_discovery firmware2025-10-13T18:14:15+00:00Alex Deucheralexander.deucher@amd.com2025-09-26T21:31:32+00:00urn:sha1:357d90be2c7aaa526a840cddffd2b8d676fe75a6
Chips which use the IP discovery firmware loaded by the driver
reported incorrect harvesting information in the ip discovery
table in sysfs because the driver only uses the ip discovery
firmware for populating sysfs and not for direct parsing for the
driver itself as such, the fields that are used to print the
harvesting info in sysfs report incorrect data for some IPs. Populate
the relevant fields for this case as well.
Fixes: 514678da56da ("drm/amdgpu/discovery: fix fw based ip discovery")
Acked-by: Tom St Denis <tom.stdenis@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: don't enable SMU on cyan skillfish2025-09-05T21:38:39+00:00Alex Deucheralexander.deucher@amd.com2025-06-27T14:25:09+00:00urn:sha1:94bd7bf2c920998b4c756bc8a54fd3dbdf7e4360
Cyan skillfish uses different SMU firmware.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: add support for cyan skillfish without IP discovery2025-09-05T21:38:38+00:00Alex Deucheralexander.deucher@amd.com2025-06-27T14:18:46+00:00urn:sha1:9e6a5cf1a23bf575e93544ae05585659063b1c18
For platforms without an IP discovery table.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu/discovery: fix fw based ip discovery2025-08-06T20:54:04+00:00Alex Deucheralexander.deucher@amd.com2025-07-30T15:16:05+00:00urn:sha1:514678da56da089b756b4d433efd964fa22b2079
We only need the fw based discovery table for sysfs. No
need to parse it. Additionally parsing some of the board
specific tables may result in incorrect data on some boards.
just load the binary and don't parse it on those boards.
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4441
Fixes: 80a0e8282933 ("drm/amdgpu/discovery: optionally use fw based ip discovery")
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 62eedd150fa11aefc2d377fc746633fdb1baeb55)
Cc: stable@vger.kernel.org