kernel/linux.git/drivers/gpu/drm/amd/amdgpu/amdgpu_cper.c, branch v7.2-rc1Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v7.2-rc12026-05-19T15:49:25+00:00drm/amd/ras: reset CPER ring on corrupt entry size2026-05-19T15:49:25+00:00Xiang Liuxiang.liu@amd.com2026-05-11T07:48:55+00:00urn:sha1:4d695e66d7027a0c78302e47ac76293675fbbb4d
When CPER ring overflow handling advances the read pointer, it trusts the
parsed entry size from the current ring contents. Corrupt CPER data can
produce an entry size that does not advance rptr after dword conversion
and pointer masking.
In that case the recovery loop keeps testing the same location while
holding the CPER ring mutex. This can hang the worker that is writing the
next CPER record.
Detect a no-progress rptr update and reset the CPER ring to an empty
state instead. This drops the corrupt contents and lets the writer leave
the recovery path without spinning.
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Stanley.Yang <Stanley.Yang@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Rename CPER Fatal severity macro2026-04-17T19:41:13+00:00Xiang Liuxiang.liu@amd.com2025-12-02T07:43:36+00:00urn:sha1:533d9e348e3b81b3ae877920b8aec8f58acd0f04
Rename CPER severity macro to avoid conflicting with UEFI definition.
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: fix CPER ring header parsing2026-04-17T18:49:47+00:00Xiang Liuxiang.liu@amd.com2026-04-09T09:10:21+00:00urn:sha1:b8939bd764c9c8bf6488dc0d71d9c718c25d8cfc
amdgpu_cper_ring_get_ent_sz() parses CPER headers directly from the
circular ring buffer to determine the current entry size. When the ring
is full and the write pointer lands near the end of the buffer, the
header can wrap across the ring boundary.
The existing code treats the 4-byte CPER signature as a C string and
uses strcmp() on in-ring binary data, then reads record_length through a
direct struct pointer cast. Both assumptions are unsafe for wrapped
entries and can read past the end of the ring mapping.
Fix the parser by comparing the signature as raw bytes and by copying
the header into a local buffer before reading record_length, handling
wraparound explicitly in both cases. This avoids out-of-bounds reads in
amdgpu_cper_ring_get_ent_sz() when the CPER ring is full or the current
entry starts at the tail of the ring.
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/ras: Support sriov uniras to obtain cper data2025-12-08T18:56:33+00:00YiPeng ChaiYiPeng.Chai@amd.com2025-11-05T07:12:11+00:00urn:sha1:c174a6317be0aac7e1953eefd680af6b9be91bc2
Support sriov uniras to obtain cper data.
Signed-off-by: YiPeng Chai <YiPeng.Chai@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: fix SPDX headers on amdgpu_cper.c/h2025-10-28T13:51:50+00:00Alex Deucheralexander.deucher@amd.com2025-10-22T13:12:54+00:00urn:sha1:abd3f876404cafb107cb34bacb74706bfee11cbe
These should be MIT. The driver in general is MIT and
the license text at the top of the files is MIT so fix
it.
Fixes: 92d5d2a09de1 ("drm/amdgpu: Introduce funcs for populating CPER")
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4654
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Correct info field of bad page threshold exceed CPER2025-09-05T20:06:49+00:00Xiang Liuxiang.liu@amd.com2025-09-02T14:13:44+00:00urn:sha1:f320ed01cf5f2259e2035a56900952cb3cc77e7a
Correct valid_bits and ms_chk_bits of section info field for bad page
threshold exceed CPER to match OOB's behavior.
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu/amdgpu_cper: Remove redundant ternary operators2025-09-05T20:00:04+00:00Liao Yuanhongliaoyuanhong@vivo.com2025-09-03T12:03:45+00:00urn:sha1:7670daf65afae2d6d08b300df64c96439e813b3a
For ternary operators in the form of "a ? false : true", if 'a' itself
returns a boolean result, the ternary operator can be omitted. Remove
redundant ternary operators to clean up the code.
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Update IPID value for bad page threshold CPER2025-08-04T18:27:41+00:00Xiang Liuxiang.liu@amd.com2025-07-23T06:28:35+00:00urn:sha1:8f0245ee95c5ba65a2fe03f60386868353c6a3a0
Update the IPID register value for bad page threshold CPER according to
the latest definition.
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/amdgpu: fix missing lock for cper.ring->rptr/wptr access2025-07-28T20:26:52+00:00Yang Wangkevinyang.wang@amd.com2025-07-24T07:16:18+00:00urn:sha1:8e0d1edb5c16732b695eaf4bd7096b1569817cf0
Add lock protection for 'ring->wptr'/'ring->rptr' to ensure the correct execution.
Fixes: 8652920d2c00 ("drm/amdgpu: add mutex lock for cper ring")
Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drm/amdgpu: Use correct severity for BP threshold exceed event2025-06-30T16:08:00+00:00Xiang Liuxiang.liu@amd.com2025-06-27T15:14:08+00:00urn:sha1:4a33ca3f6ee9a013a423a867426704e9c9d785bd
The severity of CPER for BP threshold exceed event should be set as
CPER_SEV_FATAL to match the OOB implementation.
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>