kernel/linux.git/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c, branch v6.6.132

drm/amdgpu: Prefer pr_err/_warn/_notice over printk in amdgpu_atpx_handler.c

2023-08-07T21:13:10+00:00

Fixes the following style issues: ERROR: open brace '{' following function definitions go on the next line WARNING: printk() should include KERN_ facility level Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Cc: Bert Karwatzki Cc: "Pan, Xinhui" Cc: Luben Tuikov Signed-off-by: Srinivasan Shanmugam Reviewed-by: Luben Tuikov Signed-off-by: Alex Deucher

Revert "drm/amdgpu: Prefer dev_* variant over printk in amdgpu_atpx_handler.c"

2023-08-07T21:13:09+00:00

Usage of container_of is wrong here. struct acpi_device *adev = container_of(handle, struct acpi_device, handle) This reverts commit b0bd0a92b8158ea9c809d885e0f0c21518bdbd14. References: https://gitlab.freedesktop.org/drm/amd/-/issues/2744 Cc: Guchun Chen Cc: Christian König Cc: Alex Deucher Cc: Bert Karwatzki Signed-off-by: Srinivasan Shanmugam Reviewed-by: Guchun Chen Signed-off-by: Alex Deucher

drm/amdgpu: Prefer dev_* variant over printk in amdgpu_atpx_handler.c

2023-07-27T18:59:29+00:00

Changed from printk to dev_* variants so that we get better debug info when there are multiple GPUs in the system. Fixes other style issue: ERROR: open brace '{' following function definitions go on the next line WARNING: printk() should include KERN_ facility level Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher

drm/amd: append missing includes

2021-12-13T21:32:34+00:00

This fixes warnings caused by global functions lacking prototypes:, such as: warning: no previous prototype for 'dcn303_hw_sequencer_construct' [-Wmissing-prototypes] 12 | void dcn303_hw_sequencer_construct(struct dc *dc) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ... warning: no previous prototype for ‘amdgpu_has_atpx’ [-Wmissing-prototypes] 76 | bool amdgpu_has_atpx(void) { | ^~~~~~~~~~~~~~~ Reviewed-by: Rodrigo Siqueira Signed-off-by: Isabella Basso Signed-off-by: Alex Deucher

drm/amd: fix improper docstring syntax

2021-12-13T21:32:34+00:00

This fixes various warnings relating to erroneous docstring syntax, of which some are listed below: warning: Function parameter or member 'adev' not described in 'amdgpu_atomfirmware_ras_rom_addr' ... warning: expecting prototype for amdgpu_atpx_validate_functions(). Prototype was for amdgpu_atpx_validate() instead ... warning: Excess function parameter 'mem' description in 'amdgpu_preempt_mgr_new' ... warning: Cannot understand * @kfd_get_cu_occupancy - Collect number of waves in-flight on this device ... warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Signed-off-by: Isabella Basso Signed-off-by: Alex Deucher

drm/amd/amdgpu: fix comparison pointer to bool warning in amdgpu_atpx_handler.c

2020-09-15T21:52:43+00:00

Fixes coccicheck warning: drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c:619:15-49: WARNING: Comparison to bool drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c:629:15-49: WARNING: Comparison to bool Acked-by: Christian König Signed-off-by: Zheng Bin Signed-off-by: Alex Deucher

Revert "drm/amdgpu: simplify ATPX detection"

2019-12-29T06:53:27+00:00

This reverts commit f5fda6d89afe6e9cedaa1c3303903c905262f6e8. You can't use BASE_CLASS in pci_get_class. Bug: https://gitlab.freedesktop.org/drm/amd/issues/995 Acked-by: Evan Quan Signed-off-by: Alex Deucher

drm/amdgpu: simplify ATPX detection

2019-10-15T19:51:39+00:00

Use the base class rather than the specific class and drop the second loop. Reviewed-by: Evan Quan Signed-off-by: Alex Deucher

drm/amdgpu: Add APTX quirk for Dell Latitude 5495

2019-08-27T15:09:12+00:00

Needs ATPX rather than _PR3 to really turn off the dGPU. This can save ~5W when dGPU is runtime-suspended. Signed-off-by: Kai-Heng Feng Signed-off-by: Alex Deucher

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 191

2019-05-30T18:29:21+00:00

Based on 1 normalized pattern(s): licensed under gplv2 extracted by the scancode license scanner the SPDX license identifier GPL-2.0-only has been chosen to replace the boilerplate/reference in 99 file(s). Signed-off-by: Thomas Gleixner Reviewed-by: Alexios Zavras Reviewed-by: Richard Fontana Reviewed-by: Allison Randal Reviewed-by: Steve Winslow Cc: linux-spdx@vger.kernel.org Link: https://lkml.kernel.org/r/20190528170027.163048684@linutronix.de Signed-off-by: Greg Kroah-Hartman