kernel/linux.git/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c, branch v6.19.11Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.19.112026-03-12T11:09:21+00:00drm/amdgpu: Unlock a mutex before destroying it2026-03-12T11:09:21+00:00Bart Van Asschebvanassche@acm.org2026-02-23T22:00:07+00:00urn:sha1:6f6f1ff80a36a1b2243a6dab4685a212f8cb6737
[ Upstream commit 5e0bcc7b88bcd081aaae6f481b10d9ab294fcb69 ]
Mutexes must be unlocked before these are destroyed. This has been detected
by the Clang thread-safety analyzer.
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Yang Wang <kevinyang.wang@amd.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Fixes: f5e4cc8461c4 ("drm/amdgpu: implement RAS ACA driver framework")
Reviewed-by: Yang Wang <kevinyang.wang@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 270258ba320beb99648dceffb67e86ac76786e55)
Signed-off-by: Sasha Levin <sashal@kernel.org>
drm/amdgpu: Correct the counts of nr_banks and nr_errors2025-08-27T17:57:47+00:00Ce Suncesun102@amd.com2025-08-07T04:36:05+00:00urn:sha1:907813e5d7cadfeafab12467d748705a5309efb0
Correct the counts of nr_banks and nr_errors
Signed-off-by: Ce Sun <cesun102@amd.com>
Reviewed-by: Yang Wang <kevinyang.wang@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Skip poison aca bank from UE channel2025-08-04T18:37:20+00:00Xiang Liuxiang.liu@amd.com2025-07-30T03:07:43+00:00urn:sha1:8e8e08c831f088ed581444c58a635c49ea1222ab
Avoid GFX poison consumption errors logged when fatal error occurs.
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Add debug mask to disable CE logs2025-06-18T16:19:18+00:00Xiang Liuxiang.liu@amd.com2025-06-06T03:10:40+00:00urn:sha1:f43411978d1367af6e983ae09ab4c2f7a811574a
Add debug mask to disable kernel logs of RAS correctable errors,
including both ACA and CE error counter kernel messages.
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Print kernel message when error logged by scrub2025-04-22T12:51:45+00:00Xiang Liuxiang.liu@amd.com2025-04-18T07:13:44+00:00urn:sha1:696e8fa3547394d50e387923ba220fbdb6347b6d
Print a kernel message when the scrub bit of status register is set to
indicate that errors are being logged by the scrub.
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Parse all deferred errors with UMC aca handle2025-03-26T21:44:41+00:00Xiang Liuxiang.liu@amd.com2025-03-24T09:19:54+00:00urn:sha1:aedc92be9621b31ccc90d79ee7f831944e6bfbef
We should only increase the deferred errors in UMC block.
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Decode deferred error type in gfx aca bank parser2025-03-21T16:16:35+00:00Xiang Liuxiang.liu@amd.com2025-03-19T09:02:49+00:00urn:sha1:338f7412c7ea2ce007e83c5ad7c5e01d8cfce1e1
In the case of injecting uncorrected error with background workload,
the deferred error among uncorrected errors need to be specified
by checking the deferred and poison bits of status register.
v2: refine checking for deferred error
v2: log possiable DEs among CEs
v2: generate CPER records for DEs among UEs
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Check if CPER enabled when generating CPER2025-02-25T16:45:12+00:00Xiang Liuxiang.liu@amd.com2025-02-24T13:10:24+00:00urn:sha1:ce615fe328450b761eeb71c046072aeca3099f3d
In the case of CPER disabled, generating CPER will cause kernel NULL
pointer dereference without checking.
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Remove redundant check of adev2025-02-19T20:16:37+00:00Xiang Liuxiang.liu@amd.com2025-02-19T04:27:27+00:00urn:sha1:2f94469cc0db4fb7e0b39208058be1d793319689
There is no need to check adev for sure.
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
Reviewed-by: Yang Wang <kevinyang.wang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: Generate cper records2025-02-17T19:09:29+00:00Hawking ZhangHawking.Zhang@amd.com2025-02-11T11:54:05+00:00urn:sha1:652e09023029b79b4490e824d4ebe8eaea92cc8e
Encode the error information in CPER format and commit
to the cper ring
Signed-off-by: Hawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: Yang Wang <keivnyang.wang@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>