kernel/linux.git/drivers/gnss/sirf.c, branch linux-7.1.y

treewide, serdev: change receive_buf() return type to size_t

2024-01-28T02:13:53+00:00

receive_buf() is called from ttyport_receive_buf() that expects values ">= 0" from serdev_controller_receive_buf(), change its return type from ssize_t to size_t. The need for this clean-up was noticed while fixing a warning, see commit 94d053942544 ("Bluetooth: btnxpuart: fix recv_buf() return value"). Changing the callback prototype to return an unsigned seems the best way to document the API and ensure that is properly used. GNSS drivers implementation of serdev receive_buf() callback return directly the return value of gnss_insert_raw(). gnss_insert_raw() returns a signed int, however this is not an issue since the value returned is always positive, because of the kfifo_in() implementation. gnss_insert_raw() could be changed to return also an unsigned, however this is not implemented here as request by the GNSS maintainer Johan Hovold. Suggested-by: Jiri Slaby Link: https://lore.kernel.org/all/087be419-ec6b-47ad-851a-5e1e3ea5cfcc@kernel.org/ Signed-off-by: Francesco Dolcini Acked-by: Jonathan Cameron #for-iio Reviewed-by: Johan Hovold Reviewed-by: Rob Herring Reviewed-by: Alex Elder Acked-by: Maximilian Luz # for platform/surface Acked-by: Lee Jones Acked-by: Ilpo Järvinen Link: https://lore.kernel.org/r/20240122180551.34429-1-francesco@dolcini.it Signed-off-by: Greg Kroah-Hartman

tty: serdev: convert to u8 and size_t

2023-12-08T11:02:38+00:00

Switch character types to u8 and sizes to size_t. To conform to characters/sizes in the rest of the tty layer. This patch converts struct serdev_device_ops hooks and its instantiations. Signed-off-by: "Jiri Slaby (SUSE)" Cc: Rob Herring Acked-by: Johan Hovold Link: https://lore.kernel.org/r/20231206073712.17776-24-jirislaby@kernel.org Signed-off-by: Greg Kroah-Hartman

gnss: drop stray semicolons

2021-11-15T07:22:26+00:00

Drop semicolons after function definitions that have managed to sneak in and get reproduced. Signed-off-by: Johan Hovold

gnss: sirf: fix error return code in sirf_probe()

2020-05-13T14:42:07+00:00

Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. This avoids a use-after-free in case the driver is later unbound. Fixes: d2efbbd18b1e ("gnss: add driver for sirfstar-based receivers") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun [ johan: amend commit message; mention potential use-after-free ] Cc: stable # 4.19 Signed-off-by: Johan Hovold

gnss: sirf: add a separate supply for a lna

2019-01-25T11:07:42+00:00

Devices might have a separate lna between antenna input of the gps chip and the antenna which might have a separate supply. Signed-off-by: Andreas Kemnade Signed-off-by: Johan Hovold

gnss: sirf: add support for configurations without wakeup signal

2019-01-25T11:07:42+00:00

Some Wi2Wi devices do not have a wakeup output, so device state can only be indirectly detected by looking whether there is communication over the serial lines. This approach requires a report cycle set to a value less than 2 seconds to be reliable. Signed-off-by: Andreas Kemnade [ johan: simplify sirf_set_active(), style changes ] Signed-off-by: Johan Hovold

gnss: sirf: write data to gnss only when the gnss device is open

2019-01-25T10:35:06+00:00

The api forbids writing data there otherwise. Prepare for the serdev_open()/close() being a part of sirf_set_active. Signed-off-by: Andreas Kemnade Signed-off-by: Johan Hovold

gnss: sirf: drop redundant double negation

2019-01-25T09:58:56+00:00

The active flag is of type bool so drop the redundant double negation when storing the gpio state. Signed-off-by: Johan Hovold

gnss: sirf: force hibernate mode on probe

2019-01-25T09:58:54+00:00

Make sure to put the receiver in hibernate mode in case it is already active during probe in order to avoid wasting power until first open or suspend. This can happen, for example, after a reset or non-clean shutdown, and possibly also due to glitches during power-on. Reported-by: Andreas Kemnade Signed-off-by: Johan Hovold

gnss: sirf: fix premature wakeup interrupt enable

2019-01-25T09:58:52+00:00

Make sure the receiver is powered (and booted) before enabling the wakeup interrupt to avoid spurious interrupts due to a floating input. Similarly, disable the interrupt before powering off on probe errors and on unbind. Fixes: d2efbbd18b1e ("gnss: add driver for sirfstar-based receivers") Cc: stable # 4.19 Signed-off-by: Johan Hovold