Linux kernel stable tree (mirror) https://git.radix-linux.su/kernel/linux.git/atom?h=v6.1.168 2024-10-17T13:21:51+00:00 2024-10-17T13:21:51+00:00 Krzysztof Kozlowski krzysztof.kozlowski@linaro.org 2024-08-16T13:57:21+00:00 urn:sha1:a763af9f5d622717d37b801fd09f93d73c1c5279 commit 9c3a62c20f7fb00294a4237e287254456ba8a48b upstream. mbox_client_to_bpmp() is not used, W=1 builds: drivers/firmware/tegra/bpmp.c:28:1: error: unused function 'mbox_client_to_bpmp' [-Werror,-Wunused-function] Fixes: cdfa358b248e ("firmware: tegra: Refactor BPMP driver") Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2024-04-13T11:04:56+00:00 Markus Elfring elfring@users.sourceforge.net 2023-12-25T19:03:56+00:00 urn:sha1:161d6b803778c5a825d50bed14cfafe9b29e52ad [ Upstream commit 1315848f1f8a0100cb6f8a7187bc320c5d98947f ] The kfree() function was called in one case by the get_filename() function during error handling even if the passed variable contained a null pointer. This issue was detected by using the Coccinelle software. Thus return directly after a call of the function “kzalloc” failed at the beginning. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Sasha Levin <sashal@kernel.org> 2022-09-15T10:45:42+00:00 Qing Wang wangqing@vivo.com 2021-10-18T11:31:52+00:00 urn:sha1:fa586abcfe4b43e170d72586b6f11bcc48f6766c This patch fixes the following Coccinelle warning: drivers/firmware/tegra/bpmp-debugfs.c:379: WARNING opportunity for memdup_user Use memdup_user() rather than duplicating its implementation. This is a little bit restricted to reduce false positives. Signed-off-by: Qing Wang <wangqing@vivo.com> Signed-off-by: Thierry Reding <treding@nvidia.com> 2022-07-08T15:56:03+00:00 Lv Ruyi lv.ruyi@zte.com.cn 2022-04-19T01:36:48+00:00 urn:sha1:afcdb8e55c91c6ff0700ab272fd0f74e899ab884 If an error occurs, debugfs_create_file() will return ERR_PTR(-ERROR), so use IS_ERR() to check it. Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> Signed-off-by: Thierry Reding <treding@nvidia.com> 2022-06-24T15:57:29+00:00 Timo Alho talho@nvidia.com 2022-06-22T13:22:59+00:00 urn:sha1:a4740b148a04dc60e14fe6a1dfe216d3bae214fd Use memcpy_toio and memcpy_fromio variants of memcpy to guarantee no unaligned access to IPC memory area. This is to allow the IPC memory to be mapped as Device memory to further suppress speculative reads from happening within the 64 kB memory area above the IPC memory when 64 kB memory pages are used. Signed-off-by: Timo Alho <talho@nvidia.com> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> Signed-off-by: Thierry Reding <treding@nvidia.com> 2021-10-18T14:04:01+00:00 Lv Ruyi lv.ruyi@zte.com.cn 2021-10-09T08:59:00+00:00 urn:sha1:711e26c00e4c7b7cef0420c76a61e6d818e12687 Application of sizeof() to pointer yields the number of bytes of the pointer, but it should use the length of buffer in the code. Fixes: 06c2d9a078ab ("firmware: tegra: Reduce stack usage") Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Tested-by: Jon Hunter <jonathanh@nvidia.com> Signed-off-by: Thierry Reding <treding@nvidia.com> 2021-10-07T18:52:24+00:00 Cai Huoqing caihuoqing@baidu.com 2021-09-08T10:56:23+00:00 urn:sha1:f11c34bddf8cd2a3107a7d11b6446c66deda9590 Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately. Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> Signed-off-by: Thierry Reding <treding@nvidia.com> 2021-10-07T18:52:17+00:00 Arnd Bergmann arnd@arndb.de 2021-09-27T12:41:40+00:00 urn:sha1:06c2d9a078abe784fd9fd0f1534e318e827712b4 Building the bpmp-debugfs driver for Arm results in a warning for stack usage: drivers/firmware/tegra/bpmp-debugfs.c:321:16: error: stack frame size of 1224 bytes in function 'bpmp_debug_store' [-Werror,-Wframe-larger-than=] static ssize_t bpmp_debug_store(struct file *file, const char __user *buf, It should be possible to rearrange the code to not require two separate buffers for the file name, but the easiest workaround is to use dynamic allocation. Fixes: 5e37b9c137ee ("firmware: tegra: Add support for in-band debug") Link: https://lore.kernel.org/all/20201204193714.3134651-1-arnd@kernel.org/ Signed-off-by: Arnd Bergmann <arnd@arndb.de> [treding@nvidia.com: consistently return NULL on failure] Signed-off-by: Thierry Reding <treding@nvidia.com> 2021-08-11T10:17:18+00:00 Christoph Hellwig hch@lst.de 2021-08-10T15:54:39+00:00 urn:sha1:dd00d75007d27677158bf6e64000d2e266035294 Opencode a copy of mrq_debug_read() in bpmp_debug_show() so that it can use seq_write() directly instead of poking holes into the seq_file abstractions using seq_get_buf(). Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Thierry Reding <treding@nvidia.com> 2021-06-11T11:31:51+00:00 Thierry Reding treding@nvidia.com 2021-04-13T12:23:35+00:00 urn:sha1:bd778b893963d67d7eb01f49d84ffcd3eaf229dd The tegra186_bpmp_ops symbol is used on Tegra234, so make sure it's available. Signed-off-by: Thierry Reding <treding@nvidia.com>