kernel/linux.git/drivers/firmware/arm_scpi.c, branch linux-4.16.yLinux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=linux-4.16.y2017-12-04T03:39:22+00:00firmware: arm_scpi: Revert updates made during v4.15 merge window2017-12-04T03:39:22+00:00Olof Johanssonolof@lixom.net2017-12-04T03:28:33+00:00urn:sha1:81faa5566864e97a5578c4e08c07edf04239abcc
Revert "Merge tag 'scpi-updates-4.15' of git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux into next/drivers"
Paraphrased from email from Kevin Hilman:
Revert ARM SCPI changes since v4.14.
Untested changes caused regressions in SCPI and CPUfreq/DVFS failures
on most Amlogic SoCs. Changes reverted for v4.15 so they can be better
reviewed and tested.
These ARM SCPI changes caused SCPI regressions resulting in CPUfreq
failures on most Amlogic SoCs (found by kernelci.org.)
Unfortunately, this was not caught in linux-next due to other bugs/panics
on these platforms masking this problem so we've only found it since
we've fixed the other issues.
Since we're already in the -rc cycle, I'd prefer to revert to a known
working state (that of v4.14) rather than finding/reverting a subset,
which would just lead to another untested state.
These changes can then have some time to be better reviewed and tested
and resubmitted for v4.16.
Kevin Hilman has tested this revert on the affected Amlogic SoCs and
verified that we're back to the previous (working) condition.
This reverts commit 6710acf2596a29f7351e8165d981645f403e0025, reversing
changes made to 4b367f2e8854da34d14bd154ff4432fb49f69b36.
Reported-by: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
firmware: arm_scpi: silence sparse warnings2017-10-09T09:20:02+00:00Heiner Kallweithkallweit1@gmail.com2017-10-06T18:59:05+00:00urn:sha1:430594c1c7f5051f0d99ed9d08d086d20587cdd1
At several positions in the code sparse complains about incorrect access
to __iomem annotated memory. Fix this and make sparse happy.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
firmware: arm_scpi: remove all single element structures2017-10-09T09:17:41+00:00Sudeep Hollasudeep.holla@arm.com2017-10-05T10:40:49+00:00urn:sha1:48bee74a354b211c4e4cb62e6a7b7986749747cf
Both clk_get_value and sensor_value structures contains a single element
and hence needs no packing making the whole structure defination
unnecessary.
This patch gets rid of both those unnecessary structures.
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
firmware: arm_scpi: drop unnecessary type cast to scpi_shared_mem2017-10-09T09:17:16+00:00Sudeep Hollasudeep.holla@arm.com2017-10-05T10:31:36+00:00urn:sha1:1b36633ea9c80f91fab505002dd7548febc51812
This patch drops the only present type cast of the SCPI payload pointer
to scpi_shared_mem inorder to align with other occurrences, IOW for
consistency.
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
firmware: arm_scpi: improve struct sensor_value2017-10-05T10:48:46+00:00Heiner Kallweithkallweit1@gmail.com2017-10-04T19:05:17+00:00urn:sha1:5c7ae6467df557f25daf42e78202531bc44c83df
lo_val and hi_val together in this order are a little endian 64 bit value.
Therefore we can simplify struct sensor_value and the code by defining
it as a __le64 value and by using le64_to_cpu.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
firmware: arm_scpi: improve handling of protocol and firmware version subfields2017-10-05T10:48:41+00:00Heiner Kallweithkallweit1@gmail.com2017-10-04T19:00:39+00:00urn:sha1:4864dca72d3fb2586ffee0c92bd13d02cedfee2f
By using FIELD_GET and proper masks we can avoid quite some shifting
and masking macro magic and make the code better readable.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
firmware: arm_scpi: improve struct dvfs_info to make code better readable2017-10-05T10:48:27+00:00Heiner Kallweithkallweit1@gmail.com2017-10-04T18:56:44+00:00urn:sha1:d9e324ea138b43c2cfb6b01e3ae02a84be55aef4
Making the header subfields members of struct dvfs_info allows to make
the code better readable and avoids some macro magic.
In addition remove a useless statement using info->latency.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
firmware: arm_scpi: remove scpi_remove2017-10-04T10:09:47+00:00Heiner Kallweithkallweit1@gmail.com2017-09-29T21:44:15+00:00urn:sha1:95998c7a6cf76a24a553bec7f6fafdef6b4d3374
sysfs_create_groups and of_platform_populate can be replaced with the
device-managed versions what allows us to remove scpi_remove.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
firmware: arm_scpi: make freeing mbox channels device-managed2017-10-04T10:09:47+00:00Heiner Kallweithkallweit1@gmail.com2017-09-29T21:44:09+00:00urn:sha1:27c54cd3142184b7798e082d06c17135cafb3f60
Make freeing the mbox channels device-managed, thus further simplifying
scpi_remove and and one further step to get rid of scpi_remove.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
firmware: arm_scpi: pre-populate dvfs info in scpi_probe2017-10-04T10:09:46+00:00Heiner Kallweithkallweit1@gmail.com2017-09-29T21:44:05+00:00urn:sha1:931cf0c53e6999375eac65f3650a656b88634b9d
Pre-populating the dvfs info data in scpi_probe allows to make all
memory allocations device-managed. This helps to simplify scpi_remove
and eventually to get rid of scpi_remove completely.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
[sudeep.holla: changed to continue probe even if scpi_dvfs_populate_info fails]
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>