kernel/linux.git/drivers/extcon/extcon.c, branch v6.6.132

extcon: fix possible name leak in extcon_dev_register()

2024-02-05T20:14:31+00:00

[ Upstream commit e66523c72c9aae0ff0dae6859eb77b04de1e8e5f ] In the error path after calling dev_set_name(), the device name is leaked. To fix this, moving dev_set_name() after the error path and before device_register. Link: https://lore.kernel.org/lkml/TYZPR01MB4784ADCD3E951E0863F3DB72D5B8A@TYZPR01MB4784.apcprd01.prod.exchangelabs.com/ Signed-off-by: Yaxiong Tian Signed-off-by: Chanwoo Choi Signed-off-by: Sasha Levin

extcon: Drop unneeded assignments

2023-05-29T14:41:29+00:00

In one case the assignment is duplicative, in the other, it's better to move it into the loop — the user of it. Signed-off-by: Andy Shevchenko Acked-by: Chanwoo Choi Signed-off-by: Chanwoo Choi

extcon: Use sizeof(*pointer) instead of sizeof(type)

2023-05-29T14:41:29+00:00

It is preferred to use sizeof(*pointer) instead of sizeof(type). The type of the variable can change and one needs not change the former (unlike the latter). No functional change intended. Signed-off-by: Andy Shevchenko Signed-off-by: Chanwoo Choi

extcon: Use unique number for the extcon device ID

2023-05-29T14:41:29+00:00

The use of atomic variable is still racy when we do not control which device has been unregistered and there is a (theoretical) possibility of the overflow that may cause a duplicate extcon device ID number to be allocated next time a device is registered. Replace above mentioned approach by using IDA framework. Signed-off-by: Andy Shevchenko Signed-off-by: Chanwoo Choi

extcon: Remove dup device name in the message and unneeded error check

2023-05-29T14:41:29+00:00

The device name is already printed with dev_err(), no need to repeat. The device pointer itself is not supposed to be an error point, drop that check. Signed-off-by: Andy Shevchenko Signed-off-by: Chanwoo Choi

extcon: Use dev_of_node(dev) instead of dev->of_node

2023-05-29T14:41:29+00:00

The dev_of_node function should be preferred. In the result we may drop unneeded NULL check of the pointer to the device object. Signed-off-by: Andy Shevchenko Signed-off-by: Chanwoo Choi

extcon: Use device_match_of_node() helper

2023-05-29T14:41:29+00:00

Instead of open coding, use device_match_of_node() helper. Signed-off-by: Andy Shevchenko Signed-off-by: Chanwoo Choi

extcon: Use sysfs_emit() to instead of sprintf()

2023-05-29T14:41:28+00:00

Follow the advice of the Documentation/filesystems/sysfs.rst that show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Andy Shevchenko Signed-off-by: Chanwoo Choi

extcon: Use DECLARE_BITMAP() to declare bit arrays

2023-05-29T14:41:28+00:00

Bit arrays has a specific type helper for the declaration. Use it instead of homegronw equivalent. Signed-off-by: Andy Shevchenko Signed-off-by: Chanwoo Choi

extcon: Fix kernel doc of property capability fields to avoid warnings

2023-05-29T14:41:28+00:00

Kernel documentation has to be synchronized with a code, otherwise the validator is not happy: Function parameter or member 'usb_bits' not described in 'extcon_cable' Function parameter or member 'chg_bits' not described in 'extcon_cable' Function parameter or member 'jack_bits' not described in 'extcon_cable' Function parameter or member 'disp_bits' not described in 'extcon_cable' Describe the fields added in the past. Fixes: ceaa98f442cf ("extcon: Add the support for the capability of each property") Signed-off-by: Andy Shevchenko Signed-off-by: Chanwoo Choi