kernel/linux.git/drivers/devfreq/tegra-devfreq.c, branch v4.14.263

PM / devfreq: tegra30: Fix integer overflow on CPU's freq max out

2020-10-01T11:12:28+00:00

[ Upstream commit 53b4b2aeee26f42cde5ff2a16dd0d8590c51a55a ] There is another kHz-conversion bug in the code, resulting in integer overflow. Although, this time the resulting value is 4294966296 and it's close to ULONG_MAX, which is okay in this case. Reviewed-by: Chanwoo Choi Tested-by: Peter Geis Signed-off-by: Dmitry Osipenko Signed-off-by: Chanwoo Choi Signed-off-by: Sasha Levin

PM / devfreq: tegra: Fix kHz to Hz conversion

2019-10-11T16:18:30+00:00

commit 62bacb06b9f08965c4ef10e17875450490c948c0 upstream. The kHz to Hz is incorrectly converted in a few places in the code, this results in a wrong frequency being calculated because devfreq core uses OPP frequencies that are given in Hz to clamp the rate, while tegra-devfreq gives to the core value in kHz and then it also expects to receive value in kHz from the core. In a result memory freq is always set to a value which is close to ULONG_MAX because of the bug. Hence the EMC frequency is always capped to the maximum and the driver doesn't do anything useful. This patch was tested on Tegra30 and Tegra124 SoC's, EMC frequency scaling works properly now. Cc: # 4.14+ Tested-by: Steev Klimaszewski Reviewed-by: Chanwoo Choi Signed-off-by: Dmitry Osipenko Acked-by: Thierry Reding Signed-off-by: MyungJoo Ham Signed-off-by: Greg Kroah-Hartman

PM / devfreq: tegra: fix error return code in tegra_devfreq_probe()

2017-07-06T01:16:17+00:00

platform_get_irq() returns an error code, but the tegra-devfreq driver ignores it and always returns -ENODEV. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af Print and propagate the return value of platform_get_irq on failure. Reviewed-by: Chanwoo Choi Signed-off-by: Gustavo A. R. Silva Signed-off-by: MyungJoo Ham

PM / OPP: Update OPP users to put reference

2017-01-30T08:22:21+00:00

This patch updates dev_pm_opp_find_freq_*() routines to get a reference to the OPPs returned by them. Also updates the users of dev_pm_opp_find_freq_*() routines to call dev_pm_opp_put() after they are done using the OPPs. As it is guaranteed the that OPPs wouldn't get freed while being used, the RCU read side locking present with the users isn't required anymore. Drop it as well. This patch also updates all users of devfreq_recommended_opp() which was returning an OPP received from the OPP core. Note that some of the OPP core routines have gained rcu_read_{lock|unlock}() calls, as those still use RCU specific APIs within them. Signed-off-by: Viresh Kumar Reviewed-by: Chanwoo Choi [Devfreq] Signed-off-by: Rafael J. Wysocki

PM / devfreq: tegra: Set freq in rate callback

2016-02-23T05:27:42+00:00

As per the documentation of the devfreq_dev_profile.target callback, set the freq argument to the new frequency before returning. This caused endless messages like this after recent changes in the core: devfreq 6000c800.actmon: Couldn't update frequency transition information. Signed-off-by: Tomeu Vizoso Reported-by: Tyler Baker Tested-by: Thierry Reding Acked-by: Thierry Reding Signed-off-by: MyungJoo Ham

PM / devfreq: tegra: Update governor to use devfreq_update_stats()

2015-09-11T05:23:30+00:00

Direct invocation of get_dev_status() is no more recommended. Signed-off-by: MyungJoo Ham

PM / devfreq: tegra: Register governor on module init

2015-03-31T04:17:15+00:00

So this driver builds as a module. Signed-off-by: Tomeu Vizoso Signed-off-by: MyungJoo Ham

PM / devfreq: tegra: Enable interrupts after resuming the devfreq monitor

2015-03-31T04:17:15+00:00

Signed-off-by: Tomeu Vizoso Acked-by: MyungJoo Ham

PM / devfreq: tegra: Set drvdata before enabling the irq

2015-03-31T04:17:14+00:00

To avoid a race in which the interrupt will be handled before the drvdata has been set up. Signed-off-by: Tomeu Vizoso Acked-by: MyungJoo Ham

PM / devfreq: tegra: remove operating-points

2015-03-31T04:17:14+00:00

As the DT bindings don't have an operating-points property any more, build the OPP table from the frequencies supported by the EMC clock. Signed-off-by: Tomeu Vizoso Acked-by: MyungJoo Ham