kernel/linux.git/drivers/dca/dca-core.c, branch v6.6.132

dca: delete unnecessary variable

2023-04-08T20:45:36+00:00

It's more readable to just pass NULL directly instead of using a variable for that. Link: https://lkml.kernel.org/r/Y/yAlDytLH0ZNLNz@kili Signed-off-by: Dan Carpenter Cc: Greg Kroah-Hartman Signed-off-by: Andrew Morton

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 33

2019-05-24T15:27:11+00:00

Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details you should have received a copy of the gnu general public license along with this program if not write to the free software foundation inc 59 temple place suite 330 boston ma 02111 1307 usa the full gnu general public license is included in this distribution in the file called copying extracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-later has been chosen to replace the boilerplate/reference in 7 file(s). Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Reviewed-by: Richard Fontana Reviewed-by: Kate Stewart Reviewed-by: Michael Ellerman (powerpc) Cc: linux-spdx@vger.kernel.org Link: https://lkml.kernel.org/r/20190520170857.277062491@linutronix.de Signed-off-by: Greg Kroah-Hartman

dca: make function dca_common_get_tag static

2018-04-24T01:02:41+00:00

Function dca_common_get_tag is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: drivers/dca/dca-core.c:273:4: warning: symbol 'dca_common_get_tag' was not declared. Should it be static? Signed-off-by: Colin Ian King Signed-off-by: David S. Miller

dmaengine: ioatdma: constify dca_ops structures

2015-11-16T03:57:32+00:00

The dca_ops structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Acked-by: Dan Williams Signed-off-by: Vinod Koul

dca: check against empty dca_domains list before unregister provider

2013-01-08T06:05:14+00:00

When providers get blocked unregister_dca_providers() is called ending up with dca_providers and dca_domain lists emptied. Dca should be prevented from trying to unregister any provider if dca_domain list is found empty. Cc: Reported-by: Jiang Liu Tested-by: Gaohuai Han Signed-off-by: Maciej Sosnowski Signed-off-by: Dan Williams

drivers/dca: Add module.h to dca-core.c

2011-10-31T23:31:43+00:00

This file really needs the full module.h header file present, but was just getting it implicitly before. Call it out in advance so that we don't get future build failures on this. Signed-off-by: Paul Gortmaker

locking, drivers/dca: Annotate dca_lock as raw

2011-09-13T09:12:12+00:00

The dca_lock can be taken in atomic context: [ 25.607536] Call Trace: [ 25.607557] [] try_stack_unwind+0x151/0x1a0 [ 25.607566] [] dump_trace+0x92/0x370 [ 25.607573] [] show_trace_log_lvl+0x5c/0x80 [ 25.607578] [] show_trace+0x15/0x20 [ 25.607587] [] dump_stack+0x77/0x8f [ 25.607595] [] __might_sleep+0x11a/0x130 [ 25.607602] [] rt_spin_lock+0x83/0x90 [ 25.607611] [] dca_common_get_tag+0x28/0x80 [dca] [ 25.607622] [] dca3_get_tag+0x18/0x20 [dca] [ 25.607634] [] igb_update_dca+0xb1/0x1d0 [igb] [ 25.607649] [] igb_setup_dca+0x65/0x80 [igb] [ 25.607663] [] igb_probe+0x946/0xe4d [igb] [ 25.607678] [] local_pci_probe+0x17/0x20 [ 25.607686] [] pci_device_probe+0x121/0x130 [ 25.607699] [] driver_probe_device+0xd2/0x2e0 [ 25.607707] [] __driver_attach+0x9b/0xa0 [ 25.607714] [] bus_for_each_dev+0x6b/0xa0 [ 25.607720] [] driver_attach+0x21/0x30 [ 25.607727] [] bus_add_driver+0x1e5/0x350 [ 25.607734] [] driver_register+0x81/0x160 [ 25.607742] [] __pci_register_driver+0x6f/0xf0 [ 25.607752] [] igb_init_module+0x5b/0x5d [igb] [ 25.607769] [] do_one_initcall+0x3d/0x1a0 [ 25.607778] [] sys_init_module+0xe6/0x270 [ 25.607786] [] system_call_fastpath+0x16/0x1b [ 25.607794] [<00007f84d6783f4a>] 0x7f84d6783f4a and thus must not be preempted on -rt. In mainline this change documents the low level nature of the lock - otherwise there's no functional difference. Lockdep and Sparse checking will work as usual. Signed-off-by: Mike Galbraith [ Fixed the domain allocation which was calling kzalloc from the irq disabled section ] Signed-off-by: Thomas Gleixner Signed-off-by: Ingo Molnar

drivers/dca/dca-core.c: use list_move() instead of list_del()/list_add() combination

2011-03-23T00:44:12+00:00

Signed-off-by: Kirill A. Shutemov Cc: Maciej Sosnowski Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

dca: remove unneeded NULL check

2011-01-13T16:03:09+00:00

The return here doesn't release the locks or re-enable IRQs. But as Andrew Morton points out, domain is never NULL. list_first_entry() essentially never returns NULL and also we already verified that the list is not empty. Signed-off-by: Dan Carpenter Acked-by: Maciej Sosnowski Cc: David Miller Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

dca: disable dca on IOAT ver.3.0 multiple-IOH platforms

2010-09-18T03:08:21+00:00

Direct Cache Access is not supported on IOAT ver.3.0 multiple-IOH platforms. This patch blocks registering of dca providers when multiple IOH detected with IOAT ver.3.0. Signed-off-by: Maciej Sosnowski Signed-off-by: David S. Miller