kernel/linux.git/drivers/crypto/intel/iaa, branch v6.18.21

crypto: iaa - Fix out-of-bounds index in find_empty_iaa_compression_mode

2026-02-16T09:19:44+00:00

commit 48329301969f6d21b2ef35f678e40f72b59eac94 upstream. The local variable 'i' is initialized with -EINVAL, but the for loop immediately overwrites it and -EINVAL is never returned. If no empty compression mode can be found, the function would return the out-of-bounds index IAA_COMP_MODES_MAX, which would cause an invalid array access in add_iaa_compression_mode(). Fix both issues by returning either a valid index or -EINVAL. Cc: stable@vger.kernel.org Fixes: b190447e0fa3 ("crypto: iaa - Add compression mode management along with fixed mode") Signed-off-by: Thorsten Blum Acked-by: Kanchana P Sridhar Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman

crypto: iaa - Fix incorrect return value in save_iaa_wq()

2025-12-18T13:03:00+00:00

[ Upstream commit 76ce17f6f7f78ab79b9741388bdb4dafa985b4e9 ] The save_iaa_wq() function unconditionally returns 0, even when an error is encountered. This prevents the error code from being propagated to the caller. Fix this by returning the 'ret' variable, which holds the actual status of the operations within the function. Fixes: ea7a5cbb43696 ("crypto: iaa - Add Intel IAA Compression Accelerator crypto driver core") Signed-off-by: Zilin Guan Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin

crypto: iaa - Optimize rebalance_wq_table()

2025-05-14T09:45:22+00:00

The function opencodes for_each_cpu() by using a plain for-loop. The loop calls cpumask_weight() inside the conditional section. Because cpumask_weight() is O(1), the overall complexity of the function is O(node * node_cpus^2). Also, cpumask_nth() internally calls hweight(), which, if not hardware accelerated, is slower than cpumask_next() in for_each_cpu(). If switched to the dedicated for_each_cpu(), the rebalance_wq_table() can drop calling cpumask_weight(), together with some housekeeping code. This makes the overall complexity O(node * node_cpus), or simply speaking O(nr_cpu_ids). While there, fix opencoded for_each_possible_cpu() too. Signed-off-by: Yury Norov Signed-off-by: Herbert Xu

crypto: iaa - Adjust workqueue allocation type

2025-04-28T11:45:26+00:00

In preparation for making the kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be implicitly cast to any pointer type.) The assigned type is "struct idxd_wq **", but the returned type will be "struct wq **". These are the same size allocation (pointer sized), but the types don't match. Adjust the allocation type to match the assignment. Signed-off-by: Kees Cook Signed-off-by: Herbert Xu

crypto: iaa - Use cra_reqsize for acomp

2025-04-16T07:16:21+00:00

Use the common reqsize field for acomp algorithms. Signed-off-by: Herbert Xu

crypto: iaa - Switch to ACOMP_FBREQ_ON_STACK

2025-04-16T07:16:20+00:00

Rather than copying the request by hand, use the ACOMP_FBREQ_ON_STACK helper to do it. Signed-off-by: Herbert Xu

crypto: iaa - Remove unused disable_async argument from iaa_decompress

2025-04-07T05:22:25+00:00

Remove the disable_async field left over after the NULL dst removal. Signed-off-by: Herbert Xu

crypto: iaa - Do not clobber req->base.data

2025-04-07T05:22:25+00:00

The req->base.data field is for the user and must not be touched by the driver, unless you save it first. The iaa driver doesn't seem to be using the req->base.data value so just remove the assignment. Fixes: 09646c98d0bf ("crypto: iaa - Add irq support for the crypto async interface") Signed-off-by: Herbert Xu

crypto: iaa - Move compression CRC into request object

2025-04-07T05:22:25+00:00

Rather than passing around a CRC between the functions, embed it into the acomp_request context. Signed-off-by: Herbert Xu

crypto: iaa - Use acomp stack fallback

2025-03-21T09:33:39+00:00

Use ACOMP_REQUEST_ON_STACK instead of allocating legacy fallback compression transform. Signed-off-by: Herbert Xu