kernel/linux.git/drivers/crypto/inside-secure, branch v4.17.1

crypto: inside-secure - do not use memset on MMIO

2018-05-26T15:58:44+00:00

This patch fixes the Inside Secure driver which uses a memtset() call to set an MMIO area from the cryptographic engine to 0. This is wrong as memset() isn't guaranteed to work on MMIO for many reasons. This led to kernel paging request panics in certain cases. Use memset_io() instead. Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver") Reported-by: Ofer Heifetz Signed-off-by: Antoine Tenart Signed-off-by: Herbert Xu

crypto: inside-secure - hmac(sha224) support

2018-03-30T17:32:49+00:00

This patch adds the hmac(sha224) support to the Inside Secure cryptographic engine driver. Signed-off-by: Antoine Tenart Signed-off-by: Herbert Xu

crypto: inside-secure - hmac(sha256) support

2018-03-30T17:32:48+00:00

This patch adds the hmac(sha256) support to the Inside Secure cryptographic engine driver. Signed-off-by: Antoine Tenart Signed-off-by: Herbert Xu

crypto: inside-secure - the context ipad/opad should use the state sz

2018-03-30T17:32:47+00:00

This patches uses the state size of the algorithms instead of their digest size to copy the ipad and opad in the context. This doesn't fix anything as the state and digest size are the same for many algorithms, and for all the hmac currently supported by this driver. However hmac(sha224) use the sha224 hash function which has a different digest and state size. This commit prepares the addition of such algorithms. Signed-off-by: Antoine Tenart Signed-off-by: Herbert Xu

crypto: inside-secure - improve the skcipher token

2018-03-30T17:32:46+00:00

The token used for encryption and decryption of skcipher algorithms sets its stat field to "last packet". As it's a cipher only algorithm, there is not hash operation and thus the "last hash" bit should be set to tell the internal engine no hash operation should be performed. This does not fix a bug, but improves the token definition to follow exactly what's advised by the datasheet. Signed-off-by: Antoine Tenart Signed-off-by: Herbert Xu

crypto: inside-secure - do not access buffers mapped to the device

2018-03-30T17:32:45+00:00

This patches update the way the digest is copied from the state buffer to the result buffer, so that the copy only happen after the state buffer was DMA unmapped, as otherwise the buffer would be owned by the device. Signed-off-by: Antoine Tenart Signed-off-by: Herbert Xu

crypto: inside-secure - improve the send error path

2018-03-30T17:32:45+00:00

This patch improves the send error path as it wasn't handling all error cases. A new label is added, and some of the goto are updated to point to the right labels, so that the code is more robust to errors. Signed-off-by: Antoine Tenart Signed-off-by: Herbert Xu

crypto: inside-secure - fix a typo in a register name

2018-03-30T17:32:44+00:00

This patch fixes a typo in the EIP197_HIA_xDR_WR_CTRL_BUG register name, as it should be EIP197_HIA_xDR_WR_CTRL_BUF. This is a cosmetic only change. Signed-off-by: Antoine Tenart Signed-off-by: Herbert Xu

crypto: inside-secure - fix typo s/allways/always/ in a define

2018-03-30T17:32:43+00:00

Small cosmetic patch fixing one typo in the EIP197_HIA_DSE_CFG_ALLWAYS_BUFFERABLE macro, it should be _ALWAYS_. Signed-off-by: Antoine Tenart Signed-off-by: Herbert Xu

crypto: inside-secure - move the digest to the request context

2018-03-30T17:32:42+00:00

This patches moves the digest information from the transformation context to the request context. This fixes cases where HMAC init functions were called and override the digest value for a short period of time, as the HMAC init functions call the SHA init one which reset the value. This lead to a small percentage of HMAC being incorrectly computed under heavy load. Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver") Suggested-by: Ofer Heifetz Signed-off-by: Antoine Tenart [Ofer here did all the work, from seeing the issue to understanding the root cause. I only made the patch.] Signed-off-by: Herbert Xu