kernel/linux.git/drivers/crypto/cavium/nitrox, branch v6.12.91

crypto: nitrox - Remove cfb

2023-12-08T03:59:46+00:00

Remove the unused CFB implementation. Signed-off-by: Herbert Xu

crypto: cavium/nitrox - refactor deprecated strncpy

2023-09-20T05:15:29+00:00

`strncpy` is deprecated for use on NUL-terminated destination strings [1]. We know `hw.partname` is supposed to be NUL-terminated by its later use with seq_printf: | nitrox_debugfs.c +25 | seq_printf(s, " Part Name: %s\n", ndev->hw.partname); Let's prefer a more robust and less ambiguous string interface. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on the destination buffer. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Justin Stitt Reviewed-by: Kees Cook Signed-off-by: Herbert Xu

crypto: cavium/nitrox - remove unnecessary aer.h include

2023-03-17T03:16:43+00:00

is unused, so remove it. Signed-off-by: Bjorn Helgaas Signed-off-by: Herbert Xu

crypto: nitrox - Use request_complete helpers

2023-02-13T10:34:49+00:00

Use the request_complete helpers instead of calling the completion function directly. Signed-off-by: Herbert Xu

crypto: xts - drop xts_check_key()

2023-01-06T09:15:47+00:00

xts_check_key() is obsoleted by xts_verify_key(). Over time XTS crypto drivers adopted the newer xts_verify_key() variant, but xts_check_key() is still used by a number of drivers. Switch drivers to use the newer xts_verify_key() and make a couple of cleanups. This allows us to drop xts_check_key() completely and avoid redundancy. Signed-off-by: Vladis Dronov Reviewed-by: Eric Biggers Reviewed-by: Nicolai Stange Signed-off-by: Herbert Xu

crypto: cavium - Set DMA alignment explicitly

2022-12-09T10:45:00+00:00

This driver has been implicitly relying on kmalloc alignment to be sufficient for DMA. This may no longer be the case with upcoming arm64 changes. This patch changes it to explicitly request DMA alignment from the Crypto API. Signed-off-by: Herbert Xu

crypto: nitrox - avoid double free on error path in nitrox_sriov_init()

2022-10-21T11:15:35+00:00

If alloc_workqueue() fails in nitrox_mbox_init() it deallocates ndev->iov.vfdev and returns error code, but then nitrox_sriov_init() calls nitrox_sriov_cleanup() where ndev->iov.vfdev is deallocated again. Fix this by nulling ndev->iov.vfdev after the first deallocation. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 9e5de3e06e54 ("crypto: cavium/nitrox - Add mailbox...") Signed-off-by: Natalia Petrova Signed-off-by: Alexey Khoroshilov Signed-off-by: Herbert Xu

crypto: cavium/nitrox - remove check of list iterator against head past the loop body

2022-04-08T08:26:43+00:00

When list_for_each_entry() completes the iteration over the whole list without breaking the loop, the iterator value will be a bogus pointer computed based on the head element. While it is safe to use the pointer to determine if it was computed based on the head element, either with list_entry_is_head() or &pos->member == head, using the iterator variable after the loop should be avoided. In preparation to limit the scope of a list iterator to the list traversal loop, use a dedicated pointer to point to the found element [1]. Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1] Signed-off-by: Jakob Koschel Signed-off-by: Herbert Xu

crypto: cavium/nitrox - don't cast parameter in bit operations

2022-03-02T22:49:21+00:00

While in this particular case it would not be a (critical) issue, the pattern itself is bad and error prone in case the location of the parameter is changed. Don't cast parameter to unsigned long pointer in the bit operations. Instead copy to a local variable on stack of a proper type and use. Fixes: cf718eaa8f9b ("crypto: cavium/nitrox - Enabled Mailbox support") Signed-off-by: Andy Shevchenko Signed-off-by: Herbert Xu

crypto: cavium/nitrox - fix typo on crypto

2022-02-18T05:21:08+00:00

crypto had a typo, fix it. Signed-off-by: Corentin Labbe Signed-off-by: Herbert Xu