kernel/linux.git/drivers/crypto/aspeed, branch v6.19.11

crypto: aspeed - fix double free caused by devm

2025-10-23T04:53:23+00:00

The clock obtained via devm_clk_get_enabled() is automatically managed by devres and will be disabled and freed on driver detach. Manually calling clk_disable_unprepare() in error path and remove function causes double free. Remove the manual clock cleanup in both aspeed_acry_probe()'s error path and aspeed_acry_remove(). Fixes: 2f1cf4e50c95 ("crypto: aspeed - Add ACRY RSA driver") Signed-off-by: Haotian Zhang Signed-off-by: Herbert Xu

crypto: aspeed - Fix dma_unmap_sg() direction

2025-09-20T12:21:03+00:00

It seems like everywhere in this file, when the request is not bidirectionala, req->src is mapped with DMA_TO_DEVICE and req->dst is mapped with DMA_FROM_DEVICE. Fixes: 62f58b1637b7 ("crypto: aspeed - add HACE crypto driver") Cc: Signed-off-by: Thomas Fourier Signed-off-by: Herbert Xu

crypto: aspeed - Fix hash fallback path typo

2025-06-26T04:56:26+00:00

Fix typo in the fallback code path. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202506231830.us4hiwlZ-lkp@intel.com/ Signed-off-by: Herbert Xu

crypto: aspeed/hash - Fix potential overflow in dma_prepare_sg

2025-06-13T09:26:15+00:00

The mapped SG lists are written to hash_engine->ahash_src_addr which has the size ASPEED_HASH_SRC_DMA_BUF_LEN. Since scatterlists are not bound in size, make sure that size is not exceeded. If the mapped SG list is larger than the buffer, simply iterate over it as is done in the dma_prepare case. Signed-off-by: Herbert Xu

crypto: aspeed/hash - Iterate on large hashes in dma_prepare

2025-06-13T09:26:15+00:00

Rather than failing a hash larger than ASPEED_CRYPTO_SRC_DMA_BUF_LEN, just hash them over and over again until it's done. Signed-off-by: Herbert Xu

crypto: aspeed/hash - Add fallback

2025-06-13T09:26:15+00:00

If a hash request fails due to a DMA mapping error, or if it is too large to fit in the the driver buffer, use a fallback to do the hash rather than failing. Signed-off-by: Herbert Xu

crypto: aspeed/hash - Use API partial block handling

2025-06-13T09:26:15+00:00

Use the Crypto API partial block handling. Also switch to the generic export format. Remove final function that is no longer used by the Crypto API. Move final padding into aspeed_ahash_dma_prepare_sg. Signed-off-by: Herbert Xu

crypto: aspeed/hash - Remove sha_iv

2025-06-13T09:26:15+00:00

Removed unused sha_iv field from request context. Signed-off-by: Herbert Xu

crypto: aspeed/hash - Move final padding into dma_prepare

2025-06-13T09:26:15+00:00

Rather than processing a final as two separate updates, combine them into one for the linear dma_prepare case. This means that the total hash size is slightly reduced, but that will be fixed up later by repeating the hash if necessary. Signed-off-by: Herbert Xu

crypto: aspeed/hash - Move sham_final call into sham_update

2025-06-13T09:26:15+00:00

The only time when sham_final needs to be called in sham_finup is when the finup request fits into the partial block. Move this special handling into sham_update. The comment about releaseing resources is non-sense. The Crypto API does not mandate the use of final so the user could always go away after an update and never come back. Therefore the driver must not hold any resources after an update call. Signed-off-by: Herbert Xu