kernel/linux.git/drivers/crypto/allwinner, branch v6.19.11Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.19.112025-10-23T04:55:43+00:00crypto: sun8i-ss - Move j init earlier in sun8i_ss_hash_run2025-10-23T04:55:43+00:00Herbert Xuherbert@gondor.apana.org.au2025-10-17T08:00:50+00:00urn:sha1:7fc25ed2bc35c2abe00ebd26af902b5688ead5c4
With gcc-14 I get
../drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c: In function ‘sun8i_ss_hash_run’:
../drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c:631:21: warning: ‘j’ may be used uninitialized [-Wmaybe-uninitialized]
631 | j = hash_pad(bf, 4096, j, byte_count, true, bs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c:493:13: note: ‘j’ was declared here
493 | int j, i, k, todo;
| ^
Fix this false positive by moving the initialisation of j earlier.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crytpo: sun8i-ce - factor out prepare/unprepare from sun8i_ce_hash_run()2025-09-13T04:11:05+00:00Ovidiu Panaitovidiu.panait.oss@gmail.com2025-09-02T13:21:34+00:00urn:sha1:27d5a2d1ad94561994fe6b5ed3a2258039e9ac2b
In order to make the ahash code more clear and modular, split the
monolithic sun8i_ce_hash_run() callback into two parts, prepare and
unprepare (therefore aligning it with the sun8i-ce skcipher code).
Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: sun8i-ce - save hash buffers and dma info to request context2025-09-13T04:11:05+00:00Ovidiu Panaitovidiu.panait.oss@gmail.com2025-09-02T13:21:33+00:00urn:sha1:c3a61eea658a9f6808a3d466a0978320b3855b49
Similar to sun8i-ce skcipher code, move all request-specific data to
request context. This simplifies sun8i_ce_hash_run() and it eliminates
the remaining kmalloc() calls from the digest path.
Since the 'result' buffer in the request ctx struct is used for from-device
DMA, it needs to be properly aligned to CRYPTO_DMA_ALIGN. Therefore:
- increase reqsize by CRYPTO_DMA_PADDING
- add __aligned(CRYPTO_DMA_ALIGN) attribute for the 'result' buffer
- convert all ahash_request_ctx_dma() calls to ahash_request_ctx_dma()
Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: sun8i-ce - pass task descriptor to cipher prepare/unprepare2025-09-13T04:11:05+00:00Ovidiu Panaitovidiu.panait.oss@gmail.com2025-09-02T13:21:32+00:00urn:sha1:49034c03b5814ba4257927be2916bdadfe281be7
To remove some duplicated code, directly pass 'struct skcipher_request' and
'struct ce_task' pointers to sun8i_ce_cipher_{prepare,unprepare}.
Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: sun8i-ce - fold sun8i_ce_cipher_run() into sun8i_ce_cipher_do_one()2025-09-13T04:11:05+00:00Ovidiu Panaitovidiu.panait.oss@gmail.com2025-09-02T13:21:31+00:00urn:sha1:2dc57f02f24957626f5c07e69486915eecc9ebd8
Fold sun8i_ce_cipher_run() into it's only caller, sun8i_ce_cipher_do_one(),
to eliminate a bit of boilerplate.
Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: sun8i-ce - move bounce_iv and backup_iv to request context2025-09-13T04:11:05+00:00Ovidiu Panaitovidiu.panait.oss@gmail.com2025-09-02T13:21:30+00:00urn:sha1:27eaada08c8c94f0d89225c8fd982320c68b9a80
Currently, the iv buffers are allocated per flow during driver probe,
which means that the buffers are shared by all requests. This works
because the driver is not yet truly asynchronous, since it waits inside
do_one_request() for the completion irq.
However, the iv data is request-specific, so it should be part of the
request context. Move iv buffers to request context.
The bounce_iv buffer is aligned to sizeof(u32) to match the 'word address'
requirement for the task descriptor's iv field.
Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: sun8i-ce - add a new function for dumping task descriptors2025-09-13T04:11:05+00:00Ovidiu Panaitovidiu.panait.oss@gmail.com2025-09-02T13:21:29+00:00urn:sha1:cedb1e9e9a6465ce0568588d6b8ff10b9826603e
In order to remove code duplication, factor out task descriptor dumping to
a new function sun8i_ce_dump_task_descriptors().
Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: sun8i-ce - remove unnecessary __maybe_unused annotations2025-09-13T04:11:05+00:00Ovidiu Panaitovidiu.panait.oss@gmail.com2025-09-02T13:21:28+00:00urn:sha1:6713d9842bd50463ce5f8e2ed056c4d843b9fee0
There are 3 instances of '__maybe_unused' annotations that are not needed,
as the variables are always used, so remove them.
Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: sun8i-ce - remove boilerplate in sun8i_ce_hash_digest()2025-09-13T04:11:05+00:00Ovidiu Panaitovidiu.panait.oss@gmail.com2025-09-02T13:21:27+00:00urn:sha1:01d7d3c3db778c89b4943cd70c2dc25c8ed96c4f
Retrieve the dev pointer from tfm context to eliminate some boilerplate
code in sun8i_ce_hash_digest().
Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Tested-by: Corentin LABBE <clabbe.montjoie@gmail.com>
Reviewed-by: Corentin LABBE <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: sun8i-ce - remove channel timeout field2025-09-13T04:11:05+00:00Ovidiu Panaitovidiu.panait.oss@gmail.com2025-09-02T13:21:26+00:00urn:sha1:9a23ea1f7558bdd3f8d2b35b1c2e16a2f9bf671e
Using the number of bytes in the request as DMA timeout is really
inconsistent, as large requests could possibly set a timeout of
hundreds of seconds.
Remove the per-channel timeout field and use a single, static DMA
timeout of 3 seconds for all requests.
Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Tested-by: Corentin LABBE <clabbe.montjoie@gmail.com>
Reviewed-by: Corentin LABBE <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>