kernel/linux.git/drivers/char/misc_minor_kunit.c, branch linux-7.1.yLinux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=linux-7.1.y2025-12-29T10:59:22+00:00char: misc: Use IS_ERR() for filp_open() return value2025-12-29T10:59:22+00:00Alper Akalperyasinak1@gmail.com2025-12-26T23:02:48+00:00urn:sha1:e849ada70c6b1ee22e9f4f5c0e38231dcee53f04
filp_open() never returns NULL, it returns either a valid pointer or an
error pointer. Using IS_ERR_OR_NULL() is unnecessary. Additionally, if
filp were NULL, PTR_ERR(NULL) would return 0, leading to a misleading
error message.
Fixes: 74d8361be344 ("char: misc: add test cases")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202506132058.thWZHlrb-lkp@intel.com/
Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Link: https://patch.msgid.link/20251226230248.113073-1-alperyasinak1@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
char: misc: Add a case to test registering miscdevice again without reinitialization2025-08-19T10:41:17+00:00Zijun Huzijun.hu@oss.qualcomm.com2025-07-14T15:34:15+00:00urn:sha1:2334668aaf410382412b8c81f7014283f3e80354
For miscdevice who wants dynamic minor, add a cast to test if it can be
successfully registered again without reinitialization:
1) Provide Both miscdevice @dev_A and @dev_B want to request dynamic
minor by initializing their minor to MISC_DYNAMIC_MINOR.
2) Register then de-register @dev_A.
3) Register @dev_B.
4) Register @dev_A again without reinitialization.
5) Check if @dev_A can be successfully registered.
Signed-off-by: Zijun Hu <zijun.hu@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250714-rfc_miscdev-v6-4-2ed949665bde@oss.qualcomm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
char: misc: Adapt and add test cases for simple minor space division2025-08-19T10:41:17+00:00Zijun Huzijun.hu@oss.qualcomm.com2025-07-14T15:34:13+00:00urn:sha1:f4e47affdb2edb99834dfd03f5ea8a899bbb98f0
Adapt and add test cases for next change which regards minor whose
value > macro MISC_DYNAMIC_MINOR as invalid parameter when register
miscdevice, hence get a simple minor space division below:
< MISC_DYNAMIC_MINOR: fixed minor code
== MISC_DYNAMIC_MINOR: indicator to request dynamic minor code
> MISC_DYNAMIC_MINOR: dynamic minor code requested
Signed-off-by: Zijun Hu <zijun.hu@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250714-rfc_miscdev-v6-2-2ed949665bde@oss.qualcomm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
char: misc: Move drivers/misc/misc_minor_kunit.c to drivers/char/2025-08-19T10:41:17+00:00Zijun Huzijun.hu@oss.qualcomm.com2025-07-14T15:34:12+00:00urn:sha1:8ac646d6dfbf8e42bdb31b71e03a7984557ab1b1
drivers/misc/misc_minor_kunit.c is to test APIs defined in
drivers/char/misc.c, but is not in the same directory as the later.
Move misc_minor_kunit.c to drivers/char/.
Signed-off-by: Zijun Hu <zijun.hu@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250714-rfc_miscdev-v6-1-2ed949665bde@oss.qualcomm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>