kernel/linux.git/drivers/char/ipmi, branch v4.17.1

ipmi/parisc: Add IPMI chassis poweroff for certain HP PA-RISC and IA-64 servers

2018-03-27T16:04:17+00:00

This patch allows HP PA-RISC servers like rp3410/rp3440 and the HP C8000 workstation with an IPMI controller that predate IPMI 1.5 to use the standard poweroff or powercycle commands. These systems firmware don't set the chassis capability bit in the Get Device ID, but they do implement the standard poweroff and powercycle commands. Signed-off-by: Helge Deller Signed-off-by: Corey Minyard

ipmi_ssif: Fix kernel panic at msg_done_handler

2018-03-13T12:12:26+00:00

This happens when BMC doesn't return any data and the code is trying to print the value of data[2]. Getting following crash: [ 484.728410] Unable to handle kernel NULL pointer dereference at virtual address 00000002 [ 484.736496] pgd = ffff0000094a2000 [ 484.739885] [00000002] *pgd=00000047fcffe003, *pud=00000047fcffd003, *pmd=0000000000000000 [ 484.748158] Internal error: Oops: 96000005 [#1] SMP [...] [ 485.101451] Call trace: [...] [ 485.188473] [] msg_done_handler+0x668/0x700 [ipmi_ssif] [ 485.195249] [] ipmi_ssif_thread+0x110/0x128 [ipmi_ssif] [ 485.202038] [] kthread+0x108/0x138 [ 485.206994] [] ret_from_fork+0x10/0x30 [ 485.212294] Code: aa1903e1 aa1803e0 b900227f 95fef6a5 (39400aa3) Adding a check to validate the data len before printing data[2] to fix this issue. Signed-off-by: Kamlakant Patel Signed-off-by: Corey Minyard

ipmi:pci: Blacklist a Realtek "IPMI" device

2018-03-13T11:58:47+00:00

Realtek has some sort of "Virtual" IPMI device on the PCI bus as a KCS controller, but whatever it is, it's not one. Ignore it if seen. Reported-by: Chris Chiu Signed-off-by: Corey Minyard Tested-by: Daniel Drake

ipmi: Remove ACPI SPMI probing from the system interface driver

2018-03-12T12:03:06+00:00

The IPMI spec states: The purpose of the SPMI Table is to provide a mechanism that can be used by the OSPM (an ACPI term for “OS Operating System-directed configuration and Power Management” essentially meaning an ACPI-aware OS or OS loader) very early in the boot process, e.g., before the ability to execute ACPI control methods in the OS is available. When we are probing IPMI in Linux, ACPI control methods are available, so we shouldn't be probing using SPMI. It could cause some confusion during the probing process. Signed-off-by: Corey Minyard

ipmi: Remove ACPI SPMI probing from the SSIF (I2C) driver

2018-03-12T12:02:47+00:00

ipmi: missing error code in try_smi_init()

2018-03-07T01:47:52+00:00

If platform_device_alloc() then we should return -ENOMEM instead of returning success. Signed-off-by: Dan Carpenter Signed-off-by: Corey Minyard

ipmi: use ARRAY_SIZE for poweroff_functions array sizing calculation

2018-03-07T01:47:51+00:00

Use the ARRAY_SIZE macro on a array poweroff_functions to determine size of the array. Improvement suggested by Coccinelle. Signed-off-by: Colin Ian King Signed-off-by: Corey Minyard

ipmi: Consolidate cleanup code

2018-03-07T01:47:50+00:00

The cleanup code for an init failure and for a device removal were quite similar, consolidate all that into one function. Signed-off-by: Corey Minyard

ipmi: Remove some unnecessary initializations

2018-03-07T01:47:49+00:00

The data is allocated with kzalloc, no need to set things to NULL. Signed-off-by: Corey Minyard

ipmi: Fix some error cleanup issues

2018-03-07T01:47:17+00:00

device_remove_group() was called on any cleanup, even if the device attrs had not been added yet. That can occur in certain error scenarios, so add a flag to know if it has been added. Also make sure we remove the dev if we added it ourselves. Signed-off-by: Corey Minyard Cc: stable@vger.kernel.org # 4.15 Cc: Laura Abbott Tested-by: Bill Perkins