kernel/linux.git/drivers/char/ipmi/ipmi_powernv.c, branch v6.3.2

ipmi:powernv: Convert ipmi_smi_t to struct ipmi_smi

2018-09-18T21:15:33+00:00

Since everything else has been converted. Signed-off-by: Corey Minyard

ipmi: Add or fix SPDX-License-Identifier in all files

2018-02-27T13:42:51+00:00

And get rid of the license text that is no longer necessary. Signed-off-by: Corey Minyard Cc: Kees Cook Cc: Alistair Popple Cc: Jeremy Kerr Cc: Joel Stanley Cc: Rocky Craig

ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-22T14:10:37+00:00

Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Fixes: dce143c3381c ("ipmi/powernv: Convert to irq event interface") Signed-off-by: Wei Yongjun Reviewed-by: Alexey Kardashevskiy Signed-off-by: Corey Minyard

ipmi/ipmi_powernv: remove outdated todo in powernv IPMI driver

2018-01-16T22:08:44+00:00

Since the IPMI core now queries device IDs dynamically, we no longer need this todo for implementing this in the powernv driver. Signed-off-by: Jeremy Kerr Signed-off-by: Corey Minyard

ipmi: Remove the device id from ipmi_register_smi()

2017-09-27T21:03:45+00:00

It's no longer used, dynamic device id handling is in place now. Signed-off-by: Corey Minyard

char: ipmi: constify ipmi_smi_handlers structures

2017-02-09T15:10:56+00:00

Declare ipmi_smi_handlers structures as const as they are only passed as an argument to the function ipmi_register_smi. This argument is of type const, so ipmi_smi_handlers structures having similar properties can be declared const too. Done using Coccinelle: @r1 disable optional_qualifier@ identifier i; position p; @@ static struct ipmi_smi_handlers i@p={...}; @ok1@ identifier r1.i; position p; @@ ipmi_register_smi(&i@p,...) @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct ipmi_smi_handlers i; Size details after cross compiling the .o file for powerpc architecture File size before: text data bss dec hex filename 2777 288 0 3065 bf9 drivers/char/ipmi/ipmi_powernv.o File size after: text data bss dec hex filename 2873 192 0 3065 bf9 drivers/char/ipmi/ipmi_powernv.o Signed-off-by: Bhumika Goyal Signed-off-by: Corey Minyard

impi:Remove unneeded setting of module owner to THIS_MODULE in the platform structure, powernv_ipmi_driver

2015-09-03T20:02:24+00:00

This removes the no longer required setting of the module owner for the plaform structure,powernv_ipmi_driver to THIS_MODULE as the driver core for ipmi drivers will directly find and set the module owner for this driver. Signed-off-by: Nicholas Krause Signed-off-by: Corey Minyard

ipmi/powernv: Fix potential invalid pointer dereference

2015-09-03T20:01:55+00:00

If the OPAL call to receive the ipmi message fails, then we free up the smi message and return. But, the driver still holds the reference to old smi message in the 'cur_msg' which can potentially be accessed later and freed again leading to kernel oops. To fix it up, The kernel driver should reset the 'cur_msg' and send reply to the user in addition to freeing the message. Signed-off-by: Neelesh Gupta Fixed a checkpatch warning dealing with an else after a return. Signed-off-by: Corey Minyard

ipmi/powernv: Convert to irq event interface

2015-05-22T05:14:37+00:00

Convert the opal ipmi driver to use the new irq interface for events. Signed-off-by: Alistair Popple Acked-by: Corey Minyard Cc: Corey Minyard Cc: openipmi-developer@lists.sourceforge.net Signed-off-by: Michael Ellerman

ipmi/powernv: Fix minor locking bug

2015-04-11T01:51:42+00:00

If ipmi_powernv_recv(...) is called without a current message it prints a warning and returns. However it fails to release the message lock causing the system to dead lock during any subsequent IPMI operations. This error path should never normally be taken unless there are bugs elsewhere in the system. Signed-off-by: Alistair Popple Signed-off-by: Corey Minyard