kernel/linux.git/drivers/char/hw_random/cctrng.c, branch v6.6.142Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.6.1422024-10-04T14:29:55+00:00hwrng: cctrng - Add missing clk_disable_unprepare in cctrng_resume2024-10-04T14:29:55+00:00Gaosheng Cuicuigaosheng1@huawei.com2024-08-03T06:49:23+00:00urn:sha1:1b4089d567786c2e1e2defdafc693cca9b6ed1d4
commit 4b7acc85de14ee8a2236f54445dc635d47eceac0 upstream.
Add the missing clk_disable_unprepare() before return in
cctrng_resume().
Fixes: a583ed310bb6 ("hwrng: cctrng - introduce Arm CryptoCell driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hwrng: cctrng - use dev_err_probe in error paths2023-07-28T10:20:25+00:00Martin Kaisermartin@kaiser.cx2023-07-19T07:18:06+00:00urn:sha1:9553ae3497f0753b79efa54b1719a7117e10bdf4
Use dev_err_probe in error paths to make the code a bit shorter.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
hwrng: cctrng - merge cc_trng_clk_init into its only caller2023-07-28T10:20:25+00:00Martin Kaisermartin@kaiser.cx2023-07-19T07:18:05+00:00urn:sha1:80a34c037713b183032fad578cf5cb88b94298a8
cc_trng_clk_init is called only from the probe function. Merge the two
functions, this saves some lines of code.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
hwrng: cctrng - let devres enable the clock2023-07-28T10:20:25+00:00Martin Kaisermartin@kaiser.cx2023-07-19T07:18:04+00:00urn:sha1:8bcd9689384810bd1c610419563c827e23118e34
Call devm_clk_get_optional_enabled in the cctrng driver. We don't have to
disable and unprepare the clock any more in error paths or in the remove
function.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
hwrng: cctrng - don't open code init and exit functions2023-07-28T10:20:25+00:00Martin Kaisermartin@kaiser.cx2023-07-19T07:18:03+00:00urn:sha1:80e40fea8e2a7528b079ac1853da528c5cabf625
Do not open code the init and exit functions of the cctrng driver.
If we move the BUILD_BUG_ON checks into the probe function, we can use
module_platform_driver and make the code shorter.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
hwrng: cctrng - delete redundant printing of return value2021-03-19T10:59:47+00:00Wang Qingwangqing@vivo.com2021-03-13T07:47:42+00:00urn:sha1:befb1ddaece17e346550b6f2bb494ba58d67af43
platform_get_irq() has already checked and printed the return value,
the printing here is nothing special, it is not necessary at all.
Signed-off-by: Wang Qing <wangqing@vivo.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
hwrng: cctrng - use devm_platform_ioremap_resource() to simplify2021-03-19T10:59:46+00:00Tian Taotiantao6@hisilicon.com2021-03-13T01:42:35+00:00urn:sha1:f50281df94d76d40e8afa2433f39c7b4b8bd6868
Use devm_platform_ioremap_resource() to simplify the code.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
hwrng: cctrng - Use device-managed registration API2021-03-12T13:04:00+00:00Tian Taotiantao6@hisilicon.com2021-03-01T02:43:48+00:00urn:sha1:ae8351284b74bf93eb4d2b67178f2e9a09c19932
Use devm_hwrng_register to get rid of manual unregistration.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
hwrng: cctrn - Simplify with dev_err_probe()2020-09-04T07:57:15+00:00Krzysztof Kozlowskikrzk@kernel.org2020-08-26T15:32:33+00:00urn:sha1:4d6aef2f2eaabf4512321341439023e042633aba
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Hadar Gat <hadar.gat@arm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
hwrng: cctrng - Make some symbols static2020-04-30T05:19:34+00:00Zou Weizou_wei@huawei.com2020-04-23T12:21:21+00:00urn:sha1:43f3c2b4dde331d380e4f575d3e5798f27867b3e
Fix the following sparse warnings:
drivers/char/hw_random/cctrng.c:316:6: warning: symbol
'cc_trng_compwork_handler' was not declared. Should it be static?
drivers/char/hw_random/cctrng.c:451:6: warning: symbol
'cc_trng_startwork_handler' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Acked-by: Hadar Gat <hadar.gat@arm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>