kernel/linux.git/drivers/char/hw_random/cctrng.c, branch v6.19.11

hwrng: drivers - Remove redundant pm_runtime_mark_last_busy() calls

2025-07-18T10:51:59+00:00

pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), pm_runtime_autosuspend() and pm_request_autosuspend() now include a call to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to pm_runtime_mark_last_busy(). Signed-off-by: Sakari Ailus Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Herbert Xu

hwrng: drivers - Switch back to struct platform_driver::remove()

2024-11-02T10:23:24+00:00

After commit 0edb555a65d1 ("platform: Make platform_driver::remove() return void") .remove() is (again) the right callback to implement for platform drivers. Convert all platform drivers below drivers/char/hw_random to use .remove(), with the eventual goal to drop struct platform_driver::remove_new(). As .remove() and .remove_new() have the same prototypes, conversion is done by just changing the structure member name in the driver initializer. Signed-off-by: Uwe Kleine-König Signed-off-by: Herbert Xu

hwrng: cctrng - Add missing clk_disable_unprepare in cctrng_resume

2024-08-10T04:25:34+00:00

Add the missing clk_disable_unprepare() before return in cctrng_resume(). Fixes: a583ed310bb6 ("hwrng: cctrng - introduce Arm CryptoCell driver") Cc: Signed-off-by: Gaosheng Cui Signed-off-by: Herbert Xu

hwrng: cctrng - Convert to platform remove callback returning void

2023-12-15T09:52:54+00:00

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Herbert Xu

hwrng: cctrng - use dev_err_probe in error paths

2023-07-28T10:20:25+00:00

Use dev_err_probe in error paths to make the code a bit shorter. Signed-off-by: Martin Kaiser Signed-off-by: Herbert Xu

hwrng: cctrng - merge cc_trng_clk_init into its only caller

2023-07-28T10:20:25+00:00

cc_trng_clk_init is called only from the probe function. Merge the two functions, this saves some lines of code. Signed-off-by: Martin Kaiser Signed-off-by: Herbert Xu

hwrng: cctrng - let devres enable the clock

2023-07-28T10:20:25+00:00

Call devm_clk_get_optional_enabled in the cctrng driver. We don't have to disable and unprepare the clock any more in error paths or in the remove function. Signed-off-by: Martin Kaiser Signed-off-by: Herbert Xu

hwrng: cctrng - don't open code init and exit functions

2023-07-28T10:20:25+00:00

Do not open code the init and exit functions of the cctrng driver. If we move the BUILD_BUG_ON checks into the probe function, we can use module_platform_driver and make the code shorter. Signed-off-by: Martin Kaiser Signed-off-by: Herbert Xu

hwrng: cctrng - delete redundant printing of return value

2021-03-19T10:59:47+00:00

platform_get_irq() has already checked and printed the return value, the printing here is nothing special, it is not necessary at all. Signed-off-by: Wang Qing Signed-off-by: Herbert Xu

hwrng: cctrng - use devm_platform_ioremap_resource() to simplify

2021-03-19T10:59:46+00:00

Use devm_platform_ioremap_resource() to simplify the code. Signed-off-by: Tian Tao Signed-off-by: Herbert Xu