kernel/linux.git/drivers/bluetooth/btmtkuart.c, branch v6.6.132

Bluetooth: btmtkuart: fix recv_buf() return value

2024-01-25T23:35:29+00:00

[ Upstream commit 64057f051f20c2a2184b9db7f8037d928d68a4f4 ] Serdev recv_buf() callback is supposed to return the amount of bytes consumed, therefore an int in between 0 and count. Do not return negative number in case of issue, just print an error and return count. This fixes a WARN in ttyport_receive_buf(). Link: https://lore.kernel.org/all/087be419-ec6b-47ad-851a-5e1e3ea5cfcc@kernel.org/ Fixes: 7237c4c9ec92 ("Bluetooth: mediatek: Add protocol support for MediaTek serial devices") Signed-off-by: Francesco Dolcini Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin

bluetooth: Explicitly include correct DT includes

2023-08-11T18:50:24+00:00

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring Signed-off-by: Luiz Augusto von Dentz

Bluetooth: btmtkuart: mark OF related data as maybe unused

2023-04-24T04:49:47+00:00

The driver can be compile tested with !CONFIG_OF making certain data unused: drivers/bluetooth/btmtkuart.c:971:36: error: ‘mt7668_data’ defined but not used [-Werror=unused-const-variable=] drivers/bluetooth/btmtkuart.c:966:36: error: ‘mt7663_data’ defined but not used [-Werror=unused-const-variable=] drivers/bluetooth/btmtkuart.c:962:36: error: ‘mt7622_data’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski Signed-off-by: Luiz Augusto von Dentz

Bluetooth: btmtkuart: fix error handling in mtk_hci_wmt_sync()

2022-03-18T16:12:08+00:00

This code has an uninitialized variable warning: drivers/bluetooth/btmtkuart.c:184 mtk_hci_wmt_sync() error: uninitialized symbol 'wc'. But it also has error paths which have memory leaks. Fixes: 8f550f55b155 ("Bluetooth: btmtkuart: rely on BT_MTK module") Signed-off-by: Dan Carpenter Signed-off-by: Marcel Holtmann

Bluetooth: btmtkuart: fix the conflict between mtk and msft vendor event

2022-03-18T16:12:07+00:00

There is a conflict between MediaTek wmt event and msft vendor extension logic in the core layer since 145373cb1b1f ("Bluetooth: Add framework for Microsoft vendor extension") was introduced because we changed the type of mediatek wmt event to the type of msft vendor event in the driver. But the purpose we reported mediatek event to the core layer is for the diagnostic purpose with that we are able to see the full packet trace via monitoring socket with btmon. Thus, it is harmless we keep the original type of mediatek vendor event here to avoid breaking the msft extension function especially they can be supported by Mediatek future devices. Signed-off-by: Sean Wang Signed-off-by: Marcel Holtmann

Bluetooth: btmtkuart: add .set_bdaddr support

2022-03-18T16:12:07+00:00

add .set_bdaddr support Signed-off-by: Sean Wang Signed-off-by: Marcel Holtmann

Bluetooth: btmtkuart: rely on BT_MTK module

2022-03-18T16:12:07+00:00

Rely on btmtk module to reduce duplicated code Signed-off-by: Sean Wang Signed-off-by: Marcel Holtmann

Bluetooth: btmtkuart: fix a memleak in mtk_hci_wmt_sync

2021-09-22T14:15:54+00:00

bdev->evt_skb will get freed in the normal path and one error path of mtk_hci_wmt_sync, while the other error paths do not free it, which may cause a memleak. This bug is suggested by a static analysis tool, please advise. Fixes: e0b67035a90b ("Bluetooth: mediatek: update the common setup between MT7622 and other devices") Signed-off-by: Dinghao Liu Signed-off-by: Marcel Holtmann

Bluetooth: btmtkuart: using pm_runtime_resume_and_get instead of pm_runtime_get_sync

2021-06-26T05:12:38+00:00

Using pm_runtime_resume_and_get is more appropriate for simplifing code Signed-off-by: Zhang Qilong Signed-off-by: Marcel Holtmann

Bluetooth: btmtkuart: Use serdev_device_write_buf() instead of serdev_device_write()

2020-06-01T06:05:07+00:00

serdev_device_write() is not appropriate at here because serdev_device_write_wakeup() is not used to release completion hold by the former at @write_wakeup member of struct serdev_device_ops. Fix by using serdev_device_write_buf() instead of serdev_device_write(). Signed-off-by: Zijun Hu Signed-off-by: Marcel Holtmann