kernel/linux.git/drivers/block/ub.c, branch linux-2.6.16.y

[PATCH] USB: ub oops in block_uevent

2006-05-20T22:00:28+00:00

In kernel 2.6.16, if a mounted storage device is removed, an oops happens because ub supplies an interface device (and kobject) to the block layer, but neglects to pin it. And apparently, the block layer expects its users to pin device structures. The code in ub was broken this way for years. But the bug was exposed only by 2.6.16 when it started to call block_uevent on close, which traverses device structures (kobjects actually). Signed-off-by: Pete Zaitcev Signed-off-by: Greg Kroah-Hartman Signed-off-by: Chris Wright

[PATCH] USB: ub 05 Bulk reset

2006-02-01T01:23:36+00:00

For crying out loud, they have devices which do not like port resets. So, do what usb-storage does and try both bulk and port resets. We start with a port reset (which usb-storage does at the end of transport), then do a Bulk reset, then a port reset again. This seems to work for me. The code is getting dirtier and dirtier here, but I swear that I'll do something about it (see those two new XXX). Honest. Signed-off-by: Pete Zaitcev Signed-off-by: Greg Kroah-Hartman

[PATCH] USB: ub 04 Loss of timer and a hang

2006-02-01T01:23:36+00:00

If SCSI commands are submitted while other commands are still processed, the dispatch loop turns, and we stop the work_timer. Then, if URB fails to complete, ub hangs until the device is unplugged. This does not happen often, becase we only allow one SCSI command per block device, but does happen (on multi-LUN devices, for example). The fix is to stop timer only when we actually going to change the state. The nicest code would be to have the timer stopped in URB callback, but this is impossible, because it can be called from inside a timer, through the urb_unlink. Then we get BUG in timer.c:cascade(). So, we do it a little dirtier. Signed-off-by: Pete Zaitcev Signed-off-by: Greg Kroah-Hartman

[PATCH] USB: ub 03 Oops with CFQ

2006-02-01T01:23:36+00:00

The blk_cleanup_queue does not necesserily destroy the queue. When we destroy the corresponding ub_dev, it may leave the queue spinlock pointer dangling. This patch moves spinlocks from ub_dev to static memory. The locking scheme is not changed. These spinlocks are still separate from the ub_lock. Signed-off-by: Pete Zaitcev Signed-off-by: Greg Kroah-Hartman

[BLOCK] add @uptodate to end_that_request_last() and @error to rq_end_io_fn()

2006-01-06T08:49:03+00:00

add @uptodate argument to end_that_request_last() and @error to rq_end_io_fn(). there's no generic way to pass error code to request completion function, making generic error handling of non-fs request difficult (rq->errors is driver-specific and each driver uses it differently). this patch adds @uptodate to end_that_request_last() and @error to rq_end_io_fn(). for fs requests, this doesn't really matter, so just using the same uptodate argument used in the last call to end_that_request_first() should suffice. imho, this can also help the generic command-carrying request jens is working on. Signed-off-by: tejun heo Signed-Off-By: Jens Axboe

[PATCH] USB: ub 02 Removed unused variable

2006-01-04T21:51:44+00:00

Removed an unused variable Signed-off-by: Daniel Marjamaki Signed-off-by: Pete Zaitcev Signed-off-by: Greg Kroah-Hartman

[PATCH] USB: ub 01 rename

2006-01-04T21:51:43+00:00

Rename misleading UB_MINORS_PER_MAJOR into UB_PARTS_PER_LUN. Signed-off-by: Pete Zaitcev Signed-off-by: Greg Kroah-Hartman

[PATCH] USB: ub 00 implement retries and resets

2006-01-04T21:51:43+00:00

Implement command retries and resets in ub. It is advantageous for users to know if their devices are getting bad. However, failing every I/O is not practical if you have a external USB enclosure with a hard drive. Signed-off-by: Pete Zaitcev Signed-off-by: Greg Kroah-Hartman

[PATCH] USB: remove .owner field from struct usb_driver

2006-01-04T21:48:34+00:00

It is no longer needed, so let's remove it, saving a bit of memory. Signed-off-by: Greg Kroah-Hartman

[PATCH] USB: drivers/usb/storage/libusual

2006-01-04T21:48:31+00:00

This patch adds a shim driver libusual, which routes devices between usb-storage and ub according to the common table, based on unusual_devs.h. The help and example syntax is in Kconfig. Signed-off-by: Pete Zaitcev Signed-off-by: Greg Kroah-Hartman