kernel/linux.git/drivers/block/floppy.c, branch linux-2.6.18.y

[PATCH] exit early in floppy_init when no floppy exists

2006-09-01T18:39:08+00:00

modprobe -v floppy on a Apple G5 writes incorrect stuff to dmesg: Floppy drive(s): fd0 is 2.88M The reason is that the legacy io check happens very late, when part of the floppy stuff is already initialized. check_legacy_ioport() returns either -ENODEV right away, or it walks the device-tree looking for a floppy node. Signed-off-by: Olaf Hering Acked-by: Benjamin Herrenschmidt Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

[PATCH] lockdep: floppy.c irq release fix

2006-07-03T22:27:00+00:00

The lock validator triggered a number of bugs in the floppy driver, all related to the floppy driver allocating and freeing irq and dma resources from interrupt context. The initial solution was to use schedule_work() to push this into process context, but this caused further problems: for example the current floppy driver in -mm2 is totally broken and all floppy commands time out with an error. (as reported by Barry K. Nathan) This patch tries another solution: simply get rid of all that dynamic IRQ and DMA allocation/freeing. I doubt it made much sense back in the heydays of floppies (if two devices raced for DMA or IRQ resources then we didnt handle those cases too gracefully anyway), and today it makes near zero sense. So the new code does the simplest and most straightforward thing: allocate IRQ and DMA resources at module init time, and free them at module removal time. Dont try to release while the driver is operational. This, besides making the floppy driver functional again has an added bonus, floppy IRQ stats are finally persistent and visible in /proc/interrupts: 6: 63 XT-PIC-level floppy Besides normal floppy IO i have also tested IO error handling, motor-off timeouts, etc. - and everything seems to be working fine. Signed-off-by: Ingo Molnar Signed-off-by: Arjan van de Ven Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

[PATCH] devfs: Remove the devfs_fs_kernel.h file from the tree

2006-06-26T19:25:08+00:00

Also fixes up all files that #include it. Signed-off-by: Greg Kroah-Hartman

[PATCH] devfs: Remove devfs_remove() function from the kernel tree

2006-06-26T19:25:07+00:00

Removes the devfs_remove() function and all callers of it. Signed-off-by: Greg Kroah-Hartman

[PATCH] devfs: Remove devfs_mk_bdev() function from the kernel tree

2006-06-26T19:25:06+00:00

Removes the devfs_mk_bdev() function and all callers of it. Signed-off-by: Greg Kroah-Hartman

[PATCH] devfs: Remove devfs_mk_dir() function from the kernel tree

2006-06-26T19:25:06+00:00

Removes the devfs_mk_dir() function and all callers of it. Signed-off-by: Greg Kroah-Hartman

[PATCH] powerpc: Use check_legacy_ioport() on ppc32 too.

2006-04-28T11:04:55+00:00

Some people report that we die on some Macs when we are expecting to catch machine checks after poking at some random I/O address. I'd seen it happen on my dual G4 with serial ports until we fixed those to use OF, but now other users are reporting it with i8042. This expands the use of check_legacy_ioport() to avoid that situation even on 32-bit kernels. Signed-off-by: David Woodhouse Signed-off-by: Paul Mackerras

[PATCH] drivers/block/*: use time_after() and friends

2006-03-28T17:16:06+00:00

They deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi Signed-off-by: Alexey Dobriyan Cc: Jens Axboe Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

[PATCH] drivers/block/floppy.c: dont free_irq() from irq context

2006-03-26T16:56:53+00:00

free_irq() should not be executed from softirq context. Found by the lock validator. The fix is to push fd_free_irq() into keventd. The code validates fine with this patch applied. (akpm: this is revolting, but so is floppy.c) [akpm@osdl.org: added flush_scheduled_work()] Signed-off-by: Ingo Molnar Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

[PATCH] block/floppy: fix section mismatch warnings

2006-03-25T16:22:53+00:00

In latest -mm a number of section mismatch warnings are generated for floppy.o like the following: WARNING: drivers/block/floppy.o - Section mismatch: reference to \ .init.data: from .text between 'init_module' (at offset 0x6976) and \ 'cleanup_module' The warning are caused by a reference to floppy_init() which is __init from init_module() which is not declared __init. Declaring init_module() _init fixes this. Signed-off-by: Sam Ravnborg Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds