Linux kernel stable tree (mirror) https://git.radix-linux.su/kernel/linux.git/atom?h=v6.1.2 2022-09-01T16:17:14+00:00 2022-09-01T16:17:14+00:00 Christophe JAILLET christophe.jaillet@wanadoo.fr 2022-07-20T21:26:36+00:00 urn:sha1:61742a7cd5b194d2cc52d78de8ec6967634a4cd6 If the gfp flag used for the memory allocation already has __GFP_ZERO, then there is no need to explicitly clear the "struct devres_node". It is already zeroed. This saves a few cycles when using devm_zalloc() and co. In the case of devres_alloc() (which calls __devres_alloc_node()), the compiler could remove the test and the memset() because it should be able to see that the __GFP_ZERO flag is set. So this would make the code both faster and smaller. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/d255bd871484e63cdd628e819f929e2df59afb02.1658352383.git.christophe.jaillet@wanadoo.fr Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2022-03-18T13:30:12+00:00 Julia Lawall Julia.Lawall@inria.fr 2022-03-14T11:53:42+00:00 urn:sha1:451fd6ee1adb7ca28277023e450708cb9061edb2 Various spelling mistakes in comments. Detected with the help of Coccinelle. Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> Link: https://lore.kernel.org/r/20220314115354.144023-19-Julia.Lawall@inria.fr Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2021-06-15T15:14:36+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2021-05-17T12:29:46+00:00 urn:sha1:09705dcb63d269000595284b5dd7f5c938d647b9 In some cases the printf() mechanism is too heavy and can't be used. For example, when debugging a race condition involving devres API. When CONFIG_DEBUG_DEVRES is enabled I can't reproduce an issue, and otherwise it's quite visible with a useful information being collected. Enable trace events for devres part of the driver core. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20210517122946.53161-4-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2021-06-15T15:14:36+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2021-05-17T12:29:45+00:00 urn:sha1:a7f1d03b6046cf44f1dd702aeaad3b5e4d7b33a5 If a list of devres nodes is empty, no need to call remove_nodes(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20210517122946.53161-3-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2021-06-15T15:14:36+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2021-05-17T12:29:44+00:00 urn:sha1:c3cd0ff7aa18a60229134fb8e467d5e1d92abec3 The remove_nodes() open codes the list_for_each_safe_from(). Replace it by a generic macro. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20210517122946.53161-2-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2021-06-15T15:14:36+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2021-05-17T12:29:43+00:00 urn:sha1:bbc8f3e79e9e35469ac87b0b3329729afc715885 It seems for the sake of saving stack memory of couple of pointers, the locking in release_nodes() callers becomes interesting. Replace this logic with a straight forward locking and unlocking scheme. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20210517122946.53161-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2021-04-02T15:02:45+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2021-04-01T17:10:42+00:00 urn:sha1:318c3e00f13c2f6e11202a22cc302ea8c70552ea The size_t type has very well established specifier, i.e. "%zu", use it directly instead of casting to unsigned long with "%lu". Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20210401171042.60612-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2021-04-02T15:02:39+00:00 Andy Shevchenko andriy.shevchenko@linux.intel.com 2021-04-01T17:10:30+00:00 urn:sha1:d7aa44f5a1f86cb40659eef06035d8d92604b9d5 Sparse is not happy: drivers/base/devres.c:1230:9: warning: cast removes address space '__percpu' of expression Use __force attribute to make it happy. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20210401171030.60527-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2020-11-09T17:56:49+00:00 Mauro Carvalho Chehab mchehab+huawei@kernel.org 2020-10-23T16:32:56+00:00 urn:sha1:33c0c9bdf7a59051a654cd98b7d2b48ce0080967 class_create is actually defined at the header. Fix the markup there and add a new one at the right place. While here, also fix some markups for functions that have different names between their prototypes and kernel-doc comments. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Link: https://lore.kernel.org/r/2fb6efd6a1f90d69ff73bf579566079cbb051e15.1603469755.git.mchehab+huawei@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2020-09-08T11:32:06+00:00 Bartosz Golaszewski bgolaszewski@baylibre.com 2020-08-24T17:38:57+00:00 urn:sha1:f82485722e5de5ebb08d3a1dd7302203346dbff9 Implement the managed variant of krealloc(). This function works with all memory allocated by devm_kmalloc() (or devres functions using it implicitly like devm_kmemdup(), devm_kstrdup() etc.). Managed realloc'ed chunks can be manually released with devm_kfree(). Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20200824173859.4910-2-brgl@bgdev.pl Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>