kernel/linux.git/drivers/ata/sata_rcar.c, branch v6.3

ata: sata_rcar: Fix compilation warning

2022-10-17T23:01:45+00:00

When compiling with clang and W=1, the following warning is generated: drivers/ata/sata_rcar.c:878:15: error: cast to smaller integer type 'enum sata_rcar_type' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] priv->type = (enum sata_rcar_type)of_device_get_match_data(dev); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fix this by using a cast to unsigned long to match the "void *" type size returned by of_device_get_match_data(). Signed-off-by: Damien Le Moal Reviewed-by: Geert Uytterhoeven Acked-by: Arnd Bergmann Reviewed-by: Sergey Shtylyov

ata: Drop commas after OF match table sentinels

2022-03-07T02:49:10+00:00

It does not make sense to have a comma after a sentinel, as any new elements must be added before the sentinel. Add comments to clarify the purpose of the empty elements. Rewrap entries to a single line to have a consistent style. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergey Shtylyov Acked-by: Florian Fainelli [ahci_brcm] Reviewed-by: Kieran Bingham Reviewed-by: Linus Walleij Signed-off-by: Damien Le Moal

ata: add/use ata_taskfile::{error|status} fields

2022-02-20T00:06:05+00:00

Add the explicit error and status register fields to 'struct ata_taskfile' using the anonymous *union*s ('struct ide_taskfile' had that for ages!) and update the libata taskfile code accordingly. There should be no object code changes resulting from that... Signed-off-by: Sergey Shtylyov Signed-off-by: Damien Le Moal

ata: sata_rcar: drop unused #define's

2022-02-19T02:18:43+00:00

This driver has never used the SH-Navi2G/ATAPI-ATA compatible taskfile registers (the driver uses the taskfile registers in another location anyway), so drop their #define's... Signed-off-by: Sergey Shtylyov Signed-off-by: Damien Le Moal

ata: sata_rcar: make sata_rcar_ata_devchk() return 'bool'

2022-02-19T02:18:43+00:00

sata_rcar_ata_devchk() returns 1 if a device is present, 0 if not -- the 'bool' type clearly fits better here than 'unsigned int'... Signed-off-by: Sergey Shtylyov Signed-off-by: Damien Le Moal

ata: libata: make ata_host_suspend() void

2022-02-19T02:18:35+00:00

ata_host_suspend() always returns 0, so the result checks in many drivers look pointless. Let's make this function return *void* instead of *int*. Found by Linux Verification Center (linuxtesting.org) with the SVACE static analysis tool. Signed-off-by: Sergey Shtylyov Acked-by: Uwe Kleine-König Reviewed-by: Hannes Reinecke Signed-off-by: Damien Le Moal

ata: libata: remove debug compilation switches

2022-01-05T10:33:02+00:00

Unused now, so remove and drop any references to them. Signed-off-by: Hannes Reinecke Signed-off-by: Damien Le Moal

ata: sata_rcar: Drop pointless VPRINTK() calls

2022-01-05T10:33:02+00:00

Signed-off-by: Hannes Reinecke Signed-off-by: Damien Le Moal

ata: sata_rcar: replace DPRINTK() with ata_port_dbg()

2022-01-05T10:33:01+00:00