kernel/linux.git/drivers/ata/libata-acpi.c, branch v6.18.42

ata: libata-acpi: Do not assume 40 wire cable if no devices are enabled

2025-06-10T12:08:24+00:00

On at least an ASRock 990FX Extreme 4 with a VIA VT6330, the devices have not yet been enabled by the first time ata_acpi_cbl_80wire() is called. This means that the ata_for_each_dev loop is never entered, and a 40 wire cable is assumed. The VIA controller on this board does not report the cable in the PCI config space, thus having to fall back to ACPI even though no SATA bridge is present. The _GTM values are correctly reported by the firmware through ACPI, which has already set up faster transfer modes, but due to the above the controller is forced down to a maximum of UDMA/33. Resolve this by modifying ata_acpi_cbl_80wire() to directly return the cable type. First, an unknown cable is assumed which preserves the mode set by the firmware, and then on subsequent calls when the devices have been enabled, an 80 wire cable is correctly detected. Since the function now directly returns the cable type, it is renamed to ata_acpi_cbl_pata_type(). Signed-off-by: Tasos Sahanidis Link: https://lore.kernel.org/r/20250519085945.1399466-1-tasos@tasossah.com Signed-off-by: Niklas Cassel

ata: Fix typos in the comment

2024-10-01T07:22:02+00:00

Correctly spelled comments make it easier for the reader to understand the code. Fix typos: 'multipe' ==> 'multiple', 'Paremeters' ==> 'Parameters', 'recieved' ==> 'received', 'realted' ==> 'related', 'evaulated' ==> 'evaluated', 'programing' ==> 'programming', 'coninue' ==> 'continue'. Signed-off-by: Yan Zhen Reviewed-by: Sergey Shtylyov Link: https://lore.kernel.org/r/20240927060056.221977-1-yanzhen@vivo.com Signed-off-by: Niklas Cassel

ata: make use of ata_port_is_frozen() helper

2022-10-18T04:53:27+00:00

Clean up the code by making use of the newly introduced ata_port_is_frozen() helper function. Signed-off-by: Niklas Cassel Signed-off-by: Damien Le Moal

ata: make transfer mode masks unsigned int

2022-06-17T07:35:02+00:00

The packed transfer mode masks and also the {pio|mwdma|udma}_mask fields of *struct*s ata_device and ata_port_info are declared as *unsigned long* (which is a 64-bit type on 64-bit architectures) but actually the packed masks occupy only 20 bits (7 PIO modes, 5 MWDMA modes, and 8 UDMA modes) and the PIO/MWDMA/UDMA masks easily fit into just 8 bits each, so we can safely use (always 32-bit) *unsigned int* variables instead. This saves 745 bytes of object code in libata-core.o alone, not to mention LLDDs... Signed-off-by: Sergey Shtylyov Signed-off-by: Damien Le Moal

ata: add/use ata_taskfile::{error|status} fields

2022-02-20T00:06:05+00:00

Add the explicit error and status register fields to 'struct ata_taskfile' using the anonymous *union*s ('struct ide_taskfile' had that for ages!) and update the libata taskfile code accordingly. There should be no object code changes resulting from that... Signed-off-by: Sergey Shtylyov Signed-off-by: Damien Le Moal

ata: libata-acpi: kill ata_acpi_on_suspend()

2022-02-02T07:56:49+00:00

Since the commit c05e6ff035c1b25d17364a685432 ("libata-acpi: implement and use ata_acpi_init_gtm()") ata_acpi_on_suspend() just returns 0, so its call from ata_eh_handle_port_suspend() doesn't make sense anymore. Remove the function completely, at last... Found by Linux Verification Center (linuxtesting.org) with the SVACE static analysis tool. Signed-off-by: Sergey Shtylyov Signed-off-by: Damien Le Moal

ata: libata: drop ata_msg_probe()

2022-01-05T10:33:02+00:00

All callsites have been converted to dynamic debugging. Signed-off-by: Hannes Reinecke Signed-off-by: Damien Le Moal

ata: libata: revamp ata_get_cmd_descript()

2022-01-05T10:33:01+00:00

Rename ata_get_cmd_descrip() to ata_get_cmd_name() and simplify it to return "unknown" instead of NULL. Signed-off-by: Hannes Reinecke Signed-off-by: Damien Le Moal

ata: libata: move ata_{port,link,dev}_dbg to standard pr_XXX() macros

2022-01-05T10:33:01+00:00

Use standard pr_{debug,info,notice,warn,err} macros instead of the hand-crafted printk helpers. Signed-off-by: Hannes Reinecke Signed-off-by: Damien Le Moal

ata: libata-acpi: Fix function name and provide description for 'prev_gtf'

2021-03-31T02:21:26+00:00

Fixes the following W=1 kernel build warning(s): drivers/ata/libata-acpi.c:493: warning: expecting prototype for ata_acpi_gtm_xfermode(). Prototype was for ata_acpi_gtm_xfermask() instead drivers/ata/libata-acpi.c:648: warning: Function parameter or member 'prev_gtf' not described in 'ata_acpi_run_tf' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20210318085150.3131936-15-lee.jones@linaro.org Signed-off-by: Jens Axboe

kernel/linux.git/drivers/ata/libata-acpi.c, branch v6.18.42

ata: libata-acpi: Do not assume 40 wire cable if no devices are enabled

ata: Fix typos in the comment

ata: make use of ata_port_is_frozen() helper

ata: make transfer mode masks *unsigned int*

ata: add/use ata_taskfile::{error|status} fields

ata: libata-acpi: kill ata_acpi_on_suspend()

ata: libata: drop ata_msg_probe()

ata: libata: revamp ata_get_cmd_descript()

ata: libata: move ata_{port,link,dev}_dbg to standard pr_XXX() macros

ata: libata-acpi: Fix function name and provide description for 'prev_gtf'

ata: make transfer mode masks unsigned int