kernel/linux.git/drivers/ata/libahci_platform.c, branch v4.19.16

ata: libahci_platform: add reset control support

2018-08-22T15:08:27+00:00

Add support to get and control a list of resets for the device as optional and shared. These resets must be kept de-asserted until the device is enabled. This is specified as shared because some SoCs like UniPhier series have common reset controls with all ahci controller instances. However, according to Thierry's view, https://www.spinics.net/lists/linux-ide/msg55357.html some hardware-specific drivers already use their own resets, and the common reset make a path to occur double controls of resets. The ahci_platform_get_resources() can get and control the reset only when the second argument includes AHCI_PLATFORM_GET_RESETS bit. Suggested-by: Hans de Goede Cc: Thierry Reding Signed-off-by: Kunihiko Hayashi Reviewed-by: Hans de Goede Signed-off-by: Tejun Heo

ata: add an extra argument to ahci_platform_get_resources()

2018-08-22T15:08:27+00:00

Add an extra argument to ahci_platform_get_resources(), that is for the bitmap representing the resource to get in this function. Currently there is no resources to be defined, so all the callers set '0' to the argument. Suggested-by: Hans de Goede Cc: Thierry Reding Cc: Matthias Brugger Cc: Patrice Chotard Cc: Maxime Ripard Signed-off-by: Kunihiko Hayashi Reviewed-by: Hans de Goede Signed-off-by: Tejun Heo

Revert "ata: ahci_platform: allow disabling of hotplug to save power"

2018-08-06T17:22:35+00:00

This reverts commit aece27a2f01be4bb7683790f69cd1bed3a0929a2. Causes boot failure on some devices. http://lore.kernel.org/r/CA+G9fYuKW_jCFZPqG4tz=QY9ROfHO38KiCp9XTA+KaDOFVtcqQ@mail.gmail.com Signed-off-by: Tejun Heo

Revert "ata: ahci_platform: convert kcalloc to devm_kcalloc"

2018-07-24T16:44:24+00:00

Since ahci_platform_put_resources() use target_pwrs after "devm_" freed it, we cannot use devm_kcalloc for allocating target_pwrs. This reverts commit bd0038b1b4f499d814d8f33a55b1df5ea6cf3b85. Reported-and-reviwed-by: Mikko Perttunen Tested-by: Marcel Ziswiler Tested-by: Jon Hunter Signed-off-by: Corentin Labbe Signed-off-by: Tejun Heo

ata: ahci_platform: convert kcalloc to devm_kcalloc

2018-07-12T20:02:39+00:00

Like phys, target_pwrs could be allocated with devm_ function Signed-off-by: Corentin Labbe Reviewed-by: Hans de Goede Signed-off-by: Tejun Heo

ata: ahci_platform: convert kzallloc to kcalloc

2018-07-12T20:02:39+00:00

It's better to kcalloc instead of kzalloc(n * sizeof()) Signed-off-by: Corentin Labbe Reviewed-by: Hans de Goede Signed-off-by: Tejun Heo

ata: ahci_platform: correct parameter documentation for ahci_platform_shutdown

2018-07-12T20:02:38+00:00

The documentation about parameter for ahci_platform_shutdown has a typo. This fix the following build warning: drivers/ata/libahci_platform.c:693: warning: Function parameter or member 'pdev' not described in 'ahci_platform_shutdown' drivers/ata/libahci_platform.c:693: warning: Excess function parameter 'dev' description in 'ahci_platform_shutdow Signed-off-by: Corentin Labbe Reviewed-by: Hans de Goede Signed-off-by: Tejun Heo

ata: ahci_platform: allow disabling of hotplug to save power

2018-06-18T17:58:55+00:00

A number of resources remain powered to support hotplug. On platforms I've worked with, allowing the ahci_platform to suspend saves about 150mW. This patch enables rpm and allows the device to be auto-suspended through sysfs. Signed-off-by: Samuel Morris Signed-off-by: Tejun Heo

Revert "ata: ahci-platform: add reset control support"

2018-04-09T22:10:50+00:00

This reverts commit f0f56716fc3e5d547fd7811eb218a30ed0695605. According to Thierry's view, https://www.spinics.net/lists/linux-ide/msg55357.html some hardware-specific drivers already use their own resets, and the common reset might make a path to occur double controls of resets. For now, revert the commit that adds reset control support to ahci-platform, and hold until the solution is confirmed not be affect all hardware-specific drivers. Fixes: f0f56716fc3e ("ata: ahci-platform: add reset control support") Reported-by: Thierry Reding Suggested-by: Hans de Goede Acked-by: Hans de Goede Signed-off-by: Kunihiko Hayashi Signed-off-by: Tejun Heo

ata: ahci-platform: add reset control support

2018-03-26T14:40:01+00:00