kernel/linux.git/drivers/acpi/pmic, branch v6.12.80Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.12.802024-08-02T15:05:08+00:00ACPI: PMIC: Remove unneeded check in tps68470_pmic_opregion_probe()2024-08-02T15:05:08+00:00Aleksandr Mishinamishin@t-argos.ru2024-07-30T22:53:39+00:00urn:sha1:07442c46abad1d50ac82af5e0f9c5de2732c4592
In tps68470_pmic_opregion_probe() pointer 'dev' is compared to NULL which
is useless.
Fix this issue by removing unneeded check.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: e13452ac3790 ("ACPI / PMIC: Add TI PMIC TPS68470 operation region driver")
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://patch.msgid.link/20240730225339.13165-1-amishin@t-argos.ru
[ rjw: Subject edit ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
ACPI: PMIC: Constify struct pmic_table2024-07-01T18:06:02+00:00Christophe JAILLETchristophe.jaillet@wanadoo.fr2024-06-29T06:58:42+00:00urn:sha1:cfff1997aafa25ea98c2ceb7251642276745266a
'struct pmic_table' is not modified in these drivers.
Constifying this structure moves some data to a read-only section, so
increase overall security.
On a x86_64, with allmodconfig, as an example:
Before:
======
text data bss dec hex filename
3811 786 0 4597 11f5 drivers/acpi/pmic/intel_pmic_xpower.o
text data bss dec hex filename
4147 450 0 4597 11f5 drivers/acpi/pmic/intel_pmic_xpower.o
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://patch.msgid.link/a6c9b1bcdf259adabbcaf91183d3f5ab87a98600.1719644292.git.christophe.jaillet@wanadoo.fr
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
ACPI: PMIC: Replace open coded be16_to_cpu()2024-06-13T19:23:05+00:00Andy Shevchenkoandriy.shevchenko@linux.intel.com2024-06-06T20:54:16+00:00urn:sha1:f42cfd5ceced62799a7dd82899b03d7b9575fc22
It's easier to understand the nature of a data type when
it's written explicitly. With that, replace open coded
endianess conversion.
As a side effect it fixes the returned value of
intel_crc_pmic_update_aux() since ACPI PMIC core code
expects negative or zero and never uses positive one.
While at it, use macros from bits.h to reduce a room for mistake.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
ACPI: PMIC: Convert pr_*() to dev_*() printing macros2024-06-13T19:22:59+00:00Andy Shevchenkoandriy.shevchenko@linux.intel.com2024-06-06T20:54:15+00:00urn:sha1:1dd804af345a126594a8b8e80510590b5775073b
Since we have a device pointer in the regmap, use it for
error messages.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
ACPI: PMIC: Use sizeof() instead of hard coded value2024-06-13T19:22:49+00:00Andy Shevchenkoandriy.shevchenko@linux.intel.com2024-06-06T20:54:14+00:00urn:sha1:58e04f315295ea3637a119686bb2e3ee6cef1f04
It's better to use sizeof() of a given buffer than spreading
a hard coded value.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
ACPI: PMIC: Add comments with DSDT power opregion field names2023-01-30T15:47:13+00:00Hans de Goedehdegoede@redhat.com2023-01-25T11:38:11+00:00urn:sha1:7de6c3fb6dfbf9b920caa8cad953d8ac406f6790
The DSDTs of CHT devices using the Dollar Cove TI PMIC, all use
LDO1 - LDO14 names for the DSDT power opregion field names.
Add comments with these fields to make it easier to see which PMIC
registers are being set by ACPI code using these.
Note that LDO4 is missing and the mapped registers jump from 0x43
to 0x45 to match. This matches with how the fields are declared
in the DSDT where LDO4 is skipped too. Note there is no hole in
the field addresses, LDO4 is simply just not defined on either side.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
ACPI: PMIC: Add pmic_i2c_address to BYT Crystal Cove support2022-12-30T17:46:55+00:00Hans de Goedehdegoede@redhat.com2022-12-13T12:34:54+00:00urn:sha1:73d15a7c13bfe1292db85ed3de8dfa711291819d
Add a pmic_i2c_address entry to intel_pmic_bytcrc.c, so that
intel_soc_pmic_exec_mipi_pmic_seq_element() can be used on
devices with a Bay Trail Crystal Cove PMIC OpRegion driver.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
ACPI: PMIC: xpower: Fix _TMP ACPI errors2021-12-08T14:34:57+00:00Hans de Goedehdegoede@redhat.com2021-11-26T15:21:09+00:00urn:sha1:5f96ba56552121f4297874d0accf29b9b4a1ae93
On some devices with a X-Powers AXP288 PMIC the LPAT tables in the ACPI
node for the AXP288 PMIC for some reason only describe a small temperature
range, e.g. 27° - 37° Celcius (assuming the entries are in millidegrees).
When the tablet is idle in a room at 21° degrees this is causing values
outside the LPAT table to be read, causing e.g. the following 2 errors
to get spammed to the logs every 4 seconds! :
[ 7512.791316] ACPI Error: AE_ERROR, Returned by Handler for [UserDefinedRegion] (20210930/evregion-281)
[ 7512.791611] ACPI Error: Aborting method \_SB.SXP1._TMP due to previous error (AE_ERROR) (20210930/psparse-529)
Fix this by clamping the raw value to the LPAT table range before
passing it to acpi_lpat_raw_to_temp().
Note clamping has been chosen rather then extrapolating because it is
unknown how other parts of the ACPI tables will respond to temperature
values outside of the LPAT range.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
ACPI: PMIC: allow drivers to provide a custom lpat_raw_to_temp() function2021-12-08T14:34:57+00:00Hans de Goedehdegoede@redhat.com2021-11-26T15:21:08+00:00urn:sha1:c5200609c9176482ea96ac73e52bd466b622f385
The LPAT tables used in the DSDT for some PMICs require special handling,
allow the PMIC OpRegion drivers to provide an alternative implementation
by adding a lpat_raw_to_temp function pointer to struct pmic_table;
and initialize this to the default acpi_lpat_raw_to_temp function
for all PMICs.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
ACPI: PMIC: constify all struct intel_pmic_opregion_data declarations2021-12-08T14:34:57+00:00Hans de Goedehdegoede@redhat.com2021-11-26T15:21:07+00:00urn:sha1:e172e650eda3274964df3a74cf12d210eae9a044
The struct intel_pmic_opregion_data declarations never change,
constify them all.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>