kernel/linux.git/crypto/ecdh.c, branch v6.6.131

crypto: ecdh - explicitly zeroize private_key

2024-07-05T07:33:52+00:00

[ Upstream commit 73e5984e540a76a2ee1868b91590c922da8c24c9 ] private_key is overwritten with the key parameter passed in by the caller (if present), or alternatively a newly generated private key. However, it is possible that the caller provides a key (or the newly generated key) which is shorter than the previous key. In that scenario, some key material from the previous key would not be overwritten. The easiest solution is to explicitly zeroize the entire private_key array first. Note that this patch slightly changes the behavior of this function: previously, if the ecc_gen_privkey failed, the old private_key would remain. Now, the private_key is always zeroized. This behavior is consistent with the case where params.key is set and ecc_is_key_valid fails. Signed-off-by: Joachim Vandersmissen Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin

crypto: add init/exit annotations to init/exit funcs

2022-09-24T08:14:43+00:00

Add missing __init/__exit annotations to init/exit funcs. Signed-off-by: Xiu Jianfeng Signed-off-by: Herbert Xu

crypto: ecc - Move ecc.h to include/crypto/internal

2021-10-29T13:04:03+00:00

Move ecc.h header file to 'include/crypto/internal' so that it can be easily imported from everywhere in the kernel tree. This change is done to allow crypto device drivers to re-use the symbols exported by 'crypto/ecc.c', thus avoiding code duplication. Signed-off-by: Daniele Alessandrelli Signed-off-by: Herbert Xu

crypto: ecdh - register NIST P384 tfm

2021-05-28T07:11:47+00:00

Add ecdh_nist_p384_init_tfm and register and unregister P384 tfm. Signed-off-by: Hui Tang Signed-off-by: Herbert Xu

crypto: ecdh - fix 'ecdh_init'

2021-05-28T07:11:47+00:00

NIST P192 is not unregistered if failed to register NIST P256, actually it need to unregister the algorithms already registered. Signed-off-by: Hui Tang Signed-off-by: Herbert Xu

crypto: ecdh - fix ecdh-nist-p192's entry in testmgr

2021-05-28T07:11:47+00:00

Add a comment that p192 will fail to register in FIPS mode. Fix ecdh-nist-p192's entry in testmgr by removing the ifdefs and not setting fips_allowed. Signed-off-by: Hui Tang Signed-off-by: Herbert Xu

crypto: ecdh - extend 'cra_driver_name' with curve name

2021-05-21T08:17:29+00:00

Currently, 'cra_driver_name' cannot be used to specify ecdh algorithm with a special curve, so extending it with curve name. Although using 'cra_name' can also specify a special curve, but ecdh generic driver cannot be specified when vendor hardware accelerator has registered. Fixes: 6763f5ea2d9a ("crypto: ecdh - move curve_id of ECDH from ...") Signed-off-by: Hui Tang Signed-off-by: Herbert Xu

crypto: ecdh - move curve_id of ECDH from the key to algorithm name

2021-03-12T13:04:03+00:00

1. crypto and crypto/atmel-ecc: Move curve id of ECDH from the key into the algorithm name instead in crypto and atmel-ecc, so ECDH algorithm name change form 'ecdh' to 'ecdh-nist-pxxx', and we cannot use 'curve_id' in 'struct ecdh'; 2. crypto/testmgr and net/bluetooth: Modify 'testmgr.c', 'testmgr.h' and 'net/bluetooth' to adapt the modification. Signed-off-by: Meng Yu Reviewed-by: Zaibo Xu Reported-by: kernel test robot Signed-off-by: Herbert Xu

crypto: ecdh - avoid buffer overflow in ecdh_set_secret()

2021-01-02T21:35:35+00:00

Pavel reports that commit 17858b140bf4 ("crypto: ecdh - avoid unaligned accesses in ecdh_set_secret()") fixes one problem but introduces another: the unconditional memcpy() introduced by that commit may overflow the target buffer if the source data is invalid, which could be the result of intentional tampering. So check params.key_size explicitly against the size of the target buffer before validating the key further. Fixes: 17858b140bf4 ("crypto: ecdh - avoid unaligned accesses in ecdh_set_secret()") Reported-by: Pavel Machek Cc: Signed-off-by: Ard Biesheuvel Signed-off-by: Herbert Xu

crypto: ecdh - avoid unaligned accesses in ecdh_set_secret()

2020-12-04T07:13:13+00:00

ecdh_set_secret() casts a void* pointer to a const u64* in order to feed it into ecc_is_key_valid(). This is not generally permitted by the C standard, and leads to actual misalignment faults on ARMv6 cores. In some cases, these are fixed up in software, but this still leads to performance hits that are entirely avoidable. So let's copy the key into the ctx buffer first, which we will do anyway in the common case, and which guarantees correct alignment. Cc: Signed-off-by: Ard Biesheuvel Signed-off-by: Herbert Xu

kernel/linux.git/crypto/ecdh.c, branch v6.6.131

crypto: ecdh - explicitly zeroize private_key

crypto: add __init/__exit annotations to init/exit funcs

crypto: ecc - Move ecc.h to include/crypto/internal

crypto: ecdh - register NIST P384 tfm

crypto: ecdh - fix 'ecdh_init'

crypto: ecdh - fix ecdh-nist-p192's entry in testmgr

crypto: ecdh - extend 'cra_driver_name' with curve name

crypto: ecdh - move curve_id of ECDH from the key to algorithm name

crypto: ecdh - avoid buffer overflow in ecdh_set_secret()

crypto: ecdh - avoid unaligned accesses in ecdh_set_secret()

crypto: add init/exit annotations to init/exit funcs