kernel/linux.git/crypto/crypto_engine.c, branch v6.12.80

crypto: engine - Make crypto_engine_exit() return void

2023-10-01T08:28:15+00:00

All callers ignore the return value, so simplify by not providing one. Note that crypto_engine_exit() is typically called in a device driver's remove path (or the error path in probe), where errors cannot be handled anyhow. Signed-off-by: Uwe Kleine-König Signed-off-by: Herbert Xu

crypto: engine - Remove crypto_engine_ctx

2023-08-18T09:01:11+00:00

Remove the obsolete crypto_engine_ctx structure. Signed-off-by: Herbert Xu

crypto: engine - Move crypto_engine_ops from request into crypto_alg

2023-08-18T09:01:10+00:00

Rather than having the callback in the request, move it into the crypto_alg object. This avoids having crypto_engine look into the request context is private to the driver. Signed-off-by: Herbert Xu

crypto: engine - Create internal/engine.h

2023-08-18T09:01:10+00:00

Create crypto/internal/engine.h to house details that should not be used by drivers. It is empty for the time being. Signed-off-by: Herbert Xu

crypto: engine - Move crypto inclusions out of header file

2023-08-18T09:01:10+00:00

The engine file does not need the actual crypto type definitions so move those header inclusions to where they are actually used. Signed-off-by: Herbert Xu

crypto: engine - Remove prepare/unprepare request

2023-08-18T09:01:10+00:00

The callbacks for prepare and unprepare request in crypto_engine is superfluous. They can be done directly from do_one_request. Move the code into do_one_request and remove the unused callbacks. Signed-off-by: Herbert Xu

crypto: engine - fix crypto_queue backlog handling

2023-04-28T09:50:43+00:00

CRYPTO_TFM_REQ_MAY_BACKLOG tells the crypto driver that it should internally backlog requests until the crypto hw's queue becomes full. At that point, crypto_engine backlogs the request and returns -EBUSY. Calling driver such as dm-crypt then waits until the complete() function is called with a status of -EINPROGRESS before sending a new request. The problem lies in the call to complete() with a value of -EINPROGRESS that is made when a backlog item is present on the queue. The call is done before the successful execution of the crypto request. In the case that do_one_request() returns < 0 and the retry support is available, the request is put back in the queue. This leads upper drivers to send a new request even if the queue is still full. The problem can be reproduced by doing a large dd into a crypto dm-crypt device. This is pretty easy to see when using Freescale CAAM crypto driver and SWIOTLB dma. Since the actual amount of requests that can be hold in the queue is unlimited we get IOs error and dma allocation. The fix is to call complete with a value of -EINPROGRESS only if the request is not enqueued back in crypto_queue. This is done by calling complete() later in the code. In order to delay the decision, crypto_queue is modified to correctly set the backlog pointer when a request is enqueued back. Fixes: 6a89f492f8e5 ("crypto: engine - support for parallel requests based on retry mechanism") Co-developed-by: Sylvain Ouellet Signed-off-by: Sylvain Ouellet Signed-off-by: Olivier Bacon Signed-off-by: Herbert Xu

crypto: engine - Use crypto_request_complete

2023-02-13T10:34:49+00:00

Use the crypto_request_complete helper instead of calling the completion function directly. Signed-off-by: Herbert Xu

crypto: engine - Fix excess parameter doc warning

2023-01-27T10:58:09+00:00

The engine parameter should not be marked for kernel doc as it triggers a warning. Signed-off-by: Herbert Xu

crypto: engine - Add parameter description in crypto_transfer_request() kernel-doc comment

2022-04-08T08:13:30+00:00

Add the description of @need_pump in crypto_transfer_request() kernel-doc comment to remove warning found by running scripts/kernel-doc, which is caused by using 'make W=1'. crypto/crypto_engine.c:260: warning: Function parameter or member 'need_pump' not described in 'crypto_transfer_request' Reported-by: Abaci Robot Signed-off-by: Yang Li Signed-off-by: Herbert Xu