kernel/linux.git/arch/parisc/net, branch v6.12.80Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.12.802024-07-29T14:19:07+00:00parisc: fix unaligned accesses in BPF2024-07-29T14:19:07+00:00Mikulas Patockampatocka@redhat.com2024-07-27T10:11:02+00:00urn:sha1:1fd2c10acb7b35d72101a4619ee5b2cddb9efd3a
There were spurious unaligned access warnings when calling BPF code.
Sometimes, the warnings were triggered with any incoming packet, making
the machine hard to use.
The reason for the warnings is this: on parisc64, pointers to functions
are not really pointers to functions, they are pointers to 16-byte
descriptor. The first 8 bytes of the descriptor is a pointer to the
function and the next 8 bytes of the descriptor is the content of the
"dp" register. This descriptor is generated in the function
bpf_jit_build_prologue.
The problem is that the function bpf_int_jit_compile advertises 4-byte
alignment when calling bpf_jit_binary_alloc, bpf_jit_binary_alloc
randomizes the returned array and if the array happens to be not aligned
on 8-byte boundary, the descriptor generated in bpf_jit_build_prologue is
also not aligned and this triggers the unaligned access warning.
Fix this by advertising 8-byte alignment on parisc64 when calling
bpf_jit_binary_alloc.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Helge Deller <deller@gmx.de>
bpf: Take return from set_memory_rox() into account with bpf_jit_binary_lock_ro()2024-03-15T02:28:52+00:00Christophe Leroychristophe.leroy@csgroup.eu2024-03-08T05:38:08+00:00urn:sha1:e60adf513275c3a38e5cb67f7fd12387e43a3ff5
set_memory_rox() can fail, leaving memory unprotected.
Check return and bail out when bpf_jit_binary_lock_ro() returns
an error.
Link: https://github.com/KSPP/linux/issues/7
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linux-hardening@vger.kernel.org <linux-hardening@vger.kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Puranjay Mohan <puranjay12@gmail.com>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com> # s390x
Acked-by: Tiezhu Yang <yangtiezhu@loongson.cn> # LoongArch
Reviewed-by: Johan Almbladh <johan.almbladh@anyfinetworks.com> # MIPS Part
Message-ID: <036b6393f23a2032ce75a1c92220b2afcb798d5d.1709850515.git.christophe.leroy@csgroup.eu>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
parisc: Add eBPF JIT compiler glue code and Makefile2023-08-22T08:24:47+00:00Helge Dellerdeller@gmx.de2023-08-17T21:45:00+00:00urn:sha1:22de5d626231b9439a92b030fc8c87603739c2d1
Signed-off-by: Helge Deller <deller@gmx.de>
parisc: Add 64-bit eBPF JIT compiler2023-08-22T08:24:46+00:00Helge Dellerdeller@gmx.de2023-08-17T21:44:59+00:00urn:sha1:c95e269773b31a93515e201fc4bce02d491216c2
Signed-off-by: Helge Deller <deller@gmx.de>
parisc: Add 32-bit eBPF JIT compiler2023-08-22T08:24:46+00:00Helge Dellerdeller@gmx.de2023-08-17T21:44:58+00:00urn:sha1:ceb0e7267693d3e6c43bd65695cd79d7c072a42a
Signed-off-by: Helge Deller <deller@gmx.de>