From 9172a3da2010082a6c134fa5cade5cb133aae60d Mon Sep 17 00:00:00 2001 From: jmestwa-coder Date: Tue, 16 Jun 2026 23:07:21 +0530 Subject: guard empty symbol in code39 check digit handling (#2092) --- .../google/zxing/oned/Code39ExtendedModeTestCase.java | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'core/src/test/java') diff --git a/core/src/test/java/com/google/zxing/oned/Code39ExtendedModeTestCase.java b/core/src/test/java/com/google/zxing/oned/Code39ExtendedModeTestCase.java index 2433c781f..f6d9abed5 100644 --- a/core/src/test/java/com/google/zxing/oned/Code39ExtendedModeTestCase.java +++ b/core/src/test/java/com/google/zxing/oned/Code39ExtendedModeTestCase.java @@ -64,6 +64,24 @@ public final class Code39ExtendedModeTestCase extends Assert { } } + @Test + public void testRejectsEmptySymbolWithCheckDigit() throws FormatException, ChecksumException { + // The asterisk (0x094) start/stop pattern as wide/narrow modules. A symbol that is just the + // start and stop asterisks decodes to an empty payload, so there is no character to validate + // as a check digit. It must fail with a ReaderException, not read result.charAt(-1). + String asterisk = "100101101101"; + BitMatrix matrix = BitMatrix.parse("0000" + asterisk + '0' + asterisk + "0000", "1", "0"); + BitArray row = new BitArray(matrix.getWidth()); + matrix.getRow(0, row); + Code39Reader sut = new Code39Reader(true, false); + try { + sut.decodeRow(0, row, null); + fail("Expected NotFoundException for empty check-digit symbol"); + } catch (NotFoundException expected) { + // expected + } + } + private static void doTest(String expectedResult, String encodedResult) throws FormatException, ChecksumException, NotFoundException { Code39Reader sut = new Code39Reader(false, true); -- cgit v1.2.3