From 77695f4da3dc8eedb6fc7fc67f91ef6ccd22daee Mon Sep 17 00:00:00 2001 From: Liming Gao Date: Wed, 27 Jun 2018 21:14:00 +0800 Subject: SourceLevelDebugPkg: Clean up source files 1. Do not use tab characters 2. No trailing white space in one line 3. All files must end with CRLF Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Reviewed-by: Hao Wu --- .../DebugAgent/DebugAgentCommon/DebugAgent.c | 10 +++--- .../DebugAgent/DebugAgentCommon/DebugAgent.h | 40 +++++++++++----------- .../Library/DebugAgent/DebugAgentCommon/DebugMp.c | 4 +-- .../Library/DebugAgent/DebugAgentCommon/DebugMp.h | 12 +++---- .../DebugAgentCommon/Ia32/ArchDebugSupport.c | 12 +++---- .../DebugAgent/DebugAgentCommon/Ia32/AsmFuncs.S | 20 +++++------ .../DebugAgentCommon/X64/ArchDebugSupport.c | 10 +++--- 7 files changed, 54 insertions(+), 54 deletions(-) (limited to 'SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon') diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c index 0a021307dc..0db33e66aa 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c @@ -383,9 +383,9 @@ DebugAgentReadBuffer ( UINT32 TimerRound; UINT32 TimerFrequency; UINT32 TimerCycle; - + Begin = 0; - TimeoutTicker = 0; + TimeoutTicker = 0; TimerRound = 0; TimerFrequency = GetMailboxPointer()->DebugTimerFrequency; TimerCycle = GetApicTimerInitCount (); @@ -405,7 +405,7 @@ DebugAgentReadBuffer ( while (Index < NumberOfBytes) { if (DebugPortPollBuffer (Handle)) { DebugPortReadBuffer (Handle, Buffer + Index, 1, 0); - Index ++; + Index ++; continue; } if (Timeout != 0) { @@ -652,7 +652,7 @@ ReadRemainingBreakPacket ( if (IS_REQUEST (DebugHeader)) { if (DebugHeader->SequenceNo == (UINT8) (Mailbox->HostSequenceNo + 1)) { // - // Only updagte HostSequenceNo for new command packet + // Only updagte HostSequenceNo for new command packet // UpdateMailboxContent (Mailbox, DEBUG_MAILBOX_HOST_SEQUENCE_NO_INDEX, DebugHeader->SequenceNo); return EFI_SUCCESS; @@ -1476,7 +1476,7 @@ CompressData ( if (Send) { DebugPortWriteBuffer (Handle, &LastChar, 1); } - + } else if (LastCharCount >= 2) { CompressedIndex += 3; LastCharCount -= 2; diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.h b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.h index e09ead9cf0..8b207445b0 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.h +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.h @@ -1,7 +1,7 @@ /** @file Command header of for Debug Agent library instance. - Copyright (c) 2010 - 2016, Intel Corporation. All rights reserved.
+ Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -126,7 +126,7 @@ typedef union { // UINT32 BreakOnNextSmi : 1; // 1: Break on next SMI UINT32 PrintErrorLevel : 4; // Bitmask of print error level for debug message - UINT32 BreakOnBootScript : 1; // 1: Break before executing boot script + UINT32 BreakOnBootScript : 1; // 1: Break before executing boot script UINT32 Reserved2 : 26; } Bits; UINT64 Uint64; @@ -285,7 +285,7 @@ DebugReadBreakSymbol ( @param[in] ErrorLevel The error level of the debug message. @param[in] Format Format string for the debug message to print. - @param[in] ... Variable argument list whose contents are accessed + @param[in] ... Variable argument list whose contents are accessed based on the format string specified by Format. **/ @@ -322,13 +322,13 @@ MultiProcessorDebugSupport ( /** Find and report module image info to HOST. - + @param[in] AlignSize Image aligned size. - + **/ -VOID +VOID FindAndReportModuleImageInfo ( - IN UINTN AlignSize + IN UINTN AlignSize ); /** @@ -338,7 +338,7 @@ FindAndReportModuleImageInfo ( @retval FALSE IDT entries were not setup by Debug Agent. **/ -BOOLEAN +BOOLEAN IsDebugAgentInitialzed ( VOID ); @@ -362,7 +362,7 @@ UpdateMailboxChecksum ( @param[in] Mailbox Debug Agent Mailbox pointer. **/ -VOID +VOID VerifyMailboxChecksum ( IN DEBUG_AGENT_MAILBOX *Mailbox ); @@ -374,17 +374,17 @@ VerifyMailboxChecksum ( @param[in] FlagValue Debug flag value. **/ -VOID +VOID SetDebugFlag ( IN UINT64 FlagMask, - IN UINT32 FlagValue + IN UINT32 FlagValue ); /** Get debug flag in mailbox. @param[in] FlagMask Debug flag mask value. - + @return Debug flag value. **/ @@ -399,10 +399,10 @@ GetDebugFlag ( @param[in] Mailbox Debug Agent Mailbox pointer. @param[in] Index Mailbox content index. @param[in] Value Value to be set into mail box. - + **/ VOID -UpdateMailboxContent ( +UpdateMailboxContent ( IN DEBUG_AGENT_MAILBOX *Mailbox, IN UINTN Index, IN UINT64 Value @@ -412,7 +412,7 @@ UpdateMailboxContent ( Retrieve exception handler from IDT table by ExceptionNum. @param[in] ExceptionNum Exception number - + @return Exception handler **/ @@ -425,7 +425,7 @@ GetExceptionHandlerInIdtEntry ( Set exception handler in IDT table by ExceptionNum. @param[in] ExceptionNum Exception number - @param[in] ExceptionHandler Exception Handler to be set + @param[in] ExceptionHandler Exception Handler to be set **/ VOID @@ -437,15 +437,15 @@ SetExceptionHandlerInIdtEntry ( /** Prints a debug message to the debug output device if the specified error level is enabled. - If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib function - GetDebugPrintErrorLevel (), then print the message specified by Format and the + If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib function + GetDebugPrintErrorLevel (), then print the message specified by Format and the associated variable argument list to the debug output device. If Format is NULL, then ASSERT(). @param[in] ErrorLevel The error level of the debug message. @param[in] IsSend Flag of debug message to declare that the data is being sent or being received. - @param[in] Data Variable argument list whose contents are accessed + @param[in] Data Variable argument list whose contents are accessed @param[in] Length based on the format string specified by Format. **/ @@ -455,7 +455,7 @@ DebugAgentDataMsgPrint ( IN UINT8 ErrorLevel, IN BOOLEAN IsSend, IN UINT8 *Data, - IN UINT8 Length + IN UINT8 Length ); /** diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c index e3ed08db49..9d048d89c9 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c @@ -142,10 +142,10 @@ DebugAgentIsBsp ( ) { MSR_IA32_APIC_BASE_REGISTER MsrApicBase; - + // // If there are less than 2 CPUs detected, then the currently executing CPU - // must be the BSP. This avoids an access to an MSR that may not be supported + // must be the BSP. This avoids an access to an MSR that may not be supported // on single core CPUs. // if (mDebugCpuData.CpuCount < 2) { diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h index f0cb3f6c1d..d8afefe56e 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h @@ -189,7 +189,7 @@ UINT32 FindNextPendingBreakCpu ( VOID ); - + /** Check if all processors are in running status. @@ -205,18 +205,18 @@ IsAllCpuRunning ( /** Check if the current processor is the first breaking processor. - If yes, halt other processors. - + If yes, halt other processors. + @param[in] ProcessorIndex Processor index value. - + @return TRUE This processor is the first breaking processor. @return FALSE This processor is not the first breaking processor. - + **/ BOOLEAN IsFirstBreakProcessor ( IN UINT32 ProcessorIndex ); - + #endif diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebugSupport.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebugSupport.c index 1aef63f206..1ecde2d4cc 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebugSupport.c +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/ArchDebugSupport.c @@ -1,7 +1,7 @@ /** @file Supporting functions for IA32 architecture. - Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.
+ Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -58,9 +58,9 @@ InitializeDebugIdt ( IdtEntry[DEBUG_TIMER_VECTOR].Bits.OffsetHigh = (UINT16)((UINTN)InterruptHandler >> 16); IdtEntry[DEBUG_TIMER_VECTOR].Bits.Selector = CodeSegment; IdtEntry[DEBUG_TIMER_VECTOR].Bits.GateType = IA32_IDT_GATE_TYPE_INTERRUPT_32; - + // - // If the CPU supports Debug Extensions(CPUID:01 EDX:BIT2), then + // If the CPU supports Debug Extensions(CPUID:01 EDX:BIT2), then // Set DE flag in CR4 to enable IO breakpoint // AsmCpuid (1, NULL, NULL, NULL, &RegEdx); @@ -73,7 +73,7 @@ InitializeDebugIdt ( Retrieve exception handler from IDT table by ExceptionNum. @param[in] ExceptionNum Exception number - + @return Exception handler **/ @@ -90,13 +90,13 @@ GetExceptionHandlerInIdtEntry ( return (VOID *) (((UINTN)IdtEntry[ExceptionNum].Bits.OffsetLow) | (((UINTN)IdtEntry[ExceptionNum].Bits.OffsetHigh) << 16)); -} +} /** Set exception handler in IDT table by ExceptionNum. @param[in] ExceptionNum Exception number - @param[in] ExceptionHandler Exception Handler to be set + @param[in] ExceptionHandler Exception Handler to be set **/ VOID diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmFuncs.S b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmFuncs.S index a6a3da6a6b..30d279e80d 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmFuncs.S +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Ia32/AsmFuncs.S @@ -1,6 +1,6 @@ #------------------------------------------------------------------------------ # -# Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.
+# Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
# This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License # which accompanies this distribution. The full text of the license may be found at @@ -235,21 +235,21 @@ NoExtrPush: ## insure FXSAVE/FXRSTOR is enabled in CR4... ## ... while we're at it, make sure DE is also enabled... mov $1, %eax - pushl %ebx # temporarily save value of ebx on stack - cpuid # use CPUID to determine if FXSAVE/FXRESTOR + pushl %ebx # temporarily save value of ebx on stack + cpuid # use CPUID to determine if FXSAVE/FXRESTOR # and DE are supported popl %ebx # retore value of ebx that was overwritten - # by CPUID + # by CPUID movl %cr4, %eax pushl %eax # push cr4 firstly testl $BIT24, %edx # Test for FXSAVE/FXRESTOR support jz L1 orl $BIT9, %eax # Set CR4.OSFXSR -L1: +L1: testl $BIT2, %edx # Test for Debugging Extensions support jz L2 orl $BIT3, %eax # Set CR4.DE -L2: +L2: movl %eax, %cr4 movl %cr3, %eax pushl %eax @@ -322,14 +322,14 @@ L2: # edx still contains result from CPUID above jz L3 .byte 0x0f, 0xae, 0x07 # fxsave [edi] -L3: +L3: ## save the exception data pushl 8(%esp) ## Clear Direction Flag cld - + ## Prepare parameter and call C function pushl %esp pushl %ebx @@ -347,7 +347,7 @@ L3: testl $BIT24, %edx # Test for FXSAVE/FXRESTOR support jz L4 .byte 0x0f, 0xae, 0x0e # fxrstor [esi] -L4: +L4: addl $512,%esp ## UINT32 Dr0, Dr1, Dr2, Dr3, Dr6, Dr7; @@ -412,4 +412,4 @@ L4: popl %ebp addl $8,%esp # skip eax iretl - + diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebugSupport.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebugSupport.c index 08cef0154f..a0e56481a5 100644 --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebugSupport.c +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/X64/ArchDebugSupport.c @@ -1,7 +1,7 @@ /** @file Supporting functions for X64 architecture. - Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.
+ Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -62,7 +62,7 @@ InitializeDebugIdt ( IdtEntry[DEBUG_TIMER_VECTOR].Bits.GateType = IA32_IDT_GATE_TYPE_INTERRUPT_32; // - // If the CPU supports Debug Extensions(CPUID:01 EDX:BIT2), then + // If the CPU supports Debug Extensions(CPUID:01 EDX:BIT2), then // Set DE flag in CR4 to enable IO breakpoint // AsmCpuid (1, NULL, NULL, NULL, &RegEdx); @@ -75,7 +75,7 @@ InitializeDebugIdt ( Retrieve exception handler from IDT table by ExceptionNum. @param[in] ExceptionNum Exception number - + @return Exception handler **/ @@ -93,13 +93,13 @@ GetExceptionHandlerInIdtEntry ( return (VOID *) (IdtEntry[ExceptionNum].Bits.OffsetLow | (((UINTN)IdtEntry[ExceptionNum].Bits.OffsetHigh) << 16) | (((UINTN)IdtEntry[ExceptionNum].Bits.OffsetUpper) << 32)); -} +} /** Set exception handler in IDT table by ExceptionNum. @param[in] ExceptionNum Exception number - @param[in] ExceptionHandler Exception Handler to be set + @param[in] ExceptionHandler Exception Handler to be set **/ VOID -- cgit v1.2.3