From edcf8ffa69319cd5cb038124bd3878f254f97056 Mon Sep 17 00:00:00 2001 From: Vishal Oliyil Kunnil Date: Fri, 22 May 2026 14:14:25 -0700 Subject: BaseTools/Python: Remove error message with email address Remove the "Please send email to devel@edk2.groups.io" message from the unhandled exception handlers in build.py, GenFds.py, Trim.py, and the UPT tools. Also remove the now-unused MSG_EDKII_MAIL_ADDR and MSG_SEARCH_FOR_HELP constants from Common/DataType.py and UPT/Logger/StringTable.py. Signed-off-by: Vishal Oliyil Kunnil --- BaseTools/Source/Python/Common/DataType.py | 1 - BaseTools/Source/Python/GenFds/GenFds.py | 1 - BaseTools/Source/Python/Trim/Trim.py | 1 - BaseTools/Source/Python/UPT/InstallPkg.py | 1 - BaseTools/Source/Python/UPT/InventoryWs.py | 1 - BaseTools/Source/Python/UPT/Logger/StringTable.py | 4 ---- BaseTools/Source/Python/UPT/MkPkg.py | 1 - BaseTools/Source/Python/UPT/ReplacePkg.py | 1 - BaseTools/Source/Python/UPT/RmPkg.py | 1 - BaseTools/Source/Python/UPT/TestInstall.py | 1 - BaseTools/Source/Python/build/build.py | 1 - 11 files changed, 14 deletions(-) (limited to 'BaseTools/Source/Python') diff --git a/BaseTools/Source/Python/Common/DataType.py b/BaseTools/Source/Python/Common/DataType.py index 7ef3e9386a..4f381d8485 100644 --- a/BaseTools/Source/Python/Common/DataType.py +++ b/BaseTools/Source/Python/Common/DataType.py @@ -90,7 +90,6 @@ EDK_COMPONENT_TYPE_RT_DRIVER = 'RT_DRIVER' EDK_COMPONENT_TYPE_APPLICATION = 'APPLICATION' EDK_NAME = 'EDK' EDKII_NAME = 'EDKII' -MSG_EDKII_MAIL_ADDR = 'devel@edk2.groups.io' COMPONENT_TO_MODULE_MAP_DICT = { EDK_COMPONENT_TYPE_LIBRARY : SUP_MODULE_BASE, diff --git a/BaseTools/Source/Python/GenFds/GenFds.py b/BaseTools/Source/Python/GenFds/GenFds.py index 9c6a38698c..ca8e49e05f 100644 --- a/BaseTools/Source/Python/GenFds/GenFds.py +++ b/BaseTools/Source/Python/GenFds/GenFds.py @@ -389,7 +389,6 @@ def GenFdsApi(FdsCommandDict, WorkSpaceDataBase=None): "\nPython", CODE_ERROR, "Tools code failure", - ExtraData="Please send email to %s for help, attaching following call stack trace!\n" % MSG_EDKII_MAIL_ADDR, RaiseError=False ) EdkLogger.quiet(traceback.format_exc()) diff --git a/BaseTools/Source/Python/Trim/Trim.py b/BaseTools/Source/Python/Trim/Trim.py index 844519431d..f6f40a8d94 100644 --- a/BaseTools/Source/Python/Trim/Trim.py +++ b/BaseTools/Source/Python/Trim/Trim.py @@ -646,7 +646,6 @@ def Main(): "\nTrim", CODE_ERROR, "Unknown fatal error when trimming [%s]" % InputFile, - ExtraData="\n(Please send email to %s for help, attaching following call stack trace!)\n" % MSG_EDKII_MAIL_ADDR, RaiseError=False ) EdkLogger.quiet("(Python %s on %s) " % (platform.python_version(), sys.platform) + traceback.format_exc()) diff --git a/BaseTools/Source/Python/UPT/InstallPkg.py b/BaseTools/Source/Python/UPT/InstallPkg.py index e4c7565441..38bf8af8af 100644 --- a/BaseTools/Source/Python/UPT/InstallPkg.py +++ b/BaseTools/Source/Python/UPT/InstallPkg.py @@ -547,7 +547,6 @@ def Main(Options = None): "\nInstallPkg", CODE_ERROR, ST.ERR_UNKNOWN_FATAL_INSTALL_ERR % Options.PackageFile, - ExtraData=ST.MSG_SEARCH_FOR_HELP % ST.MSG_EDKII_MAIL_ADDR, RaiseError=False ) Logger.Quiet(ST.MSG_PYTHON_ON % (python_version(), diff --git a/BaseTools/Source/Python/UPT/InventoryWs.py b/BaseTools/Source/Python/UPT/InventoryWs.py index 955b2e510e..1eae0d1489 100644 --- a/BaseTools/Source/Python/UPT/InventoryWs.py +++ b/BaseTools/Source/Python/UPT/InventoryWs.py @@ -99,7 +99,6 @@ def Main(Options = None): Logger.Error("\nInventoryWs", CODE_ERROR, ST.ERR_UNKNOWN_FATAL_INVENTORYWS_ERR, - ExtraData=ST.MSG_SEARCH_FOR_HELP % ST.MSG_EDKII_MAIL_ADDR, RaiseError=False ) Logger.Quiet(ST.MSG_PYTHON_ON % (python_version(), diff --git a/BaseTools/Source/Python/UPT/Logger/StringTable.py b/BaseTools/Source/Python/UPT/Logger/StringTable.py index 90392affa7..7639460831 100644 --- a/BaseTools/Source/Python/UPT/Logger/StringTable.py +++ b/BaseTools/Source/Python/UPT/Logger/StringTable.py @@ -316,10 +316,6 @@ MSG_NEW_FILE_NAME_FOR_DIST = _( "Provide new filename for distribution file to be saved:\n") MSG_UPDATE_PACKAGE_DATABASE = _("Update Distribution Package Database ...") MSG_PYTHON_ON = _("(Python %s on %s) ") -MSG_EDKII_MAIL_ADDR = 'devel@edk2.groups.io' -MSG_SEARCH_FOR_HELP = _( - "\n(Please send email to %s for\n" - " help, attach the following call stack trace.)\n") MSG_REMOVE_TEMP_FILE_STARTED = _("Removing temp files started ... ") MSG_REMOVE_TEMP_FILE_DONE = _("Removing temp files ... Done.") MSG_FINISH = _("Successfully Done.") diff --git a/BaseTools/Source/Python/UPT/MkPkg.py b/BaseTools/Source/Python/UPT/MkPkg.py index c6d4731ed6..8c8942ccda 100644 --- a/BaseTools/Source/Python/UPT/MkPkg.py +++ b/BaseTools/Source/Python/UPT/MkPkg.py @@ -225,7 +225,6 @@ def Main(Options = None): CODE_ERROR, ST.ERR_UNKNOWN_FATAL_CREATING_ERR % \ Options.PackFileToCreate, - ExtraData=ST.MSG_SEARCH_FOR_HELP % ST.MSG_EDKII_MAIL_ADDR, RaiseError=False ) Logger.Quiet(ST.MSG_PYTHON_ON % \ diff --git a/BaseTools/Source/Python/UPT/ReplacePkg.py b/BaseTools/Source/Python/UPT/ReplacePkg.py index 03b91dab84..7ba76330e7 100644 --- a/BaseTools/Source/Python/UPT/ReplacePkg.py +++ b/BaseTools/Source/Python/UPT/ReplacePkg.py @@ -81,7 +81,6 @@ def Main(Options = None): "\nReplacePkg", CODE_ERROR, ST.ERR_UNKNOWN_FATAL_REPLACE_ERR % (Options.PackFileToReplace, Options.PackFileToBeReplaced), - ExtraData=ST.MSG_SEARCH_FOR_HELP % ST.MSG_EDKII_MAIL_ADDR, RaiseError=False ) Logger.Quiet(ST.MSG_PYTHON_ON % (python_version(), diff --git a/BaseTools/Source/Python/UPT/RmPkg.py b/BaseTools/Source/Python/UPT/RmPkg.py index cf37e2bdca..734780010f 100644 --- a/BaseTools/Source/Python/UPT/RmPkg.py +++ b/BaseTools/Source/Python/UPT/RmPkg.py @@ -166,7 +166,6 @@ def Main(Options = None): "\nRmPkg", CODE_ERROR, ST.ERR_UNKNOWN_FATAL_REMOVING_ERR, - ExtraData=ST.MSG_SEARCH_FOR_HELP % ST.MSG_EDKII_MAIL_ADDR, RaiseError=False ) Logger.Quiet(ST.MSG_PYTHON_ON % (python_version(), platform) + \ diff --git a/BaseTools/Source/Python/UPT/TestInstall.py b/BaseTools/Source/Python/UPT/TestInstall.py index 1adc19260d..5482ad9f6b 100644 --- a/BaseTools/Source/Python/UPT/TestInstall.py +++ b/BaseTools/Source/Python/UPT/TestInstall.py @@ -73,7 +73,6 @@ def Main(Options=None): "\nTestInstallPkg", TE.CODE_ERROR, ST.ERR_UNKNOWN_FATAL_INSTALL_ERR % Options.DistFiles, - ExtraData=ST.MSG_SEARCH_FOR_HELP % ST.MSG_EDKII_MAIL_ADDR, RaiseError=False ) Logger.Quiet(ST.MSG_PYTHON_ON % (python_version(), platform) + format_exc()) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py index 6b6b60e9bf..df591c3acf 100755 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -2755,7 +2755,6 @@ def Main(): "\nbuild", CODE_ERROR, "Unknown fatal error when processing [%s]" % MetaFile, - ExtraData="\n(Please send email to %s for help, attaching following call stack trace!)\n" % MSG_EDKII_MAIL_ADDR, RaiseError=False ) EdkLogger.quiet("(Python %s on %s) " % (platform.python_version(), sys.platform) + traceback.format_exc()) -- cgit v1.2.3