summaryrefslogtreecommitdiff
path: root/ShellPkg/Library/UefiShellDebug1CommandsLib
AgeCommit message (Collapse)AuthorFilesLines
2025-10-01ShellPkg/MemMap: Create arrays of MemoryType configuration and PagePierre Gondois1-220/+168
In an effort to simplify the code in the ShellPkg: - create a MEMORY_TYPE_INFO struct, storing per-MemoryType configuration information to facilitate the operations to do for each MemoryType. - create a MEMORY_TYPE_PAGES_INFO struct, storing per-MemoryType Pages and PagesSize count. Also use these arrays to facilitate Pages accounting and remove per-MemoryType variables. No functional change is introduced. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
2025-10-01ShellPkg/MemMap: Create array of MemoryType namesPierre Gondois1-41/+45
In an effort to simplify the code in the ShellPkg, replace the MemoryType names that are currently stored in individual variables by an array of names, facilitating access to these names. No functional change is introduced. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
2025-10-01ShellPkg/Dmem: Remove return parameter from DisplayXXX() functionsPierre Gondois1-42/+20
In an effort to simplify the code in the ShellPkg, remove the SHELL_STATUS parameter returned by: - DisplayRtProperties() - DisplayImageExecutionEntries() - DisplayConformanceProfiles() These functions are independent display functions. Thus failing to display a configuration table should not prevent from displaying the remaining tables. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
2025-10-01ShellPkg/Dmem: Remove unnecessary EfiGetSystemConfigurationTable() callsPierre Gondois1-38/+32
In an effort to simplify the code in the ShellPkg, remove EfiGetSystemConfigurationTable() calls fetching Configuration Table addresses that have already been collected. No functional change is introduced. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
2025-10-01ShellPkg/Dmem: Simplify logic by inverting Address checksPierre Gondois1-78/+81
In an effort to simplify the code in the ShellPkg, inverse checks against the 'Address'. This also lowers the indentation level. No functional change is introduced. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
2025-10-01ShellPkg/Dmem: Replace per-System Table variable by indexed arraysPierre Gondois1-125/+72
In an effort to simplify the code in the ShellPkg, remove the per-System Table variables by indexed arrays. The only functional change introduced is that a non-null Smbios3 System Table: - always replaces an Smbios System Table - ASSERT if (Smbios3 != 0) and (Smbios != 0) Otherwise no functional change is introduced. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
2025-10-01ShellPkg/Dmem: Remove Memory Range Capsule supportPierre Gondois2-4/+0
Memory Range Capsule is described in the UEFI spec 2.9 s8.5.3 Update Capsule with the following GUID: {0DE9F0EC-88B6-428F-977A-258F1D0E5E72} Support to print the EFI_MEMORY_RANGE_CAPSULE address in the EFI Configuration table was added in commit: 42b0443599a6 ("ShellPkg: UefiShellDebug1CommandsLib: Uefi Config Tables in Dmem.c") but EFI_MEMORY_RANGE_CAPSULE type and GUID is not present in edk2. Thus dmem always print a 0 value for this configuration table. Remove support of EFI_MEMORY_RANGE_CAPSULE in dmem. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
2025-10-01ShellPkg/Dmem: Remove remaining of SAL System TablePierre Gondois2-4/+0
The SAL System Table is unsupported and its support was removed in commit: f4c874c45dbc ("ShellPkg/UefiShellDebug1CommandsLib") Remove remaining of SAL System Table handling. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
2025-10-01ShellPkg/Dmem: Extract a DisplaySystemTable() functionPierre Gondois1-163/+185
In an effort to simplify the code in the ShellPkg, extract a DisplaySystemTable(). This also lowers the indentation level. No functional change is introduced. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
2025-09-09ShellPkg/SmbiosView: Add decode for DSP0134 SMBIOS Spec v3.9.0Giri Mudusuru1-0/+9
Add decode for Type17 Memory based on SMBIOS Spec v3.9.0 Signed-off-by: Giri Mudusuru <girimudusuru@microsoft.com>
2025-09-05ShellPkg/Library: Deprecate EFI_DEVICE_IO_PROTOCOLGowtham M1-1/+0
gEfiDeviceIoProtocolGuid identifies EFI_DEVICE_IO_PROTOCOL, which provided low-level I/O and MMIO access for UEFI drivers. It was removed in UEFI 2.10A and 2.11 due to overlapping functionality with modern protocols like EFI_PCI_IO_PROTOCOL and EFI_CPU_IO2_PROTOCOL. These newer protocols offer improved modularity, abstraction, and safety, making EFI_DEVICE_IO_PROTOCOL obsolete. Cc: Sachin Ganesh <sachinganesh@ami.com> Signed-off-by: Gowtham M <gowthamm@ami.com>
2025-09-05ShellPkg: Add support for PCIe Extended IDsNanjinmoorthyj2-2/+41
Add a support to print PTM (001F) structure. Signed-off-by: Nanjinmoorthy <nanjinmoorthyj@ami.com>
2025-09-02ShellPkg/UefiShellDebug1CommandsLib: Add MRDIMM entry to QueryTableNing Feng1-0/+12
Added the MRDIMM (0x08) entry to the MemoryDeviceMemoryTechnologyTable in QueryTable.c. This enables proper display and decoding of MRDIMM memory technology in SMBIOS Type 17 structures. Signed-off-by: Ning Feng <ning.feng@intel.com>
2025-08-12ShellPkg: Remove EmbeddedPkg dependencyedk2-stable202508Prachotan Bathi1-1/+0
Commit dcde148 introduced EmbeddedPkg as a dependency since gFdtTableGuid was in the EmbeddedPkg, but has now been moved to MdePkg. Signed-off-by: Prachotan Bathi <prachotan.bathi@arm.com>
2025-07-24ShellPkg: Fixed Deadcode and Null field Coverity warnings.Revathy V1-1/+1
Updated fixes for all Deadcode and Null field Coverity fixes in ShellPkg Signed-off-by: Revathy <revathyv@ami.com>
2025-07-24ShellPkg: DtbTableAddress via config in dmemPrachotan Reddy Bathi2-0/+7
DTB address can be modified through the config table. Use this address in dmem output. EmbeddedPkg dependency added to ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf and ShellPkg/ShellPkg.ci.yaml Adds to: 42b0443599a6 ("ShellPkg: UefiShellDebug1CommandsLib: Uefi Config Tables in Dmem.c") Signed-off-by: Prachotan Reddy Bathi <Prachotan.Bathi@arm.com>
2025-07-04ShellPkg: Correct spelling errors and typosAbdul Lateef Attar2-2/+4
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
2025-06-08ShellPkg: Prevent memcpy intrinsics in VS22 (17.14.2)Michael Kubacki2-30/+15
The latest VS2022 update replaces some code patterns with struct assignments with `memcpy`. This change convert the code to explicitly use `CopyMem`. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
2025-04-30ShellPkg: Add PCIe extended capabilityCian Costello2-0/+1157
Updates PCIe shell command to display previously undefined PCIe extended capabilities. Signed-off-by: Cian Costello <ccostello@nvidia.com>
2025-04-22ShellPkg: Updated Memory Form Factor definition per SMBIOS 3.8.0Shveta Gupta1-1/+5
This patch adds additional support for the new CAMM form factor defined in SMBIOS specification 3.8.0 Signed-off-by: Shveta Gupta <shvetag@nvidia.com>
2025-04-08ShellPkg: Added ArmV9 processors support for SmbiosView commandpraveensankarn1-0/+4
Added switch case for ArmV9 processor family inside function DisplayProcessorFamily2 in PrintInfo.c to avoid inappropriate data shown while accessing Type 4 Smbios table. ArmV9 processor family is added in Smbios Spec 3.8 which should be noted. Signed-off-by: Praveen Sankar N <praveensankarn@ami.com>
2025-04-03ShellPkg/SmbiosView: Decode for InterfaceTypeSpecificData of SMBIOS type42edhay1-1/+36
ShellPkg/SmbiosView tool changes for InterfaceTypeSpecificData decode and print Previously, the InterfaceTypeSpecificData of SMBIOS type42 table was dumped as hex in the SmbiosView tool output This commit adds decode, interpretation and print as per SMBIOS spec version 3.8.0 Signed-off-by: G Edhaya Chandran <edhaya.chandran@arm.com>
2025-01-29ShellPkg: fix warnings about uninitialized variableMike Maslenkin1-10/+13
Dmem.c: In function 'GetImageExecutionInfo': Dmem.c:241:10: error: 'Status' may be used uninitialized in this function [-Werror=maybe-uninitialized] return Status; ^~~~~~ Dmem.c:284:35: note: 'Status' was declared here EFI_STATUS Status; ^~~~~~ Dmem.c: In function 'ShellCommandRunDmem': Dmem.c:586:27: error: 'ConformanceProfileTableAddress' may be used uninitialized in this function [-Werror=maybe-uninitialized] ShellStatus = DisplayConformanceProfiles (ConformanceProfileTableAddress); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dmem.c:582:27: error: 'ImageExecutionTableAddress' may be used uninitialized in this function [-Werror=maybe-uninitialized] ShellStatus = DisplayImageExecutionEntries (ImageExecutionTableAddress); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dmem.c:578:27: error: 'RtPropertiesTableAddress' may be used uninitialized in this function [-Werror=maybe-uninitialized] ShellStatus = DisplayRtProperties (RtPropertiesTableAddress); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
2024-10-29ShellPkg: CodeQL FixesOliver Smith-Denny9-6/+22
Includes changes across the module for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
2024-10-29ShellPkg: UefiShellDebug1CommandsLib: CodeQL FixesOliver Smith-Denny23-30/+159
Includes changes across the module for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
2024-10-22ShellPkg: Updated Type 4 Info as per Smbios 3.8.0Revathy V1-0/+4
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4861 Added PROCESSOR_FAMILY_NAME support in ShellPkg. Signed-off-by: Revathy <revathyv@ami.com>
2024-10-22ShellPkg/SmbiosView: Correct wrong length offset usage in SMBIOS Type4Jason Zhao1-2/+2
The patch will correct wrong length offset usage in SMBIOS Type4. For SMBIOS Ver3.6, length should be larger than 0x30. For SMBIOS Ver3.8, length should be larger than 0x32. Signed-off-by: Jason Zhao <jason.zhao@intel.com>
2024-09-03ShellPkg/SmbiosView: Add new Socket Type for SMBIOS Type4Jason Zhao1-0/+4
The patch prints new socket type(Type 4, Offset 32h) for SMBIOS Type4 based on SMBIOS v3.8.0. Signed-off-by: Jason Zhao <jason.zhao@intel.com>
2024-08-28ShellPkg: Correct smbiosview strings and conditions for SMBIOS Type9HoraceX Lien2-11/+10
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4826 Using smbiosview to dump SMBIOS Type9, some code condition and string are incorrect. Signed-off-by: HoraceX Lien <horacex.lien@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
2024-07-25ShellPkg: Correct smbiosview strings for SMBIOS Type0HoraceX Lien2-30/+30
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4813 Some strings not match SMBIOS specification definition, include uppercase and lowercase, wrong characters, extra words,...etc Signed-off-by: HoraceX Lien <horacex.lien@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
2024-07-23ShellPkg: Changes to print Type17 in SmbiosviewShenbagadevi R1-0/+7
Add changes to print PMIC and RCD details of Smbios Type17 in Shell smbiosview command. Cc: Gaoliming <gaoliming@byosoft.com.cn> Cc: Sainadh N <sainadhn@ami.com> Cc: Sundaresan S <sundaresans@ami.com> Cc: Srinivasan M <srinivasanm@ami.com> Cc: Ramesh R <rameshr@ami.com> Cc: Karthika R <karthikar@ami.com> Signed-off-by: Shenbagadevi R <shenbagadevir@ami.com> Reviewed-by: Giri Mudusuru <girimudusuru@microsoft.com>
2024-07-10ShellPkg: UefiShellDebug1CommandsLib: Conformance Profiles in Dmem.cSam Kaynor3-0/+89
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 Implemented dumping of the UEFI Conformance Profiles Table using Dmem.c Uses header file for GUIDs added in previous patches Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Sam Kaynor <Sam.Kaynor@arm.com> Tested-by: Stuart Yoder <stuart.yoder@arm.com> Reviewed-by: Stuart Yoder <stuart.yoder@arm.com>
2024-07-10ShellPkg: UefiShellDebug1CommandsLib: Image Execution Table in Dmem.cSam Kaynor2-0/+139
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 Implemented dumping of the Image Execution Table using Dmem.c Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Sam Kaynor <Sam.Kaynor@arm.com> Tested-by: Stuart Yoder <stuart.yoder@arm.com> Reviewed-by: Stuart Yoder <stuart.yoder@arm.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
2024-07-10ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.cSam Kaynor2-4/+85
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 Implemented the dumping of the UEFI RT Properties Table using Dmem.c Added new entry to the help command for the -verbose option Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Sam Kaynor <Sam.Kaynor@arm.com> Tested-by: Stuart Yoder <stuart.yoder@arm.com> Reviewed-by: Stuart Yoder <stuart.yoder@arm.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
2024-06-07ShellPkg/Pci.c: Update supported link speed to PCIe Gen6HoraceX Lien1-0/+6
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4779 Refer to PCI express base specification Reversion 6.2, table 7-23 Link Capabilities Register. Supported Link Speeds Vector bit 5: speed 64 GT/s. Add the support to shell command 'pci'. Signed-off-by: HoraceX Lien <horacex.lien@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
2024-04-16ShellPkg/SmbiosView: Support New ProcessorUpgrade for SMBIOS Type4Jason Lou1-1/+29
The patch updates SmbiosView to support new ProcessorUpgrade for SMBIOS Type4 based on SMBIOS 3.8.0. Signed-off-by: Jason Lou <yun.lou@intel.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> Reviewed-by: Star Zeng <star.zeng@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Star Zeng <star.zeng@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com>
2024-04-10ShellPkg: Update smbiosview type 4 with SMBIOS 3.6 fieldsHoraceX Lien1-0/+4
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4737 update smbiosview type 4 related fileds. Signed-off-by: HoraceX Lien <horacex.lien@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
2024-03-04ShellPkg/SmbiosView: Support New ProcessorFamily for SMBIOS Type4Jason Lou1-1/+33
The patch updates SmbiosView to support new ProcessorFamily for SMBIOS Type4 based on SMBIOS 3.8.0. Signed-off-by: Jason Lou <yun.lou@intel.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> Reviewed-by: Star Zeng <star.zeng@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhichao Gao <zhichao.gao@intel.com>
2024-02-02ShellPkg: Update smbiosview for LoongArchDongyan Qian2-0/+76
According to SMBIOS spec3.6, LoongArch information support has been added, so this patch is submitted for display as information in smbiosview. Cc: Zhichao Gao <zhichao.gao@intel.com> Cc: Chao Li <lichao@loongson.cn> Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn> Reviewed-by: Chao Li <lichao@loongson.cn> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
2023-12-08ShellPkg: Fix typosPage Chen3-3/+3
begining->beginning dirve->drive duplicat->duplicate fuly->fully Funciton->Function Functino->Function optioanl->optional poitners->pointers rountine->routine sucessful->successful sucessfully->successfully Signed-off-by: Page Chen <paiching_chen@apple.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Cc: Andrew Fish <afish@apple.com> Message-Id: <829d2bed2a848229d719d7ae7b64ef1a47782720.1699557986.git.paiching_chen@apple.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
2023-08-31ShellPkg: Add ProcessorUpgradeSocket definitions from SMBIOS 3.7.0Eduardo Cuevas Farfan1-1/+33
This patch adds below definitions from SMBIOS 3.7.0 into QueryTable.c - ProcessorUpgradeSocketAM5 - ProcessorUpgradeSocketSP5 - ProcessorUpgradeSocketSP6 - ProcessorUpgradeSocketBGA883 - ProcessorUpgradeSocketBGA1190 - ProcessorUpgradeSocketBGA4129 - ProcessorUpgradeSocketLGA4710 - ProcessorUpgradeSocketLGA7529 Signed-off-by: Eduardo Cuevas Farfan <eduardo.cuevas.farfan@intel.com> Reviewed-by: Star Zeng <star.zeng@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
2023-08-30ShellPkg/SmbiosView: Update display of PCIe system slot IDNhi Pham1-1/+1
This updates the system slot ID up to SlotTypePCIExpressGen6andBeyond (0xC4) added by updating type 9 with SMBIOS version 3.5 to cover modern PCIe Gens. Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
2023-06-08ShellPkg/SmbiosView: type 45 and type 46 support.Simon Wang4-4/+222
The initial version of Smbios Specification 3.6.0 type 45 and type 46 support. Signed-off-by: Simon Wang <simowang@nvidia.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
2023-06-02ShellPkg: Add a condition to print accurate type0 Bios Size in smbiosview.Thejaswani Putta1-1/+3
As per the SMBIOS spec, in smbios type0 table, if the Bios size is greater than 16MB, extended bios size is used to update size information and bios size is set to 0xff. when this data is printed by smbiosview, both bios size and extended bios size is printed if the smbios version is beyond 3.1, which is incorrect as Bios size is set to 0xff when rom size is more than 16MB. To fix this bug, added a condition to print bios size only when it is not set to 0xff or if the smbios version is older than 3.1. Signed-off-by: Thejaswani Putta <tputta@nvidia.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
2023-05-12ShellPkg/UefiShellDebug1CommandsLib: Replace hardcoded SMBIOS strings.Giri Mudusuru2-8/+10
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3805 Replace hardcoded SMBIOS Anchor string and size with defines. Fix buffer overflow as described below. Smbios64BitPrintEPSInfo () is coded like: UINT8 Anchor[5]; MemToString (Anchor, SmbiosTable->AnchorString, 5); But the definition of MemToString() Copy Length of Src buffer to Dest buffer, add a NULL termination to Dest buffer. So Anchor needs to be +1 the size of the SMBIOS Anchor string `_SM3_`. Changes from v1 to v2: - Replace doxygen style inline comments Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Andrew Fish <afish@apple.com> Signed-off-by: Giri Mudusuru <girim@apple.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
2023-04-13ShellPkg: UefiShellDebug1CommandsLib: Uefi Config Tables in Dmem.cSam Kaynor3-13/+123
Added entries for UEFI Config Tables not present in current Dmem output. Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Sam Kaynor <Sam.Kaynor@arm.com> Reviewed-by: Sunny Wang <sunny.wang@arm.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
2023-04-11ShellPkg: Update smbiosview type 0/4/17/41 with SMBIOS 3.5 fieldsLin, MillerX2-91/+89
Signed-off-by: MillerX Lin <millerx.lin@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
2023-04-03ShellPkg: Fix conditionally uninitialized variablesMichael Kubacki2-10/+17
Fixes CodeQL alerts for CWE-457: https://cwe.mitre.org/data/definitions/457.html Cc: Erich McMillan <emcmillan@microsoft.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Michael Kubacki <mikuback@linux.microsoft.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Co-authored-by: Erich McMillan <emcmillan@microsoft.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Oliver Smith-Denny <osd@smith-denny.com>
2023-03-14ShellPkg/Library: Fix 32-bit truncation of pointer valuesMichael D Kinney1-2/+0
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4366 Update C and UNI files that are incorrectly using %x or %08x instead of %p for pointer values. On 64-bit systems, this is truncating pointer values above 4GB. In reviewing ShellPkg for this issue some unused UNI strings with incorrect format specifiers were removed instead of being fixed. Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com>
2023-01-18ShellPkg: Display SMBIOS Type38 fields in smbiosview in formatted viewPrakash.K2-3/+27
In smbiosview command in shell, below are the fields of SMBIOS Type38 table which can be displayed in formatted manner. 1. Base Address 1. IPMI Specification Version. 2. NV Storage Device Address. Base Address: As per spec, the value in Base Address field of SMBIOS type38 table should be right shifted by 1 if the interface type is SSIF. IPMI Specification Version: If the value in IPMI Specification Version field is 15H, it should be displayed 1.5. NV Storage Device Address: If the value in NV Storage Device Address field is 0xFF, it should be displayed as "No storage device is Present". Cc: Vasudevan Sambandan <vasudevans@ami.com> Cc: Sundaresan Selvaraj <sundaresans@ami.com> Cc: Gayathri Thunuguntla <gayathrit@ami.com> Signed-off-by: Prakash K <prakashk@ami.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
generated by cgit v1.2.3 (git 2.39.0) at 2026-09-15 04:02:33 +0300