EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=dependabot%2Fgithub_actions%2Fgithub%2Fcodeql-action-4 2025-10-15T16:21:17+00:00 2025-10-15T16:21:17+00:00 Michael D Kinney michael.d.kinney@intel.com 2025-10-15T15:01:41+00:00 urn:sha1:2522020ee12b42fabd8b1353b4f89854455d6325 Linux/GCC host-based unit test application builds use a default stack size of 8MB. Windows/VS20xx and Windows/CLANGPDB host-based unit test application builds use a default stack size of 1MB. This can allow Linux unit tests to pass and Windows unit tests to fail with stack overflow if large local variables are used. ASAN increases stack usage, so this condition can occur more frequently when ASAN enabled. Update MSFT and CLANGPDB for host-based unit tests to use a default stack size of 8MB so all tool chains use the same default stack size for host-based unit tests. Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> 2025-09-28T23:38:21+00:00 Michael D Kinney michael.d.kinney@intel.com 2025-09-19T20:48:55+00:00 urn:sha1:55a5ec63fe20152c237039c54e2957720828cf10 Remove /EHsc from CC_FLAGS. /EHs is added to CC_FLAGS in UnitTestFrameworkPkgHost.dsc.inc for all components. Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> 2025-09-28T23:38:21+00:00 Michael D Kinney michael.d.kinney@intel.com 2025-09-19T20:56:34+00:00 urn:sha1:07da104cfbe410e5f59791ab9a71fd22241c483c Update MSFT CC_FLAGS options to remove /EHs and /MTd that are added by UnitTestFrameworkPkgHost.dsc.inc for all components. Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> 2025-09-28T23:38:21+00:00 Michael D Kinney michael.d.kinney@intel.com 2025-09-19T20:52:11+00:00 urn:sha1:0838bf1531b5b6bf1ac8b2bf71c8fe4ce4375141 Add -DSUBHOOK_STATIC to all GCC family builds to match defines in MSFT family builds. Also remove /EHsc from MSFT CC_FLAGS. /EHs is added to CC_FLAGS in UnitTestFrameworkPkgHost.dsc.inc for all components. Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> 2025-09-28T23:38:21+00:00 Michael D Kinney michael.d.kinney@intel.com 2025-09-19T20:55:19+00:00 urn:sha1:6e65f7df90434c03371790be180becb10e1c30c7 Add CLANGPDB family defines to match MSFT family defines. Also add -Wno-deprecated-declarations to CLANGPDB family to ignore warnings detected when building cmocka sources with clang compiler. Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> 2025-09-28T23:38:21+00:00 Michael D Kinney michael.d.kinney@intel.com 2025-09-19T21:03:23+00:00 urn:sha1:81a7efddd508e78b867d7efa1333564a8a32725f Update GoogleTestLib.h to support Windows/CLANGPDB build. When using Windows/CLANGPDB, _MSC_VER is not defined. If it is not defined, then set to 1900 for Visual Studio 2015 or newer compatibility when using windows include files for host based unit test application builds. If _MSC_VER is not set, then those application fail to build. Also address a Windows/CLANG issue when ASAN is enabled by providing an alternate implementation of the EXPECT_THROW_MESSAGE() and ASSERT_THROW_MESSAGE() macros. Without this alternate implementation, an exception is generated due to the description of the ASSERT() condition being NULL. Update all implementations of EXPECT_THROW_MESSAGE() and ASSERT_THROW_MESSAGE() to support parameters to the statement executed to return values. Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> 2025-09-28T23:38:21+00:00 Michael D Kinney michael.d.kinney@intel.com 2025-09-19T20:45:20+00:00 urn:sha1:9731114a00e8360d5b116630c133590108640039 Update host-based unit test [BuildOptions] to support CLANGDWARF and CLANGPDB. * Use CLANG specific code coverage options * Map CLANG trap function to abort() to resolve link issues when building Google Test based unit tests. The default mapping from tools_def.txt is to an unresolved function to generate a build failure. Mapping to abort() overrides the default mapping. If a unit test introduces undefined behavior in a code path that is executed, then abort() is called and the unit test application exits with an error and fails the unit test. * Update GCC to pass --coverage in link command so the linker automatically includes -lgcov. The explicit linking of -lgcov is removed. * Add /EHs to all MSFT components instead of only components of type HOST_APPLICATION. * Add CXX_FLAGS for all tool chain families. Use c++ 20 for MSFT and GCC and c++ 17 for clang. Clang generates errors compiling Google Test with c++ 20. * Add -z noexecstack to all GCC builds to reduce warnings. * Add UNIT_TESTING_CODE_COVERAGE_ENABLE that is enabled by default. Can be used to temporarily disable code coverage when debugging interactions between unit testing features. Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> 2025-09-28T23:38:21+00:00 Michael D Kinney michael.d.kinney@intel.com 2025-09-19T20:32:18+00:00 urn:sha1:f832329addcb199bb4bee6cb6813dca1ebc3802d Set same defines for CLANGPDB tool chain family as all tool chain other families. Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> 2025-09-25T22:04:10+00:00 Oliver Smith-Denny osde@microsoft.com 2025-09-15T16:26:53+00:00 urn:sha1:5f9e2eac7a8a92669e9e2705bec0593500a2d158 edk2 is dropping support for the ARM32 architecture. This commit removes ARM32 code from UnitTestFrameworkPkg. It also drops irrelevant VALID_ARCHITECTURES comments from infs that are not arch specific. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com> 2025-09-19T13:45:44+00:00 Michael D Kinney michael.d.kinney@intel.com 2025-08-21T03:24:08+00:00 urn:sha1:0bc550f4660a6d3b2c818ae7a7150cf3767a6dbc Add missing override keyword to c++ classes. Found by the clang++ compiler. Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>