Tianocore/edk2.git/UefiCpuPkg/Library/SmmRelocationLib, branch master

UefiCpuPkg: Set up 256 IDT Descs in SEC/PEI/SMM

2026-03-07T03:58:40+00:00

Currently, SEC, PEI, and SMM only set up 32 - 34 IDT descs. This means that any exceptions received above that number will cause a #GP fault. This commit updates these environments to follow DXE and set up the IDT with the architecturally defined 256 entries, each of which point to the common exception handler. This does two things: - Has well defined behavior for receiving exceptions in these environments instead of relying on a #GP fault to occur. - Allows the stack cookie interrupt (0x42) to be routed correctly instead of appearing as a #GP fault. Signed-off-by: Oliver Smith-Denny

UefiCpuPkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

UefiCpuPkg/Library: Rename EDKII_PEI_MP_SERVICES2_PPI

2025-04-18T17:13:55+00:00

EDKII_PEI_MP_SERVICES2_PPI has been renamed to EFI_PEI_MP_SERVICES2_PPI and moved to MdePkg. Relevant changes have been made here. Signed-off-by: Sachin Ganesh

UefiCpuPkg: Use public Architectural MSRs from MdePkg

2024-11-12T01:07:12+00:00

Replaced local Msr defines with inclusion of Register/Amd/Msr.h in Amd libraries. Signed-off-by: Vivian Nowka-Keane

UefiCpuPkg: Remove AMD 32-bit SMRAM save state map

2024-11-01T13:53:09+00:00

Per AMD64 Architecture Programmer's Manual Volume 2: System Programming - 10.2.3 SMRAM State-Save Area (Rev 24593), the AMD64 architecture does not use the legacy SMM state-save area format (Table 10-2) for 32-bit SMRAM save state map. Clean up codes for the invalid save state map. Signed-off-by: Phil Noh

UefiCpuPkg/SmmRelocationLib: Add library instance for AMD

2024-05-08T01:53:58+00:00

Due to the definition difference of SMRAM Save State, SmmBase config in SMRAM Save State for AMD is also different. This patch provides the AmdSmmRelocationLib library instance to handle the SMRAM Save State difference. Cc: Abdul Lateef Attar Cc: Abner Chang Cc: Ray Ni Cc: Zeng Star Cc: Gerd Hoffmann Cc: Rahul Kumar Signed-off-by: Jiaxin Wu Acked-by: Ray Ni Reviewed-by: Abdul Lateef Attar

UefiCpuPkg/SmmRelocationLib: Remove unnecessary CpuIndex

2024-05-08T01:53:58+00:00

This patch is to remove unnecessary CpuIndex. Cc: Ray Ni Cc: Zeng Star Cc: Gerd Hoffmann Cc: Rahul Kumar Signed-off-by: Jiaxin Wu Reviewed-by: Ray Ni

UefiCpuPkg/SmmRelocationLib: Remove unnecessary global variable

2024-05-08T01:53:58+00:00

This patch aims on mProcessorInfo global variable, which can be defined as local variable in SmmRelocateBases(). With this patch, no need to allocate the memory for all CPUs to store the Processor Info. Cc: Ray Ni Cc: Zeng Star Cc: Gerd Hoffmann Cc: Rahul Kumar Signed-off-by: Jiaxin Wu Reviewed-by: Ray Ni

UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory allocation

2024-05-08T01:53:58+00:00

Since SMM relocation is performed serially for each CPU, there is no need to allocate buffers for all CPUs to store the SmBase address in mSmBase and the Rebased flag in mRebased. A defined global variable is sufficient. This patch focuses on the mSmBase and mRebased global variables to prevent unnecessary memory allocation for these variables. Cc: Ray Ni Cc: Zeng Star Cc: Gerd Hoffmann Cc: Rahul Kumar Signed-off-by: Jiaxin Wu Reviewed-by: Ray Ni

UefiCpuPkg/SmmRelocationLib: Rename global variables

2024-05-08T01:53:58+00:00

This patch aims to rename global variables for clearer association with Smm Init, ensuring their names are distinct from those used in the PiSmmCpuDxeSmm Driver. Cc: Ray Ni Cc: Zeng Star Cc: Gerd Hoffmann Cc: Rahul Kumar Signed-off-by: Jiaxin Wu Reviewed-by: Ray Ni