Tianocore/edk2.git/ShellPkg, branch dependabot/github_actions/github/codeql-action-4.39.1EDK II (mirror)https://git.radix-linux.su/Tianocore/edk2.git/atom?h=dependabot%2Fgithub_actions%2Fgithub%2Fcodeql-action-4.39.12026-10-15T10:15:44+00:00ShellPkg/Shell: Terminate and separate the ShellOpt command line2026-10-15T10:15:44+00:00Jin Kang112378607+JinKang021004@users.noreply.github.com2026-10-14T06:34:24+00:00urn:sha1:f14c2884c718926b49198bd5e3061763d5506db5
CreatePopulateInstallShellParametersProtocol() combined image load options
and ShellOpt without reserving a NUL terminator. Neither input must carry
one, so ParseCommandLineToArgs() could read beyond the allocation. The
load options also overwrote ShellOpt when both inputs were present.
Read ShellOpt into a separately terminated buffer, validate its CHAR16
size, normalize its effective length, and propagate read failures. Reserve
space for a separator and terminator in the combined buffer.
Preserve the image name at Argv[0] and insert ShellOpt immediately after
it, before the rest of the load options. Appending ShellOpt at the end
would pass shell options as arguments to a script or application named in
the load options. Use the parser's argument-boundary rules so quoted
image paths retain their meaning.
Fixes: https://github.com/tianocore/edk2/issues/10549
Signed-off-by: Jin Kang <112378607+JinKang021004@users.noreply.github.com>
ShellPkg/AcpiView: Add parser for BERT ACPI table2026-09-25T14:49:14+00:00Amratheshamrathesh@arm.com2026-09-04T08:18:06+00:00urn:sha1:e3384fd3082fbd2c793f030ebcc20c17208f8964
The Boot Error Record Table (BERT) identifies a Boot Error Region
containing platform error records produced during a previous boot.
Extend AcpiView to display and validate BERT table fields. Validate
the Boot Error Region length and address, and that the entire region
is reported as EfiReservedMemoryType in the UEFI memory map.
Signed-off-by: Amrathesh <amrathesh@arm.com>
ShellPkg/UefiShellDebug1CommandsLib: Fix memory leaks in help display2026-09-25T12:42:52+00:00Qihang Gaogaoqihang@loongson.cn2026-09-18T07:49:47+00:00urn:sha1:ecee358dea7be4ba4730067e45951938d10ae723
HiiGetString() returns a dynamically allocated string that must be
released with FreePool(). In MainCommandDisplayHelp() and
HMainCommandDisplayHelp(), the returned InfoString is printed but
never freed, leaking memory each time the help screen is displayed.
Release InfoString after ShellPrintEx() in both functions.
No functional change intended.
Signed-off-by: Qihang Gao <gaoqihang@loongson.cn>
ShellPkg/SmbiosView: Add MemoryTypeLpDdr6 to QueryTable2026-09-18T14:58:53+00:00Ashraf Ali Sashraf.ali.s@intel.com2026-07-09T08:17:36+00:00urn:sha1:eecc2039aac3b31ad41c23ecb84fc3d5a85e885f
Signed-off-by: Ashraf Ali S <ashraf.ali.s@intel.com>
ShellPkg: Trim cmd parameters if -? is present2026-09-16T14:27:54+00:00Pierre Gondoispierre.gondois@arm.com2026-08-11T14:35:56+00:00urn:sha1:29a6f5dd06cb714a76f2385d4c50fde0d2d7d8bf
The presence of "-?" in a command line is equivalent to issuing
"help <cmd>" and displays the manual page of the command.
However the additional command specific parameters/flags
are also passed to the help command and are mis-interpreted
by the help command.
E.g. "ls -r -?" translates to "help ls -r"
"""
Shell> ls -r -?
help: Unknown flag - '-r'
"""
Update DoHelpUpdate() to only keep the command name and trim
additional command specific parameters. To pass "help" specific
flags while getting the manual page for a command, the usage
of the "help" command should be preferred over adding "-?".
Note:
As a side effect, issuing:
"""
Shell> -?
"""
- used to be translated to "help -?", i.e. request
the manual for the help command
- is now translated to "help", i.e. request all the shell
command available
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg: Remove redundant -? handling from shell commands2026-09-16T14:27:54+00:00Pierre Gondoispierre.gondois@arm.com2026-06-04T19:56:39+00:00urn:sha1:6ac4aa8c1004bbba0d4bb0d80f9ef945b4df0de2
Drop per-command checks for the -? help flag in shell command
implementations that already rely on the common command-line parsing
and help dispatch path.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg: AcpiView: add support for GICv5 IORT table2026-09-15T10:12:13+00:00Signed-off-by: Sarah WalkerSarah.Walker2@arm.com2026-06-29T12:48:42+00:00urn:sha1:0dc3c2865cf5c8e1a582ae78c0371d25cf7f7c02
Add support for printing GICv5-related fields with acpiview
in the IORT table.
Signed-off-by: Sarah Walker <Sarah.Walker2@arm.com>
ShellPkg: AcpiView: add support for GICv5 SRAT table2026-09-15T10:12:13+00:00Sarah WalkerSarah.Walker2@arm.com2026-06-29T12:47:50+00:00urn:sha1:36927430c39dc9236f121f53ede249a33d7342ba
Add support for printing GICv5-related fields with acpiview
in the SRAT table.
Signed-off-by: Sarah Walker <Sarah.Walker2@arm.com>
ShellPkg: AcpiView: add support for GICv5 MADT table2026-09-15T10:12:13+00:00Sarah WalkerSarah.Walker2@arm.com2026-06-29T12:45:41+00:00urn:sha1:ce755c8f1bb408f3a640a48903cd250371efdbb0
Add support for printing GICv5-related fields with acpiview
in the MADT table.
Signed-off-by: Sarah Walker <Sarah.Walker2@arm.com>
ShellPkg/UefiShellBcfg: Exit early if ShellCommandLineParse() failed2026-09-03T22:15:47+00:00Mingjie Shenshen497@purdue.edu2026-09-01T02:50:58+00:00urn:sha1:9d46dc9fa036b701f637f5e4ccc659d4999b90fd
Jump to the Done cleanup label when `ShellCommandLineParse()` fails, and move
the success path (unchanged) out of the now-unnecessary else block. This patch
does not introduce behavioral change.
Generated by the following Coccinelle semantic patch:
```smpl
@@
identifier status, problem, ret, hii;
statement S;
@@
if (EFI_ERROR (status)) {
if ((status == EFI_VOLUME_CORRUPTED) && (problem != NULL)) {
ShellPrintHiiDefaultEx (STRING_TOKEN (STR_GEN_PROBLEM), hii, ..., problem);
FreePool (problem);
ret = SHELL_INVALID_PARAMETER;
} else {
ASSERT (FALSE);
}
+ goto Done;
}
- else {
...
- }
...
Done:
S
```
Signed-off-by: Mingjie Shen <shen497@purdue.edu>