Tianocore/edk2.git/ShellPkg/Library/UefiShellLevel3CommandsLib, branch dependabot/github_actions/github/codeql-action-4.39.1EDK II (mirror)https://git.radix-linux.su/Tianocore/edk2.git/atom?h=dependabot%2Fgithub_actions%2Fgithub%2Fcodeql-action-4.39.12026-09-16T14:27:54+00:00ShellPkg: Remove redundant -? handling from shell commands2026-09-16T14:27:54+00:00Pierre Gondoispierre.gondois@arm.com2026-06-04T19:56:39+00:00urn:sha1:6ac4aa8c1004bbba0d4bb0d80f9ef945b4df0de2
Drop per-command checks for the -? help flag in shell command
implementations that already rely on the common command-line parsing
and help dispatch path.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellLevel3: Lower indentation level in MainCmdXXX()2026-05-01T12:16:07+00:00Pierre Gondoispierre.gondois@arm.com2026-04-28T16:25:08+00:00urn:sha1:f1f89f454cd8c9aabae7ce5e690f612bd969f5ff
This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.
Lower the indentation level in the newly created MainCmdXXX()
functions.
Some ASSERT() are removed in Help.c as they check variables
which were initialized a few lines above.
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Help: Extract PrintMatchingHelp() function2026-05-01T12:16:07+00:00Pierre Gondoispierre.gondois@arm.com2026-04-30T11:46:33+00:00urn:sha1:8b5c970c55a723a42cc239ae6b0b03a01c32d464
Extract a PrintMatchingHelp() function in the Help command
to help splitting the logic MainCmdHelp() function.
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellLevel3: Extract ProcessFileList() function2026-05-01T12:16:07+00:00Pierre Gondoispierre.gondois@arm.com2026-04-28T16:10:21+00:00urn:sha1:27c785b0df7f6ef327a07b32c1680ecfc389ded4
Extract a ProcessFileList() in:
- Touch.c
- Type.c
to lower the indentation level and simplify the logic.
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellLevel3: Extract MainCmdXXX() function2026-05-01T12:16:07+00:00Pierre Gondoispierre.gondois@arm.com2026-04-28T12:53:52+00:00urn:sha1:014d8fb941f8d66455e7960a6b2b26ca2030e159
This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.
Extract a MainCmdXXX() function for each shell command.
This command contains the possible operations the command aims
to operate. The ShellCommandRunXXX() function from which it
is extracted is only responsible of:
- initializing the shell/command environment
- parsing the command parameter and creating a Package
- freeing the Package
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellLevel3: Return if ShellCommandLineParse() failed2026-05-01T12:16:07+00:00Pierre Gondoispierre.gondois@arm.com2026-04-28T12:45:48+00:00urn:sha1:49ba46ec0ae6f8b496800f3db55cd1369d326483
This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.
Return directly if ShellCommandLineParse() returned an error Status.
In such case, the "Package" that should be allocated by
ShellCommandLineParse() is already freed in:
ShellCommandLineParse()
\-ShellCommandLineParseEx()
\-InternalCommandLineParse()
so there is no need to free it with ShellCommandLineFreeVarList().
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Help: Free package on all paths2026-05-01T12:16:07+00:00Pierre Gondoispierre.gondois@arm.com2026-04-06T21:25:12+00:00urn:sha1:a219f8cfc541ca7c93c8bf614998621d97110c03
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Type: Factorize character display2026-05-01T12:16:07+00:00Pierre Gondoispierre.gondois@arm.com2026-04-06T21:22:14+00:00urn:sha1:899b8b8550f88cc9ac5b5aea7640777b24c90166
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Cls: Factorize color parsing2026-05-01T12:16:07+00:00Pierre Gondoispierre.gondois@arm.com2026-04-06T21:21:44+00:00urn:sha1:680ee2e3e9b1ed0b5a8d8c3262f355ea65a2175c
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellLib: Add IsDotOrDotDot() function2026-04-24T18:18:47+00:00Pierre Gondoispierre.gondois@arm.com2026-04-03T07:18:45+00:00urn:sha1:420dab0b24c4b5fa7d1f462b3319877897be63b4
Replace existing checks against L"." and L".." by
a named function.
No functional change.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>