Tianocore/edk2.git/ShellPkg/Library/UefiShellLevel3CommandsLib, branch dependabot/github_actions/actions/github-script-9

ShellPkg/UefiShellLevel3: Lower indentation level in MainCmdXXX()

2026-05-01T12:16:07+00:00

This patch aims to help breaking down the long function present in the ShellPkg and reduce complexity/nested code and conditions. Lower the indentation level in the newly created MainCmdXXX() functions. Some ASSERT() are removed in Help.c as they check variables which were initialized a few lines above. No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/Help: Extract PrintMatchingHelp() function

2026-05-01T12:16:07+00:00

Extract a PrintMatchingHelp() function in the Help command to help splitting the logic MainCmdHelp() function. No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellLevel3: Extract ProcessFileList() function

2026-05-01T12:16:07+00:00

Extract a ProcessFileList() in: - Touch.c - Type.c to lower the indentation level and simplify the logic. No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellLevel3: Extract MainCmdXXX() function

2026-05-01T12:16:07+00:00

This patch aims to help breaking down the long function present in the ShellPkg and reduce complexity/nested code and conditions. Extract a MainCmdXXX() function for each shell command. This command contains the possible operations the command aims to operate. The ShellCommandRunXXX() function from which it is extracted is only responsible of: - initializing the shell/command environment - parsing the command parameter and creating a Package - freeing the Package No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellLevel3: Return if ShellCommandLineParse() failed

2026-05-01T12:16:07+00:00

This patch aims to help breaking down the long function present in the ShellPkg and reduce complexity/nested code and conditions. Return directly if ShellCommandLineParse() returned an error Status. In such case, the "Package" that should be allocated by ShellCommandLineParse() is already freed in: ShellCommandLineParse() \-ShellCommandLineParseEx() \-InternalCommandLineParse() so there is no need to free it with ShellCommandLineFreeVarList(). No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/Help: Free package on all paths

2026-05-01T12:16:07+00:00

Signed-off-by: Pierre Gondois

ShellPkg/Type: Factorize character display

2026-05-01T12:16:07+00:00

Signed-off-by: Pierre Gondois

ShellPkg/Cls: Factorize color parsing

2026-05-01T12:16:07+00:00

Signed-off-by: Pierre Gondois

ShellPkg/UefiShellLib: Add IsDotOrDotDot() function

2026-04-24T18:18:47+00:00

Replace existing checks against L"." and L".." by a named function. No functional change. Signed-off-by: Pierre Gondois

ShellPkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki