Tianocore/edk2.git/ShellPkg/Library/UefiShellLevel2CommandsLib, branch master

ShellPkg/Ls: Initialize list pointer variable

2026-08-27T07:58:44+00:00

Using an uninitialized variable resulted in a system exception when the user typed the `ls -r` command. ShellOpenFileMetaArg() only allocates a list head when this is NULL, and appends to whatever it points at otherwise. Signed-off-by: Artem Senichev

ShellPkg/Ls: Remove double-free calls

2026-08-04T07:35:35+00:00

Package is always freed in ShellCommandRunLs(). Remove calls to ShellCommandLineFreeVarList() in MainCmdLs(). This double-free was introduced in: commit 531b0aa00211 ("ShellPkg/UefiShellLevel2: Extract MainCmdXXX() function") Signed-off-by: Pierre Gondois

ShellPkg: Fix the issue that the UEFI Shell layout is messed up

2026-06-21T16:49:02+00:00

Fixes https://github.com/tianocore/edk2/issues/12689 When the UEFI Shell mapping table is empty (NULL), the console layout becomes corrupted in DEBUG builds. This occurs because the cursor position for the message map: No mapping found. is computed incorrectly under DEBUG mode. The presence of DEBUG output from the Shell driver causes gST->ConOut->Mode->CursorRow to no longer reflect the actual cursor position on the serial port, leading to misplacement of subsequent output. This patch replaces the existing print routine with ShellPrintHiiDefaultEx(). The new function automatically calculates the correct cursor position for the "No mapping found" line, eliminating the dependency on the stale CursorRow value. As a result, the layout remains consistent regardless of DEBUG message activity. Signed-off-by: Qihang Gao

ShellPkg/TimeDate: Extract GetTimeZoneFromString() helper

2026-04-24T18:18:47+00:00

Extract a GetTimeZoneFromString() function to decrease the size of MainCmdTime(). No functional change. Signed-off-by: Pierre Gondois

ShellPkg/TimeDate: Extract PrintDaylight() helper

2026-04-24T18:18:47+00:00

Extract a PrintDaylight() function to decrease the size of MainCmdTime(). No functional change. Signed-off-by: Pierre Gondois

ShellPkg/TimeDate: Extract PrintTime() helper

2026-04-24T18:18:47+00:00

Extract a PrintTime() function to factorize the code. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/TimeDate: Extract GetCurrentTime() helper

2026-04-24T18:18:47+00:00

Extract a GetCurrentTime() function to factorize error messages. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/Ls: Extract PrintLsOutputCurr() function

2026-04-24T18:18:47+00:00

Extract a PrintLsOutputCurr() function to decrease the size of PrintLsOutput(). The patch also rationalize the usage of the Found parameter: - Found is updated only when a valid MetaFile is found - a IsRecursive variable is created to distinguish the first PrintLsOutput() call from the other recursive ones. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/Ls: Lower PrintLsOutputRec() indentation level

2026-04-24T18:18:47+00:00

Invert some conditions in PrintLsOutputRec() to lower the indentation level. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/Ls: Extract PrintLsOutputRec() function

2026-04-24T18:18:47+00:00

Extract a PrintLsOutputRec() function to decrease the size of PrintLsOutput(). No functional change. Signed-off-by: Pierre Gondois