Tianocore/edk2.git/ShellPkg/Library/UefiShellLevel2CommandsLib, branch dependabot/github_actions/actions/github-script-8EDK II (mirror)https://git.radix-linux.su/Tianocore/edk2.git/atom?h=dependabot%2Fgithub_actions%2Factions%2Fgithub-script-82025-10-01T08:02:57+00:00ShellPkg/Library: rework Shell...CommandsLib Load.c2025-10-01T08:02:57+00:00Leif Lindholmleif.lindholm@oss.qualcomm.com2025-09-22T16:31:19+00:00urn:sha1:8b22c532b37b1c26185fa4e6eb9d465e3cb7e923
CodeQL incorrectly flags that LoadedDriverImage might be derferenced
while NULL, but the actual code paths make that impossible.
Strip several levels of success handling to improve readability for
humans and static analyzers both.
Signed-off-by: Leif Lindholm <leif.lindholm@oss.qualcomm.com>
ShellPkg: Use the newly introduced ShellPrintDefaultEx() alias2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-18T12:13:00+00:00urn:sha1:aa29d51637d75aaf398fc8bda60af9726690615c
Make use the newly introduced ShellPrintDefaultEx() alias and
replace wherever it is possible:
- "ShellPrintEx (-1, -1,"
with:
- "ShellPrintDefaultEx ("
No functional change is introduced.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg: Use the newly introduced ShellPrintHiiDefaultEx() alias2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-18T12:12:11+00:00urn:sha1:c4a8b001f34c19cd411566cb4cd672eb1fac5478
Make use the newly introduced ShellPrintHiiDefaultEx() alias and
replace wherever it is possible:
- "ShellPrintHiiEx (-1, -1, NULL,"
with:
- "ShellPrintHiiDefaultEx ("
No functional change is introduced.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellLevel2CommandLib: Free Buffer after use2025-06-13T21:11:49+00:00Pierre Gondoispierre.gondois@arm.com2025-06-12T08:49:30+00:00urn:sha1:f242a0e87f1d43094f697265d66cce42a387865e
Free the allocated Buffer after use.
Reported-by: Ramesh R <rameshr@ami.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellLevel2CommandsLib: Add helper for reset -fwui option2024-12-09T17:16:58+00:00Pierre Gondoispierre.gondois@arm.com2024-10-04T11:40:48+00:00urn:sha1:e53cf2412a34c9d3a9805fe8dfd2b51f5adfff21
Following the UEFI Shell Specification revision 2.2,
add helper for the '-fwui' option of the reset command.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
ShellPkg: CodeQL Fixes2024-10-29T02:09:18+00:00Oliver Smith-Dennyosde@microsoft.com2024-10-03T17:31:31+00:00urn:sha1:334f5748869996eee994f9dee41f3e6a3d9bd087
Includes changes across the module for the following CodeQL rules:
- cpp/comparison-with-wider-type
- cpp/overflow-buffer
- cpp/redundant-null-check-param
- cpp/uselesstest
Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com>
Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
ShellPkg: UefiShellLevel2CommandsLib: CodeQL Fixes2024-10-29T02:09:18+00:00Oliver Smith-Dennyosde@microsoft.com2024-10-03T17:25:05+00:00urn:sha1:17ad30ae237bc6da7d7cb72a956777720c7a0cad
Includes changes across the module for the following CodeQL rules:
- cpp/comparison-with-wider-type
- cpp/overflow-buffer
- cpp/redundant-null-check-param
- cpp/uselesstest
Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com>
Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
ShellPkg: ShellLevel2StripQuotes: Strip consecutive quotes2024-10-04T19:34:05+00:00Tormod Voldendebian.tormod@gmail.com2024-07-27T14:11:08+00:00urn:sha1:b21cf3bd5bd75ea831471d12bd37fe07b57ae506
When a quotation mark was found, the remaining line would be shifted
in-place to get rid of it. However, the "walker" index would still be
increased and therefore the first character of the shifted part would be
skipped. This means a second quotation mark would not be deleted.
Signed-off-by: Tormod Volden <debian.tormod@gmail.com>
ShellPkg: add missing linefeed in reset message2024-09-24T16:46:26+00:00Heinrich Schuchardtheinrich.schuchardt@canonical.com2024-09-13T07:53:28+00:00urn:sha1:b8122cc9d8b6c9017905ac5f4c846b4c0f535d01
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4850
When running 'reset -s' no linefeed is printed. This results in the Linux
command line prompt not being printed at the start of a new line:
Shell> reset -s
Reset with <null string> (0 bytes)user@workstation:/tmp$
Add the missing linefeed.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
ShellPkg: Tidy for code readability2023-12-18T06:11:49+00:00Daniel Nguyendaniel.nguyen@arm.com2023-11-29T18:28:40+00:00urn:sha1:74daeded0cabe87d26546f07f9a3911cb60ec0e1
Use error handling instead of success handling.
Less indented logic is easier to read.
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Daniel Nguyen <daniel.nguyen@arm.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>