EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=edk2_master 2025-12-02T08:00:53+00:00 2025-12-02T08:00:53+00:00 Pierre Gondois pierre.gondois@arm.com 2025-11-27T20:28:22+00:00 urn:sha1:5b1530e5adb3b24224a9a3a92b1dab6395d2dc58 This patch aims to help breaking down the long function present in the ShellPkg and reduce complexity/nested code and conditions. Lower the indentation level in the newly created MainCmdXXX() functions. No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2025-12-02T08:00:53+00:00 Pierre Gondois pierre.gondois@arm.com 2025-09-20T18:06:44+00:00 urn:sha1:531b0aa00211656a738ee9612112b0dbce2658e1 This patch aims to help breaking down the long function present in the ShellPkg and reduce complexity/nested code and conditions. Extract a MainCmdXXX() function for each shell command. This command contains the possible operations the command aims to operate. The ShellCommandRunXXX() function from which it is extracted is only responsible of: - initializing the shell/command environment - parsing the command parameter and creating a Package - freeing the Package No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2025-12-02T08:00:53+00:00 Pierre Gondois pierre.gondois@arm.com 2025-09-20T17:56:38+00:00 urn:sha1:ce88903374a9be9cbc15ee80b189cef5dc2e90d8 This patch aims to help breaking down the long function present in the ShellPkg and reduce complexity/nested code and conditions. Return directly if ShellCommandLineParse() returned an error Status. In such case, the "Package" that should be allocated by ShellCommandLineParse() is already freed in: ShellCommandLineParse() \-ShellCommandLineParseEx() \-InternalCommandLineParse() so there is no need to free it with ShellCommandLineFreeVarList(). Note: Cd: Return directly if ShellCommandLineParse() returned an error Status. The initial code was ignoring the error status. Cp: Only check for ShellGetExecutionBreakFlag() if ShellCommandLineParse() returned successfully. If the command line failed to be parsed, there should be no need to check for the execution break flag. No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2025-10-01T08:02:57+00:00 Pierre Gondois pierre.gondois@arm.com 2025-09-18T12:12:11+00:00 urn:sha1:c4a8b001f34c19cd411566cb4cd672eb1fac5478 Make use the newly introduced ShellPrintHiiDefaultEx() alias and replace wherever it is possible: - "ShellPrintHiiEx (-1, -1, NULL," with: - "ShellPrintHiiDefaultEx (" No functional change is introduced. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2023-12-08T13:25:11+00:00 Page Chen paiching_chen@apple.com 2023-11-09T19:27:09+00:00 urn:sha1:fe2abc9b74b9b869e29f0ebc6dfaa54001b53e9b begining->beginning dirve->drive duplicat->duplicate fuly->fully Funciton->Function Functino->Function optioanl->optional poitners->pointers rountine->routine sucessful->successful sucessfully->successfully Signed-off-by: Page Chen <paiching_chen@apple.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Cc: Andrew Fish <afish@apple.com> Message-Id: <829d2bed2a848229d719d7ae7b64ef1a47782720.1699557986.git.paiching_chen@apple.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> 2021-12-07T17:24:28+00:00 Michael Kubacki michael.kubacki@microsoft.com 2021-12-05T22:54:13+00:00 urn:sha1:47d20b54f9a65b08aa602a1866c1b59a69088dfc REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the ShellPkg package Cc: Andrew Fish <afish@apple.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Ray Ni <ray.ni@intel.com> 2019-04-09T17:58:25+00:00 Michael D Kinney michael.d.kinney@intel.com 2019-04-03T23:07:06+00:00 urn:sha1:56ba37463a5ffa44df1c5741184ba0594fadbeba https://bugzilla.tianocore.org/show_bug.cgi?id=1373 Replace BSD 2-Clause License with BSD+Patent License. This change is based on the following emails: https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html RFCs with detailed process for the license change: V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> 2018-06-28T03:19:51+00:00 Liming Gao liming.gao@intel.com 2018-06-27T13:13:38+00:00 urn:sha1:ba0014b9f8ae1a593f03e744f26008214c2b06a8 1. Do not use tab characters 2. No trailing white space in one line 3. All files must end with CRLF Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming.gao@intel.com> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com> 2016-10-09T02:27:49+00:00 Chen A Chen chen.a.chen@intel.com 2016-09-29T06:44:22+00:00 urn:sha1:1c5cc5e5f72ce084aca05c36ccb5fde753dbd7c9 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chen A Chen <chen.a.chen@intel.com> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com> 2015-10-10T01:19:43+00:00 Qiu Shumin shumin.qiu@intel.com 2015-10-10T01:19:43+00:00 urn:sha1:938d65a58a89d8d382eb8b047fc4748d5b37f28c If you try to 'set' a read only environment variable and it fails without printing any information. This patch add error message printing when 'set' environment variable fails. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin <shumin.qiu@intel.com> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18598 6f19259b-4bc3-4df7-8a09-765794883524