Tianocore/edk2.git/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c, branch master

ShellPkg/Ls: Initialize list pointer variable

2026-08-27T07:58:44+00:00

Using an uninitialized variable resulted in a system exception when the user typed the `ls -r` command. ShellOpenFileMetaArg() only allocates a list head when this is NULL, and appends to whatever it points at otherwise. Signed-off-by: Artem Senichev

ShellPkg/Ls: Remove double-free calls

2026-08-04T07:35:35+00:00

Package is always freed in ShellCommandRunLs(). Remove calls to ShellCommandLineFreeVarList() in MainCmdLs(). This double-free was introduced in: commit 531b0aa00211 ("ShellPkg/UefiShellLevel2: Extract MainCmdXXX() function") Signed-off-by: Pierre Gondois

ShellPkg/Ls: Extract PrintLsOutputCurr() function

2026-04-24T18:18:47+00:00

Extract a PrintLsOutputCurr() function to decrease the size of PrintLsOutput(). The patch also rationalize the usage of the Found parameter: - Found is updated only when a valid MetaFile is found - a IsRecursive variable is created to distinguish the first PrintLsOutput() call from the other recursive ones. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/Ls: Lower PrintLsOutputRec() indentation level

2026-04-24T18:18:47+00:00

Invert some conditions in PrintLsOutputRec() to lower the indentation level. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/Ls: Extract PrintLsOutputRec() function

2026-04-24T18:18:47+00:00

Extract a PrintLsOutputRec() function to decrease the size of PrintLsOutput(). No functional change. Signed-off-by: Pierre Gondois

ShellPkg/Ls: Remove unused TimeZone parameter

2026-04-24T18:18:47+00:00

The TimeZone parameter is not used. Remove it. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/Ls: Hard-code number of files if none found

2026-04-24T18:18:47+00:00

If no file/directory has been found, the number of files/directories must be 0. Hard-code these values to avoid depending on the FileCount/FileSize/DirCount variables. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/Ls: Extract GetCorrectedPath() function

2026-04-24T18:18:47+00:00

Extract a GetCorrectedPath() function to decrease the size of PrintLsOutput(). Also free the CorrectedPath in PrintLsOutput() before re-allocating it to prepare for follow-up factorization. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/Ls: Move FileMetaArg closing logic

2026-04-24T18:18:47+00:00

Move ShellCloseFileMetaArg() calls to close the MetaArg whenever its usage is not needed anymore. This prepares for follow-up factorization. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/Ls: Extract UpdateFileLocalTime() function

2026-04-24T18:18:47+00:00

Extract a UpdateFileLocalTime() function to decrease the size of PrintLsOutput(). No functional change. Signed-off-by: Pierre Gondois