Tianocore/edk2.git/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c, branch edk2_masterEDK II (mirror)https://git.radix-linux.su/Tianocore/edk2.git/atom?h=edk2_master2025-12-02T08:00:53+00:00ShellPkg/UefiShellLevel2/Ls: Remove ShellStatus check in MainCmdLs()2025-12-02T08:00:53+00:00Pierre Gondoispierre.gondois@arm.com2025-12-01T16:45:59+00:00urn:sha1:95476665c4fcb41a7eb43542e375830ada04d636
Remove a check against ShellStatus in MainCmdLs() as there are
two consecutive checks without any modification of ShellStatus.
Suggested-by: Leif Lindholm <leif.lindholm@oss.qualcomm.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellLevel2/Ls: Bail out early in MainCmdLs()2025-12-02T08:00:53+00:00Pierre Gondoispierre.gondois@arm.com2025-12-01T15:33:39+00:00urn:sha1:8e822d5d262b63a17315f1156e2277b3837b59bf
If RootPath is NULL, PrintLsOutput() will return an error code
of SHELL_OUT_OF_RESOURCES and not print anything:
PrintLsOutput()
\-StrnCatGrow()
if (Source == NULL) {
return (*Destination);
}
Remove paths where FullPath ends up being NULL and bail out
early.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellLevel2/Ls: Flatten MainCmdLs()2025-12-02T08:00:53+00:00Pierre Gondoispierre.gondois@arm.com2025-12-01T15:22:30+00:00urn:sha1:0b982813c756569be8f54f177bde090b76e9638e
Remove some of the success handling conditions to flatten
the MainCmdLs() function.
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellLevel2: Lower indentation level in MainCmdXXX()2025-12-02T08:00:53+00:00Pierre Gondoispierre.gondois@arm.com2025-11-27T20:28:22+00:00urn:sha1:5b1530e5adb3b24224a9a3a92b1dab6395d2dc58
This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.
Lower the indentation level in the newly created MainCmdXXX()
functions.
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellLevel2: Extract MainCmdXXX() function2025-12-02T08:00:53+00:00Pierre Gondoispierre.gondois@arm.com2025-09-20T18:06:44+00:00urn:sha1:531b0aa00211656a738ee9612112b0dbce2658e1
This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.
Extract a MainCmdXXX() function for each shell command.
This command contains the possible operations the command aims
to operate. The ShellCommandRunXXX() function from which it
is extracted is only responsible of:
- initializing the shell/command environment
- parsing the command parameter and creating a Package
- freeing the Package
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellLevel2: Return if ShellCommandLineParse() failed2025-12-02T08:00:53+00:00Pierre Gondoispierre.gondois@arm.com2025-09-20T17:56:38+00:00urn:sha1:ce88903374a9be9cbc15ee80b189cef5dc2e90d8
This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.
Return directly if ShellCommandLineParse() returned an error Status.
In such case, the "Package" that should be allocated by
ShellCommandLineParse() is already freed in:
ShellCommandLineParse()
\-ShellCommandLineParseEx()
\-InternalCommandLineParse()
so there is no need to free it with ShellCommandLineFreeVarList().
Note:
Cd:
Return directly if ShellCommandLineParse() returned an error
Status. The initial code was ignoring the error status.
Cp:
Only check for ShellGetExecutionBreakFlag() if
ShellCommandLineParse() returned successfully. If the command
line failed to be parsed, there should be no need to check for
the execution break flag.
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg: Use the newly introduced ShellPrintHiiDefaultEx() alias2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-18T12:12:11+00:00urn:sha1:c4a8b001f34c19cd411566cb4cd672eb1fac5478
Make use the newly introduced ShellPrintHiiDefaultEx() alias and
replace wherever it is possible:
- "ShellPrintHiiEx (-1, -1, NULL,"
with:
- "ShellPrintHiiDefaultEx ("
No functional change is introduced.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg: CodeQL Fixes2024-10-29T02:09:18+00:00Oliver Smith-Dennyosde@microsoft.com2024-10-03T17:31:31+00:00urn:sha1:334f5748869996eee994f9dee41f3e6a3d9bd087
Includes changes across the module for the following CodeQL rules:
- cpp/comparison-with-wider-type
- cpp/overflow-buffer
- cpp/redundant-null-check-param
- cpp/uselesstest
Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com>
Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
ShellPkg: UefiShellLevel2CommandsLib: CodeQL Fixes2024-10-29T02:09:18+00:00Oliver Smith-Dennyosde@microsoft.com2024-10-03T17:25:05+00:00urn:sha1:17ad30ae237bc6da7d7cb72a956777720c7a0cad
Includes changes across the module for the following CodeQL rules:
- cpp/comparison-with-wider-type
- cpp/overflow-buffer
- cpp/redundant-null-check-param
- cpp/uselesstest
Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com>
Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
ShellPkg: Fix typos2023-12-08T13:25:11+00:00Page Chenpaiching_chen@apple.com2023-11-09T19:27:09+00:00urn:sha1:fe2abc9b74b9b869e29f0ebc6dfaa54001b53e9b
begining->beginning
dirve->drive
duplicat->duplicate
fuly->fully
Funciton->Function
Functino->Function
optioanl->optional
poitners->pointers
rountine->routine
sucessful->successful
sucessfully->successfully
Signed-off-by: Page Chen <paiching_chen@apple.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Andrew Fish <afish@apple.com>
Message-Id: <829d2bed2a848229d719d7ae7b64ef1a47782720.1699557986.git.paiching_chen@apple.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>