EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=edk2_master 2025-12-02T08:00:53+00:00 2025-12-02T08:00:53+00:00 Pierre Gondois pierre.gondois@arm.com 2025-09-20T18:06:44+00:00 urn:sha1:531b0aa00211656a738ee9612112b0dbce2658e1 This patch aims to help breaking down the long function present in the ShellPkg and reduce complexity/nested code and conditions. Extract a MainCmdXXX() function for each shell command. This command contains the possible operations the command aims to operate. The ShellCommandRunXXX() function from which it is extracted is only responsible of: - initializing the shell/command environment - parsing the command parameter and creating a Package - freeing the Package No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2025-12-02T08:00:53+00:00 Pierre Gondois pierre.gondois@arm.com 2025-09-20T17:56:38+00:00 urn:sha1:ce88903374a9be9cbc15ee80b189cef5dc2e90d8 This patch aims to help breaking down the long function present in the ShellPkg and reduce complexity/nested code and conditions. Return directly if ShellCommandLineParse() returned an error Status. In such case, the "Package" that should be allocated by ShellCommandLineParse() is already freed in: ShellCommandLineParse() \-ShellCommandLineParseEx() \-InternalCommandLineParse() so there is no need to free it with ShellCommandLineFreeVarList(). Note: Cd: Return directly if ShellCommandLineParse() returned an error Status. The initial code was ignoring the error status. Cp: Only check for ShellGetExecutionBreakFlag() if ShellCommandLineParse() returned successfully. If the command line failed to be parsed, there should be no need to check for the execution break flag. No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2025-10-01T08:02:57+00:00 Pierre Gondois pierre.gondois@arm.com 2025-09-18T12:13:00+00:00 urn:sha1:aa29d51637d75aaf398fc8bda60af9726690615c Make use the newly introduced ShellPrintDefaultEx() alias and replace wherever it is possible: - "ShellPrintEx (-1, -1," with: - "ShellPrintDefaultEx (" No functional change is introduced. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2025-10-01T08:02:57+00:00 Pierre Gondois pierre.gondois@arm.com 2025-09-18T12:12:11+00:00 urn:sha1:c4a8b001f34c19cd411566cb4cd672eb1fac5478 Make use the newly introduced ShellPrintHiiDefaultEx() alias and replace wherever it is possible: - "ShellPrintHiiEx (-1, -1, NULL," with: - "ShellPrintHiiDefaultEx (" No functional change is introduced. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2025-06-13T21:11:49+00:00 Pierre Gondois pierre.gondois@arm.com 2025-06-12T08:49:30+00:00 urn:sha1:f242a0e87f1d43094f697265d66cce42a387865e Free the allocated Buffer after use. Reported-by: Ramesh R <rameshr@ami.com> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2024-10-29T02:09:18+00:00 Oliver Smith-Denny osde@microsoft.com 2024-10-03T17:31:31+00:00 urn:sha1:334f5748869996eee994f9dee41f3e6a3d9bd087 Includes changes across the module for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com> 2024-10-29T02:09:18+00:00 Oliver Smith-Denny osde@microsoft.com 2024-10-03T17:25:05+00:00 urn:sha1:17ad30ae237bc6da7d7cb72a956777720c7a0cad Includes changes across the module for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com> 2021-12-07T17:24:28+00:00 Michael Kubacki michael.kubacki@microsoft.com 2021-12-05T22:54:13+00:00 urn:sha1:47d20b54f9a65b08aa602a1866c1b59a69088dfc REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the ShellPkg package Cc: Andrew Fish <afish@apple.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Ray Ni <ray.ni@intel.com> 2019-08-13T02:51:36+00:00 Gao, Zhichao zhichao.gao@intel.com 2019-08-12T15:36:21+00:00 urn:sha1:12dcad5b1ec58eb33c351854ae37942b996ed2e5 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2049 ShellPkg\Library\UefiShellLevel2CommandsLib\Cp.c line 104 and ShellPkg\Library\UefiShellLevel2CommandsLib\Mv.c line 640, the pointer variable Response may be a NULL pointer. So we should make sure that it isn't NULL before dereference it. If Response is NULL that indicates a EFI_OUT_OF_RESOURCES error, directly return SHELL_ABORTED. Cc: Jaben Carsey <jaben.carsey@intel.com> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> 2019-04-09T17:58:25+00:00 Michael D Kinney michael.d.kinney@intel.com 2019-04-03T23:07:06+00:00 urn:sha1:56ba37463a5ffa44df1c5741184ba0594fadbeba https://bugzilla.tianocore.org/show_bug.cgi?id=1373 Replace BSD 2-Clause License with BSD+Patent License. This change is based on the following emails: https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html RFCs with detailed process for the license change: V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>