EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=dependabot%2Fgithub_actions%2Factions%2Fsetup-python-6 2025-07-25T09:57:50+00:00 2025-07-25T09:57:50+00:00 Nanjinmoorthyj nanjinmoorthyj@ami.com 2025-07-09T13:49:41+00:00 urn:sha1:47e818016a8e360ccdea0c01f5af5f5d0f13de80 Remove the error handling from the connect.c file as it is redundant. Signed-off-by: Nanjinmoorthy <nanjinmoorthyj@ami.com> 2025-01-24T10:02:23+00:00 zhu rui cliff.zhu@intel.com 2025-01-15T05:28:47+00:00 urn:sha1:33309733e44c081e71f1af46e2ee5b31a10aa09e REF: https://github.com/tianocore/edk2/issues/10626 Issue command drvcfg directly, system halt Signed-off-by: "Zhu, Cliff" <Cliff.zhu@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> 2024-10-29T02:09:18+00:00 Oliver Smith-Denny osde@microsoft.com 2024-10-03T17:31:31+00:00 urn:sha1:334f5748869996eee994f9dee41f3e6a3d9bd087 Includes changes across the module for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com> 2024-10-29T02:09:18+00:00 Oliver Smith-Denny osde@microsoft.com 2024-10-03T17:29:42+00:00 urn:sha1:c69e5e647d69fcbb6d2a4e5da82e72122d41566f Includes changes across the module for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com> 2023-12-08T13:25:11+00:00 Page Chen paiching_chen@apple.com 2023-11-09T19:27:09+00:00 urn:sha1:fe2abc9b74b9b869e29f0ebc6dfaa54001b53e9b begining->beginning dirve->drive duplicat->duplicate fuly->fully Funciton->Function Functino->Function optioanl->optional poitners->pointers rountine->routine sucessful->successful sucessfully->successfully Signed-off-by: Page Chen <paiching_chen@apple.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Cc: Andrew Fish <afish@apple.com> Message-Id: <829d2bed2a848229d719d7ae7b64ef1a47782720.1699557986.git.paiching_chen@apple.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> 2023-06-02T08:34:00+00:00 Gerd Hoffmann kraxel@redhat.com 2023-04-26T11:39:27+00:00 urn:sha1:a8acc12dfd80e4b2770c5912b1dbe1a04ab649d6 In case ShellConvertStringToUint64() fails the Handles are left uninitialized. That can for example happen for Handle2 and Handle3 in case only one parameter was specified on the command line. Which can trigger the ASSERT() in line 185. Reproducer: boot ovmf to efi shell in qemu, using q35 machine type, then try disconnect the sata controller in efi shell. Fix that by explicitly setting them to NULL in that case. While being at it also simplify the logic and avoid pointlessly calling ShellConvertStringToUint64() in case ParamN is NULL. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> 2023-04-03T15:29:08+00:00 Michael Kubacki michael.kubacki@microsoft.com 2022-11-08T20:35:39+00:00 urn:sha1:11dd44dfbefab2ca0b9160bb5ebe40bc1c70f7c1 Fixes CodeQL alerts for CWE-457: https://cwe.mitre.org/data/definitions/457.html Cc: Erich McMillan <emcmillan@microsoft.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Michael Kubacki <mikuback@linux.microsoft.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Co-authored-by: Erich McMillan <emcmillan@microsoft.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Oliver Smith-Denny <osd@smith-denny.com> 2023-03-13T22:11:55+00:00 Michael D Kinney michael.d.kinney@intel.com 2023-03-11T19:31:51+00:00 urn:sha1:e4c1d8d2317984bd9cb447eba916956841063ec4 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4366 Update C and UNI files that are incorrectly using %x or %08x instead of %p for pointer values. On 64-bit systems, this is truncating pointer values above 4GB. In reviewing ShellPkg for this issue some unused UNI strings with incorrect format specifiers were removed instead of being fixed. Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> 2021-12-07T17:24:28+00:00 Michael Kubacki michael.kubacki@microsoft.com 2021-12-05T22:54:13+00:00 urn:sha1:47d20b54f9a65b08aa602a1866c1b59a69088dfc REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the ShellPkg package Cc: Andrew Fish <afish@apple.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Ray Ni <ray.ni@intel.com> 2021-06-09T06:12:52+00:00 Rebecca Cran rebecca@nuviainc.com 2021-05-05T19:45:30+00:00 urn:sha1:beb443fde09e2f7ff32a699e44ac6480b068d9ec Fix typo of 'specified' in UefiShellDriver1CommandsLib. Signed-off-by: Rebecca Cran <rebecca@nuviainc.com> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>