Tianocore/edk2.git/ShellPkg/Library/UefiShellDriver1CommandsLib/Drivers.c, branch masterEDK II (mirror)https://git.radix-linux.su/Tianocore/edk2.git/atom?h=master2026-04-09T11:13:08+00:00ShellPkg/UefiShellDriver1: Remove unused Status2026-04-09T11:13:08+00:00Pierre Gondoispierre.gondois@arm.com2026-04-08T14:21:28+00:00urn:sha1:76406ef119625ee3185d4ae3bf7701147dba50ac
Status is set but never used.
Remove the variable.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellDriver1/Drivers: Fix memory leaks2026-04-09T11:13:08+00:00Pierre Gondoispierre.gondois@arm.com2026-04-08T13:03:04+00:00urn:sha1:1ab251c770170b05a892b1c6a218603d83f2123d
Free Language/FormatString before exiting the function.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellDriver1: Lower indentation level in MainCmdXXX()2026-04-09T11:13:08+00:00Pierre Gondoispierre.gondois@arm.com2026-04-08T12:18:49+00:00urn:sha1:becbdb4e27661002ecf08814028b631e0dbe4e9b
This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.
Lower the indentation level in the newly created MainCmdXXX()
functions.
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellDriver1: Extract MainCmdXXX() function2026-04-09T11:13:08+00:00Pierre Gondoispierre.gondois@arm.com2026-01-18T14:28:44+00:00urn:sha1:4de99ebb926a09229eb0bb1c7f83339216b6cf94
This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.
Extract a MainCmdXXX() function for each shell command.
This command contains the possible operations the command aims
to operate. The ShellCommandRunXXX() function from which it
is extracted is only responsible of:
- initializing the shell/command environment
- parsing the command parameter and creating a Package
- freeing the Package
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellDriver1: Return if ShellCommandLineParse() failed2026-04-09T11:13:08+00:00Pierre Gondoispierre.gondois@arm.com2026-01-18T10:51:39+00:00urn:sha1:51cdb08cdb7241f7521e9cf1c86cdb922f0013b3
This patch aims to help breaking down the long function present in
the ShellPkg and reduce complexity/nested code and conditions.
Return directly if ShellCommandLineParse() returned an error Status.
In such case, the "Package" that should be allocated by
ShellCommandLineParse() is already freed in:
ShellCommandLineParse()
\-ShellCommandLineParseEx()
\-InternalCommandLineParse()
so there is no need to free it with ShellCommandLineFreeVarList().
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg: Use the newly introduced ShellPrintDefaultEx() alias2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-18T12:13:00+00:00urn:sha1:aa29d51637d75aaf398fc8bda60af9726690615c
Make use the newly introduced ShellPrintDefaultEx() alias and
replace wherever it is possible:
- "ShellPrintEx (-1, -1,"
with:
- "ShellPrintDefaultEx ("
No functional change is introduced.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg: Use the newly introduced ShellPrintHiiDefaultEx() alias2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-18T12:12:11+00:00urn:sha1:c4a8b001f34c19cd411566cb4cd672eb1fac5478
Make use the newly introduced ShellPrintHiiDefaultEx() alias and
replace wherever it is possible:
- "ShellPrintHiiEx (-1, -1, NULL,"
with:
- "ShellPrintHiiDefaultEx ("
No functional change is introduced.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg: UefiShellDriver1CommandsLib: CodeQL Fixes2024-10-29T02:09:18+00:00Oliver Smith-Dennyosde@microsoft.com2024-10-03T17:29:42+00:00urn:sha1:c69e5e647d69fcbb6d2a4e5da82e72122d41566f
Includes changes across the module for the following CodeQL rules:
- cpp/comparison-with-wider-type
- cpp/overflow-buffer
- cpp/redundant-null-check-param
- cpp/uselesstest
Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com>
Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
ShellPkg: Apply uncrustify changes2021-12-07T17:24:28+00:00Michael Kubackimichael.kubacki@microsoft.com2021-12-05T22:54:13+00:00urn:sha1:47d20b54f9a65b08aa602a1866c1b59a69088dfc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737
Apply uncrustify changes to .c/.h files in the ShellPkg package
Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
ShellPkg: Fix spelling mistake for occurred2020-08-19T00:54:23+00:00Michael D Kinneymichael.d.kinney@intel.com2020-08-01T00:52:32+00:00urn:sha1:a048af3c9073e4b8108e6cf920bbb35574059639
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2361
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>