Tianocore/edk2.git/ShellPkg/Library/UefiShellDebug1CommandsLib, branch masterEDK II (mirror)https://git.radix-linux.su/Tianocore/edk2.git/atom?h=master2026-08-04T07:35:35+00:00ShellPkg/EfiDecompress: Fix Codeql issues2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-05-27T14:55:26+00:00urn:sha1:fa41c179db1f9fc21eb425f44b85a16262c806ca
Fix codeql reported issues by flattening MainCmdEfiDecompress(),
making it easier for the tool to evaluate potential risks.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Comp: Extract helper functions2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-05-26T11:02:20+00:00urn:sha1:383e680c3cf62b564783a5a26eae0b9ffd881b61
Refactor the Comp command and extract 2 functions:
- OpenFileOperand()
- CompareFiles()
This allows to simplify the logic of MainCmdComp() and
fix some codeql reported potential errors.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/EfiDecompress: Check presence of decompression protocol2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-05-26T10:31:10+00:00urn:sha1:35a2f2754615bb3e029d3c86da09f8a32e5b14a1
Check the return value of LocateProtocol() before
using the decompression protocol. This avoids a
potential NULL pointer derefence spotted by codeql.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Dmem: Refactor MainCmdDmem()2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-05-26T09:29:15+00:00urn:sha1:d9185d45c21ba5f385996b9d76309e2cc24cc2af
Refactor MainCmdDmem() to make it easier to understand.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/EfiCompress: Extract OpenFileHelper() and CompressFile()2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-05-06T10:37:59+00:00urn:sha1:f260ae0375876d2d8683d7dab54071b1d980b15b
Extract file opening and compression code into helpers.
Upon calling:
- gEfiShellProtocol->GetFileSize()
- gEfiShellProtocol->ReadFile()
the returned Status is now checked.
Upon calling AllocateZeroPool, the failed status is now set to
EFI_OUT_OF_RESOURCES.
Other than that, no functional change.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Pci: Extract ParsePciBdf()2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-05-06T10:11:44+00:00urn:sha1:c089090278236fdd84404b9ec233835aa0accc96
Extract BDF argument parsing into a helper.
No functional change.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Pci: Extract PciEnumerateAll()2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-05-06T09:47:14+00:00urn:sha1:ba2f2169863df9a5012eb2882cfe2822a49955e4
Extract the default PCI enumeration path into a helper.
No functional change.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (4/4)2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-06-04T09:21:31+00:00urn:sha1:42f1d004c070e60d05281f98afca56d897d395e9
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Lower the indentation level in the newly created MainCmdXXX()
functions.
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- SerMode.c
- SetSize.c
- SetVar.c
- SmbiosView/SmbiosView.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (3/4)2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-06-04T09:21:15+00:00urn:sha1:642954d2956420fa5855754ba41ab2cca7b73c3c
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Lower the indentation level in the newly created MainCmdXXX()
functions.
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- MemMap.c
- Mm.c
- Mode.c
- Pci.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (2/4)2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-06-04T09:21:00+00:00urn:sha1:d395696428e7198a7369f52a61e579d7a2bf8cd6
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Lower the indentation level in the newly created MainCmdXXX()
functions.
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- Edit/Edit.c
- EfiCompress.c
- EfiDecompress.c
- LoadPciRom.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>